Questions tagged [site-policy]

Site-Policy is the way the main site is run and managed - processes, procedures, and routines that should be followed. Use this tag when you believe site-policy has not been applied correctly to a main-site question, or when you believe existing site policies should be modified, or new policies added.

Filter by
Sorted by
Tagged with
134
votes
2answers
17k views

For an iterative review, is it okay to edit my own question to include revised code?

Is it okay to edit the question to include the improved code? I would like to do so for the following reasons: To share the improved code with others To show the answering persons that I take their ...
46
votes
2answers
2k views

Can I put my code on a third party site and link to the site in my question?

Is it OK if I write a question and include a link to GitHub/Pastebin/other similar site instead of putting the code here on Code Review?
40
votes
1answer
1k views

How to post a follow-up question?

Sometimes I stumble upon follow-up questions, where code is being posted again after having gone through a review (or two). Examples of possible sets of follow up questions: Find missing numbers - ...
40
votes
8answers
2k views

Short answers and code-only answers

What should we do with: Short answers (for example, "I suggest you use [hyperlink to this standard API] instead.") Code-only answers (for example, an improved version of the code in the OP) Such ...
34
votes
2answers
1k views

Why is only my own written code on-topic?

I tend to disagree with point #2 on the Help Center: Did I write that code? I believe any code, written by one self or anyone else should be eligible for code review. Many a times, you're ...
30
votes
3answers
825 views

Should you edit someone else's code in a question?

I have seen several (suggested) reviews lately, where someone edits the code in the original poster's question. Should such edits be allowed? The edits in question are mostly minor. Some add spaces ...
23
votes
2answers
559 views

How should we deal with askers fixing off-topic questions when an answer has been posted?

I did a quick search to see if this has been asked, but it didn't seem to be. The intent behind this question is from how this question was handled, but is not limited to it. The situation is an ...
15
votes
4answers
633 views

Questions should include a description of what the code does

Related: What criteria do you use to upvote a question? What makes a good question? I feel that it is currently too easy to copy some code that you have written and put it up for review here on Code ...
37
votes
5answers
848 views

What is the appropriate length of a Code Review question?

While Stack Overflow questions often contain segments of pseudocode or purposely abbreviated code in order to make the question more palatable to other readers, for something like a Code Review, the ...
17
votes
4answers
351 views

Should a post with no specific question(s) imply a general review?

I've started thinking about this more after seeing this question. I'm sometimes tempted to vote such questions as not clear what you're asking, but I also feel that it's not quite needed for this ...
32
votes
6answers
554 views

Is code ever clean enough? - Can there be too many follow-up questions?

Some posts can at times have several follow-up questions, sometimes a couple of follow-up questions on the same day. All this brings us to the question of Can there be too many follow-up questions? ...
18
votes
4answers
369 views

Should comparisons of code snippets be closed as “not seeking a code review”?

I've been seeing some "A vs. B" questions for a while, and I'm not sure if they're considered on-topic for this site. Many of these questions are not asking for a review, but which code snippet is ...
10
votes
1answer
380 views

Is pseudo-code alright when asking about performance?

The FAQ states: Is it actual code from a project rather then pseudo-code or example code? But oftentimes pseudo-code is a lot more straight forward and easy to evaluate. It also applies to a ...
17
votes
1answer
294 views

Put into FAQ: “Will submitted code be licensed under the copyleft CC-BY-SA?”

Put into FAQ: Will submitted code be licensed under the copyleft Creative Commons Attribution-ShareAlike (CC-BY-SA) license? I really want to know this! Since the CC-BY-SA is a copyleft, viral ...
16
votes
1answer
374 views

How long can code be?

First of all before, I hate the typical "codez plz" homework question. I hope this has nothing to do with that, but it is actually a class assignment. I won't post my code until it is completely ...
21
votes
3answers
404 views

Is it okay to add someone else's linked code to the question?

Some questions link to the code they want reviewed, which is against site policy. Should one edit the code into the question in these cases? The problem I see is that all content on Stack Exchange ...
11
votes
3answers
259 views

Are database design reviews in scope?

See this question: Can you peer review my database design for a school system?
18
votes
3answers
261 views

Reviews of code not stored here

This question is inspired by a question I just saw: Review website done after one week of learning HTML and CSS How do we want to handle these issues? We wanted to avoid pastebins since having the ...
7
votes
2answers
252 views

Is it okay to edit part(s) of code not yet reviewed?

In this question of mine, the one answerer so far has only reviewed a part of my code. However, I've made changes on other parts of my code, but I don't want to somehow invalidate that answer. Would ...
10
votes
1answer
224 views

Should mostly working but a little bit broken code stay or be deleted?

I posted the question Parsing structured text in Java At first I thought it was working, later I have found a bug in the code. Should it stay or should it be deleted? Update: I have fixed the bug in ...
14
votes
3answers
213 views

Should name of programming language be in the title of a question?

Almost every question on the website has the name of the programming language in its title. Also words like feedback, review etc. are unneeded I think as that is this website's purpose. I wanted the ...
15
votes
2answers
581 views

Should specific questions about example code be on-topic?

I've noticed some questions, like the following, come up: https://codereview.stackexchange.com/questions/30092/map-then-iterate-why Inheritance and forcing methods to be called inside another method ...
12
votes
3answers
205 views

Could incomplete or not-quite-working code be suitable for review?

I've noticed that sometimes I end up reviewing code despite the question's violation of our policy that it must contain working code. I bring this issue up because it is related to Changing wording ...
12
votes
2answers
137 views

Confused by FAQ

The FAQ states [emphasis mine]: Code Review - Stack Exchange is for sharing code from projects you are working on for peer review. If you are looking for specific feedback about… Code correctness ...
14
votes
2answers
227 views

Should votes to close a question as containing broken code be paired with a comment?

First off; I'm not looking to enforce this via systems; just as a community guideline. As an example to showcase my issue, here's a review that may pop up in the review queue for Close Votes. It's ...
34
votes
5answers
527 views

Migration paths to other sites

If you can cast close votes, you now have a new privilege! Up until recently, only moderators could migrate an off-topic question to Stack Overflow or Programmers.SE - if you haven't noticed yet, the ...
18
votes
2answers
367 views

Should code block(s) as answers always require an explanation?

Here is a great example of this. Granted, that was that user's first post, but this is still common. UPDATE: That example has since been updated, so consult the original version. This type of ...
16
votes
4answers
274 views

Homework Questions

We may soon see questions that are really part of somebody's homework. Given that this site is about advice and critique that can go as far as providing complete code alternatives should we be wary ...
16
votes
1answer
137 views

Handling Asker not learning from previous reviews

Recently, a certain user has asked three times for code reviews in quick succession, for different parts of a project he is doing. This in itself is perfectly fine. However, he does not seem to have ...
14
votes
4answers
195 views

Do we need to revisit code-golf questions?

The question of the role of code-golf on CodeReview was raised back in April. There was very little discussion, but there seemed to be a strong consensus at the time among meta users that code golf ...
14
votes
1answer
124 views

Code-correctness in the FAQ

As pointed by the poster of this question: https://codereview.stackexchange.com/questions/8609/dynamic-programming-algorithm-code-review, our FAQ states the following is on-topic: Code correctness ...
14
votes
4answers
747 views

Project Euler Solutions

I was thinking that some of my python solutions to project Euler problems might be good candidates for code review - pretty short little programs that I've tried to write well, but would love to get ...
9
votes
3answers
210 views

Should be focus on solving OPs problem or more general analysis

I couldn't come up with a better title so bear with me. Preface (please read): The private beta is slowly coming to an end so i'd like to have discuss a little about that topic since onces public ...
4
votes
1answer
205 views

Why is pseudocode not allowed?

Re: C# code to derive tangential points between two circles to create a trapezoid I made the following comment, but since I will probably delete the OP (if I can), I'll post it here: "With all due ...
14
votes
1answer
94 views

Do we want site-specific editing guidance?

With our newly reached "graduated" (I really shouldn't put that in quotes) status, I expect a significant influx of new users, be it through migration or otherwise being drawn in by the thrill of a ...
14
votes
2answers
160 views

Should we retain unanswered questions from deleted users?

Background We've had a user who asked many questions, mainly follow-up questions, some of which lacked sufficient detail and a review request. Due to some issues stemming from issues of the user and ...
10
votes
1answer
138 views

Questions that ask for you to e-mail them to get the code

What is the appropriate way to handle a question that doesn't post the code to review, but posts an e-mail address that you can I assume e-mail and get the code? A (now-deleted) example is: ...
8
votes
2answers
140 views

Can I ask for a review on a website?

Is this OK or not really? If I develop a website template, CSS/HTML/JS, is it acceptable to post that as a code sample to be reviewed as an external URL?
4
votes
1answer
109 views

Should quick fixes to non-working code go into comments only?

I've started thinking about this after seeing the answer for this question. Of course, non-working code shouldn't be posted here. However, there are times where someone addresses such issues in an ...
2
votes
1answer
112 views

Cleaning up the original code in the question

Most of the reviewers/answerers here should be familiar enough with Ctrl+K and Home,Shift+▼,Del keystroke combinations that an edit to provide some readability without losing the original content of ...
14
votes
2answers
232 views

Can graphical notation count as code or should questions with exclusively graphical notation be considered off topic?

As a community, are we willing to accept graphical notation as a form of code that is subject to code review? I recently answered a question that asked for review of a database model as presented in ...
3
votes
5answers
302 views

Complaint about rollback policy / bug fixes

I posted some useful code on code review. One of the answers suggested an improvement to the code. I agreed and made the improvement to the code, and left the comment "Thanks, fixed". A moderator ...
18
votes
3answers
219 views

What are our answer editing guidelines?

On this site, we have a well-known policy on editing code in questions: Don't. After all, that code is up for review, in all its glorious ugliness and buginess. But clearly, such reasoning cannot ...
13
votes
2answers
149 views

Is asking for review of 3rd party code ok?

Most code people are posting here seems to be code they have written themselves. In this question the OP asked basically for a review of three 3rd party scripts. I'm not sure that this question is a ...
10
votes
1answer
159 views

What's the proper way to ask for database review?

I'm currently designing a database that I wanted to get some input on. It's entirely theoretical at this point, I haven't written a single line of SQL. Would it be acceptable to just post the database ...
9
votes
1answer
130 views

Reviewing usefulness of code

I was wondering if, as part of asking for a review here, can I ask about how useful my code is? That is, getting feedback about what possible use-cases the code I have written has and if people would ...
7
votes
2answers
117 views

Attribution and Copyright of Problems

How should it be handled if a user asks a question where the original problem is from some website and under copyright? For example this question quotes a problem from a website which says at the ...
6
votes
4answers
86 views

Would Code Review be a good site to post formatting questions?

I've been thinking recently that Code Review might encapsulate Code Presentation style, such as: Helpful comments and documentation. Indentation/bracketing style. Overall code structure. Of course, ...
6
votes
2answers
86 views

Is asking for correctness check on-topic or not?

As per this and this question on meta, asking about correctness is on-topic yet this question was closed. The comment given was: This question appears to be off-topic because it is about reviewing ...
5
votes
1answer
194 views

Which is the better fit — Code Review or Stack Overflow?

In the CR question "Terminating a C loop when maximum hardware limit reached" the use of a positive sum wrapping to a negative value is used to terminate the loop. The queston was posted to Code ...