Questions tagged [specific-question]

A specific question refers to a particular and individual question on the site. This tag is used to query the community on the specifics of a particular question asked on the main site or the meta site.

32
votes
2answers
474 views

How well is “malicious” code accepted here?

I recently asked a question that could possibly be used for malicious purposes. I tried to whittle the code down as much as I could to a "base" program so that a script kiddie wouldn't stumble across ...
27
votes
7answers
734 views

New answers on old questions using new language features

Times and technologies advance, and, as a consequence, code that was up for review 'years ago' would be done differently using current technology. Is it OK on Code Review to add answers to old ...
21
votes
1answer
208 views

Complete code rewrite

I came across this question today: Count the ways to partition an array into two equal sets This question can be interpreted in a way, that it asks for a complete rewrite of the code, and indeed ...
20
votes
2answers
199 views

Should code be forcibly translated into English?

In Sieve prime generator C++, a user translated some French strings into English, and the edit got approved. In toBase64 encoder, the author replaced Russian strings and comments with English in ...
17
votes
3answers
173 views

Should we nuke this post from orbit?

Normally I wouldn't ask, I'd just kill it with fire. But this post is a bit... special. Derpifying Images It's an anti-post, a troll question... and yet, it's one we love to hate. From the ...
17
votes
2answers
107 views

May another user fix broken code in a question to make it on-topic?

If we find that a question contains obviously broken code, our standard procedure is to close the question, sending the author back to the drawing board. But is it acceptable for another user to edit ...
17
votes
1answer
295 views

Is this question popularity normal?

I was on Code Review, asking a question for the first time. I thought my question was good, but it never crossed my mind that it would become popular enough to make it to the hot list. It did, and I ...
16
votes
5answers
236 views

Are questions with undiscovered bugs allowed?

Re: Connect 4 in C++ Situation: The OP, a beginner posted code with several bugs in it. They said they thought the code worked okay, because they hadn't discovered the bugs during their testing, ...
16
votes
2answers
148 views

How broken does code have to be to for a question to be closed?

I recently voted to close this question: The longest subsequence with specified difference between min and max Originally I thought the code was really bad because the OP claimed a linear solution, ...
16
votes
2answers
176 views

Does this question belong on Code Review? Should it go to Code Golf?

I posted this question about how to rewrite a C# algorithm in fewer lines of code, preferably using extension methods, which prompted a discussion in the comments about whether it was appropriate for ...
16
votes
3answers
190 views

Can we review spreadsheet formulas?

So, this question has been bothering me for a long time now. It is asking for a review of one line of "code" which is really a spreadsheet formula. Actually, it's not even asking for a review in my ...
16
votes
7answers
211 views

One Question Per Question

I voted to close this question as being "Too Broad," on account of the fact that it's actually five, independent questions. At the very least, an answer would have to address all five questions, so it'...
16
votes
2answers
116 views

When should the community undelete a question that has been deleted by its author?

Today it happened again that I wanted to post an answer to a question, which all of you know can take some time to write, but some minutes ago the question had been deleted by the owner. For the (...
15
votes
6answers
237 views

Post Mortems - Episode I: A new hope

Prologue: A long long time ago (Apr. 17th, 16:00), in a galaxy far away, there was a stranger, seeking enlightenment. He came across a miraculous star named CodeReview in the deepest ...
15
votes
3answers
236 views

Am I misunderstanding the basis for Code Review?

I posted a question that seems to have gotten some commentless downvotes. Fetching a set of event IDs from a database based on a set of company IDs Keeping it meta, did I misunderstand something ...
15
votes
3answers
247 views

Edit dispute - Indentation on questions

This suggested edit was rejected. As it should be - rolfl here has the correct reason: Whitespace "fixes" should be part of an answer, not an edit. Please do not fix code problems in the question. ...
15
votes
4answers
202 views

How to resolve 3 numbers - that's the question

Checking if 3 numbers are an arithmetic progression Update: The question has now been unlocked. It remains closed. The Unlock is a 'probationary' act, if the situation remains in control, that's ...
15
votes
3answers
247 views

What to do if the asker's code contains bugs?

Based on this question: WPF Calculator Code The question's code... works, according to the author. However, I quickly spotted multiple bugs. I know that Code Review is not there for fixing bugs. A ...
15
votes
2answers
239 views

Nothing to review

This question claims to implement the Nothing language. I'm citing the language specification (emphasis mine): Note: if the output does not meet the expectation of a "hello world"-program, this ...
15
votes
2answers
631 views

Is it ok to conceal the origin of a programming challenge?

I'd appreciate some input on this question, where I have a disagreement with the poster. Background: Google has a semi-secret recruitment program for software developers known as the "Foobar ...
14
votes
6answers
149 views

Closing a question because the posted code was produced quickly

I came across this question in my "close votes" review queue: Block_breaker clone in pygame with simple edge detection And noted that the close reason given was: Other: I'm voting to close this ...
14
votes
4answers
207 views

Code requiring a third-party pre-processor to make it work

In this Wolves, Goats and Cabbages in Java question (here is a link to the pre-edited version), Java code is presented to solve the problem. The code requires pre-processing by a third-party tool in ...
14
votes
4answers
270 views

Question removed after a harsh review

After I reviewed code in this question, the question was deleted. My review was harsh, but I warned it would be in the first sentence, and I thought being fair was more important. If the community ...
14
votes
2answers
169 views

Why was this question closed as off-topic after a bug was discovered by the answers?

TL;DR Please clarify: is a previously unknown bug a reason to close a question as off-topic? Yesterday I was interested to answer this question, where an already written answer pointed out the ...
14
votes
3answers
187 views

Process to follow when un-answered questions have a follow-on

This question was asked a couple of weeks ago, and has not been answered in that time. It has languised: https://codereview.stackexchange.com/questions/79233/edmonds-karp-algorithm-for-maximum-flow-in-...
14
votes
1answer
231 views

How should one deal with code asking “Is this correct?” when it is in fact correct?

I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what Code Review is about. However, when the code is ...
14
votes
2answers
191 views

What could be done to improve this question?

A few weeks ago I posted a question to this site. I thought I was getting low views so I even put up a bounty for this question. Now after the bounty is almost ended, I still have no comments or ...
14
votes
1answer
266 views

Does a single shell command constitute reviewable code?

A question asks to have a command-line invocation of FFmpeg reviewed. Is that reviewable code? There is currently no language tag, though shell unix could be added. Let's not discuss whether a ...
14
votes
1answer
105 views

Clarification as to why a question was closed as off-topic

An old question that was posted 3 years ago was put "on-hold" as off-topic. I have not been an active participant on Code Review (I received a notification thanks to a down-vote a couple of days ago),...
14
votes
2answers
120 views

Editing code without invalidating answers

This question picked up two answers before it was closed as stub-code. Now, the OP added the missing snippets without removing a single line, and the answers are likely still valid as they only ...
14
votes
1answer
242 views

A question was migrated to CR when the OP obviously didn't want a code review. Why?

So, I ran across this question. It would be a pretty good question except for one little detail: the OP doesn't want it reviewed. ... and am not looking for pure code improvements. Also, in the ...
13
votes
2answers
140 views

What should I do if someone continues to edit the question after being told to stop?

The particular rule is "What you can and cannot do after receiving answers." As I understand it, when we see someone edit code after receiving an answer, we should revert the edit and post a comment ...
13
votes
3answers
267 views

Harmless duplicate or are we being taken advantage of?

This question caught my eye because it had accumulated close votes as being a duplicate of another question, which is very rare on CR. The target was a question I reviewed last year by the same user. ...
13
votes
2answers
133 views

Is asking for review of 3rd party code ok?

Most code people are posting here seems to be code they have written themselves. In this question the OP asked basically for a review of three 3rd party scripts. I'm not sure that this question is a ...
13
votes
2answers
319 views

My code is too long. How do I trim it down when code posted here is expected to function?

The code I would like to have reviewed, found here, is more than 30,000 characters long. I don't feel like that in and of itself makes it off topic, but removing code from it so that it can be posted ...
13
votes
4answers
339 views

Is stack overflow on-topic for Code Review?

We routinely allow questions where the code works correctly for small inputs but fails to scale to larger inputs. The time-limit-exceeded and memory-optimization tags are often applied to such ...
13
votes
3answers
159 views

“Function to erase a character in a string” question was unfairly closed

Function to erase a character in a string This question is currently closed with the hypothetical/stub/pseudocode close reason. Questions must involve real code that you own or maintain. ...
12
votes
3answers
100 views

Editing in missing #includes

The off-topic list at meta includes: Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. So questions must ...
12
votes
6answers
175 views

Should deletion be an option for a low-quality accepted answer?

This question received a code-only low-quality answer that the OP accepted. I had downvoted that answer, because as the moderator note mentions: We're looking for long answers that provide some ...
12
votes
2answers
216 views

Should answers to clearly off-topic questions be encouraged or discouraged?

This question is clearly off-topic on Code Review. However, it did receive an answer which essentially points out the problem and makes some suggestions. The problem this potentially causes is that it ...
12
votes
4answers
147 views

Can working code be: off-topic -> not-working?

This question here: Shortest possible way of printing a specific board Summary: The code requirement is to print out a grid of text. The code does in fact print the grid The way it does that, is ...
12
votes
6answers
247 views

Does this open the door for chameleon questions?

Obj-C wrapper for OpenLDAP The user originally posted the top half of the code there. An answer was posted. After the answer had upvotes and a comment from the questioner (noting his appreciation ...
12
votes
2answers
110 views

Are requests for review of language design on topic?

This is the question that prompts this meta: Is my language easy/hard enough? How badly is it designed?. Paraphrased: I am thinking about making a language somewhat based on macros, and looking ...
12
votes
2answers
127 views

What more context can you provide about a one-liner macro?

The question about NOT macro: is this bad practice has been closed for not providing concrete context. But what else could OP have written to make it on-topic? OP also explained why he likes this ...
12
votes
2answers
301 views

OP says it works, the contest engine says it doesn't

What do we do when OP says his solution works, but the contest engine says it doesn't? Should we give it the benefit of the doubt, as "It works to the best of my knowledge.", or close it as broken ...
12
votes
1answer
282 views

“Enough reviewable code”

Passing Row Index of TableViewCell (custom) to another view controller The following claim is made in the asker's question: Pseudo Code: (pasted only necessary code) Let's start with the ...
12
votes
3answers
288 views

Are requests to diagnose a known security problem on-topic?

In PHP mail form is being abused, the question asks for help finding how an e-mail script got exploited. Finding security problems is normally within the scope of Code Review, and we routinely point ...
12
votes
1answer
135 views

Disagreement on closure of “Diffee-Hellmen in Javscript”

The question Diffee-Hellmen in Javscript was closed today for being unclear what the OP was asking for. I disagree with this, however. The very beginning of the post says this: I need to do the ...
11
votes
5answers
97 views

Please provide me feedback on my badly received questions

Two of my questions were down-voted as -3 and -4. I couldn't understand the problem with them. But if at-least 3 people are down-voting something is bad with them. Nobody commented or answered or ...
11
votes
3answers
440 views

Asking questions - including full code

In my first CR question, I was looking for feedback about my implementation of a graph data structure and an algorithm for depth first traversal, as I am studying these at the moment. Although I ...