All Questions

Filter by
Sorted by
Tagged with
11
votes
1answer
256 views

How long is long code

I usually hang out at the JavaScript tag, with a mix of jQuery, HTML and CSS where the code reviewed are usually snippets, which run around 100 lines and code that needs micro-optimizations. These are ...
11
votes
2answers
142 views

Should we help others reinvent the wheel?

I've seen a lot of people asking us to review their DBAL, or MVC framework, or templating system, etc. While I totally support these people's efforts as a good way to learn, I think answering such ...
14
votes
1answer
240 views

How should one deal with code asking “Is this correct?” when it is in fact correct?

I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what Code Review is about. However, when the code is ...
6
votes
2answers
112 views

Advice for reviewing edits

I just became eligible to approve pending edits and would like some advice. At the time of writing, this post has a pending edit: Finding similarities between images The edit changes the code ...
4
votes
1answer
131 views

Is example code on-topic?

From the FAQ: I'm confused! What questions are on-topic for this site? Simply ask yourself the following questions. To be on-topic the answer must be yes to all questions: ... 3. Is ...
4
votes
1answer
98 views

Move to SO or Programers

I can find it with a quick search; But: But there must already be a question here on meta about moving off-topic posts to SO or Programmers.stackexchange.com ore automatic. Like: Off-Topic move to ...
10
votes
1answer
127 views

Would it be on topic to request a review of a stackoverflow answer I gave?

A stackoverflow answer I gave prompted a downvote from the very beginning plus snide remarks about my skills and so forth. The downvote I can handle, the snide remarks are unfair in my opinion, but ...
3
votes
2answers
135 views

Character limit on Code Review

I understand why a character limit is imposed on question lengths on most Stack Exchange websites, but I take issue with the fact that there is a 30,000 character limit on the Code Review website. ...
7
votes
1answer
164 views

Are questions about how to further golf a program on-topic here?

I have a simple algorithm that I'm using for code golf, and I'm hoping to find ways to golf it further. The algorithm is somewhat golfed in Python already, and works flawlessly. I asked on meta....
3
votes
3answers
120 views

Review focus on code or on solution?

I was wondering what should be the focus of review. I thought the focus would have been more on: correctness (no syntax or logic error) readability (clarity, respect of coding standard ...) ...
6
votes
1answer
115 views

Is it appropriate to post 1k+ lines of code?

I recently asked a question on CR, and got an interesting suggestion that I'd like to look into. However, due to the class that the method is part of, and me still being green, I'm having a hard time ...
3
votes
1answer
140 views

How to get feedback on whole projects?

As far as I understand on Stack Overflow and Code Review, only smaller amounts of code are posted. It is expected to post the code there, and a whole project is way too much for one question. On a ...
0
votes
1answer
50 views

Sharing code over a lot of files [duplicate]

I'm working on a multithreaded server and have a few questions regarding it, especially the best way of going around decoupling the server module (that manages the connections) from the application ...
4
votes
1answer
103 views

Should there be some obligatory tags on questions?

By seeing how meta works and by the specificity of the CR.SE, I think that could be a good fit. On metas, questions have to be tag with at least one of bug, feature-request, discussion or support. ...
4
votes
2answers
106 views

New user's question closed without explanation

Here is the example of question that was closed without any explanation, without even trying to help @Leon (with only 1 point) to improve his question by posting some advice in the comments. I know ...
-5
votes
2answers
156 views

The opportunity to post an anonymised code. To have no problems at the place where you work

[This is in respect of this question on Code Review, which contained anonymised proprietary code, and which was closed as discussed here.] My feature-request to make is possible to post the ...
3
votes
2answers
116 views

Is it appropriate to edit excessive line breaks from code?

Some questions (2) have quite a few extra lines which are kind of unnecessary. I guess they could be attributed to "style" but in my opinion they make to more lines and less to readable code. For ...
5
votes
1answer
123 views

Please create a [pyramid] tag

I am new on Code Review, so I don't have the privilege to create a tag. Can one of you create it for me? Tag name: pyramid or pyramid-framework
1
vote
1answer
145 views

My question was closed without any explanation

My question was closed and I haven't found any explanation as to why it was closed. According to FAQ, we can ask questions about best practices. My question was about testing and my code did what it ...
3
votes
2answers
64 views

Review of code reviews?

I'm just wondering if there is any need to change the 'review' label here or (much worse) change the name of this site, since review in the title bar means something very different from review in the ...
5
votes
0answers
85 views

Redundant thank you notes in questions

Would it be wise to consider such posts as a subject for "auto" edit or add to the faq? It seems redundant to ask for review or little personal notes on the site which purpose is to review the code ...
0
votes
1answer
38 views

Would code review be a good place to ask for a review of a presentation?

I have a presentation on AMD and I need a few good reviews on it. Would this type of "review" be a good fit for the site?
7
votes
1answer
132 views

Is flag usage different on Code Review?

I do a lot of flagging on Stack Overflow to clean the site. When you review "first answers" or "late answers" you often fall on answer that are not answer and that post some code and finish by a ...
3
votes
2answers
131 views

Should I ask a separate question?

This examples applies for web mainly, but could apply for other stuff also. Let's say I develop a web plugin that has both JavaScript code and CSS. Should I post one question to review the ...
3
votes
1answer
49 views

maybe a bug? Unanswered Tags “html” missing

Sometimes if I just click on Unanswered then the Unanswered Tags "html" is missing in the right column, just sometimes (but mostly). if I scroll down the page I see unanswered html questions...
9
votes
1answer
84 views

Flagging closed questions for deletion

I've flagged two questions recently: https://codereview.stackexchange.com/questions/7491/c-how-to-take-file-ownership-to-the-current-user-using-win32-api https://codereview.stackexchange.com/...
15
votes
1answer
203 views

I want a peer review, but the code cannot be copy-pasted on a question

I've created an opensource library wrapping some JDBC functions. I'm not satisfied with JUnit tests, and I would like it to be peer reviewed. The code is not so much and it shouldn't be reviewed line ...
14
votes
3answers
309 views

Copyrighted code with copyright notice

This question has code based on copyrighted code, and the copyright is still in the provided code: ...
10
votes
1answer
138 views

Questions that ask for you to e-mail them to get the code

What is the appropriate way to handle a question that doesn't post the code to review, but posts an e-mail address that you can I assume e-mail and get the code? A (now-deleted) example is: ...
5
votes
1answer
144 views

Does Community Evaluation make sense for Code Review?

A “Community Evaluation” queue just appeared on the review page. It seems one of the main reasons for that queue is to compare each question with other sources on the internet for that same question: ...
11
votes
2answers
208 views

Is there a need for the OP to mention their expertise?

Is it relevant to include expertise with a code review question? Should this change the code review/answer? For example, this question mentions that the OP is new to the language. I suggested an edit ...
2
votes
1answer
63 views

Why are these two questions not closed as exact duplicates (and merged)?

This question was asked on Code Review: https://codereview.stackexchange.com/q/19022/3973 This question was migrated to Code Review (by me, from Stack Overflow), which is an exact duplicate (word-...
12
votes
2answers
137 views

Is it valid to reask (many) question on same script?

I have asked a question about a Python script a few months ago. Now I have developed that script furthermore fixing the issues described in the answer of that question. Now I have another questions ...
8
votes
2answers
231 views

Increase number of edits before post becomes community wiki

According to this answer on meta.stackoverflow.com: Posts enter community wiki mode when one of the following happens: [...] The post has been edited ten (10) times by the original owner. Typical ...
5
votes
1answer
61 views

Getting feedback on functionality and not code

I am writing a Template Engine, I don't really want my code reviewed, but I would like people to test it and give me feedback about what they think what I could add/remove/change. Would something like ...
7
votes
2answers
175 views

Will my rampant upvoting help?

I recently discovered Code Review. As a beginner programmer who wants to improve, I consider the site essential. I want it to move beyond the Beta phase. I read in this post that the key is ...
2
votes
1answer
94 views

Three “Keep open”s and it still closes

This is about review https://codereview.stackexchange.com/review/close/3161 and this related question I check the review history every now and again just for my own sanity. (Making sure I've made the ...
4
votes
1answer
72 views

Should different questions be made for style and functional questions?

Ongoing example: functional, style. As far as I know, focusing on any aspect of the code is fair game in a review. Do we want to allow such specialised-duplicates and request reviewers to answer in ...
4
votes
0answers
81 views

How to choose a correct answer in Code Review? [duplicate]

Possible Duplicate: Which answer to accept? Just discovered Code Review and I think it's great. I posted my first question and got two answers full of great advice. What advice do you have ...
2
votes
1answer
127 views

Was my answer deleted? [duplicate]

How can I tell if my answer was deleted? There's no evidence of the answer on my profile page, except for the fact that I have the Teacher badge. I haven't recieved ...
14
votes
2answers
311 views

Code remove after question answered

If the user that posted the question deletes the code to which the question belongs to, after accepting an answer, should one restore the code or simply notify the user or moderator?
4
votes
1answer
39 views

Tag request: [.htaccess] (mod_rewrite, url-rewriting, …)

A .htaccess tag would be suitable for: Canonicalize URLs for static website Suggestions on how to improve this .htaccess file for page load speed Maybe finer grained tags could be useful, like ...
16
votes
1answer
214 views

Is there a better format for posting questions for code review

At times I have seen quite a bit of code posted for review. This might be because there are a number of classes that interact so the person is giving as much information as possible, or they might be ...
7
votes
1answer
185 views

Confused between posting on Code Review, Software Engineering, or Stack Overflow

I have this questions that fits the FAQ of Code Review, Software Engineering, and Stack Overflow. It contains a couple code snippets for one platform and I'd like to know the recommended practice ...
3
votes
1answer
86 views

Two approvals for suggested edits

It seems to me that currently a suggested edit needs two approval (or reject) reviews (as suggested edits on Stack Overflow) while a week ago they required only one approval/reject. Why? What is ...
2
votes
1answer
76 views

Should I have posted a new answer (suggested edit rejected)?

It's about this suggested edit I made, and the suggestion to create a new answer to the question. In this case, the change I made from IList<> to ...
21
votes
0answers
320 views

Do not prematurely accept answers

With the voting debate going on, I'd like to make a related point: Please do not prematurely accept answers. As much as I love getting the tick mark, it is a signal that tells the community that a ...
33
votes
2answers
487 views

Vote Early, Vote Often

Lack of voting has already been identified as an issue that prevents the site from graduating. I'm shamelessly stealing this post from Meta Biblical Hermeneutics, hoping it will inspire all of us to ...
13
votes
2answers
224 views

Can graphical notation count as code or should questions with exclusively graphical notation be considered off topic?

As a community, are we willing to accept graphical notation as a form of code that is subject to code review? I recently answered a question that asked for review of a database model as presented in ...
14
votes
2answers
236 views

What if we have an entire (small) application we want reviewed?

I asked about this on Stack Overflow, and was referred here (to Code Review), though I still think it may be out of scope for CR. https://stackoverflow.com/questions/12749863/where-can-a-n00b-...

15 30 50 per page
1
31 32
33
34 35
37