Hot answers tagged

27

I believe it is a valid code review .... sometimes perhaps even the best code review is: Why are you doing all this hard work, just use that ... In specific cases where the user is intentionally doing the work, they should tag their question with reinventing-the-wheel. On code review, I would typically ask in a comment something like: "Did you know there's ...


20

Is it on-topic to review a challenge's requirements? To the extent that the requirements force bad code, Yes. The core of every question at Code Review is "How can I make this code better?" It is not "How can I solve this challenge?" If the asker has not gotten at least that far already, their question is off-topic here. Therefore every question at Code ...


14

I personally have a bit of a history with writing reviews for languages I don't know squat about. Some of these reviews got comments like yours, where people pointed out syntax errors to me (and referred me to styling guidelines). Sometimes I even get a comment that makes parts of my review outright wrong or obsolete (e.g. here). That is not the end of the ...


13

The problem starts with the question, which is barely on topic and would be a better fit on Stack Overflow. That said, a comparison between your original answer and Reinderien's seems to illustrate the difference between an alternative solution and an alternative solution with an insightful observation: you said The best solution is ... whereas he said ...


12

Our How do I write a good answer? guidelines state that Every answer must make at least one insightful observation about the code in the question. but also that We don't expect every answer to be perfect, but answers with correct spelling, punctuation, and grammar are easier to read and tend to get upvoted more frequently. Remember, you can always go ...


7

The post didn't in itself strike me as a commentary on first read, and seemed to somewhat relate to the OP - it even had a positive score! "the answer" confused me I guess; the flag would likely have been handled differently if it had said "this is a comment that belongs under https://codereview.stackexchange.com/a/187501"... the positive score still would ...


4

I don't see a problem with challenging the questionable requirements of a programming challenge, however, I think the answer should have given priority to the OP's code rather than the silly requirements. I would have organized the answer somewhat differently with the silly requirements after the observations about the OP's code.


2

I can see myself misunderstanding your flag. The segment "on the answer" is fairly ambiguous. Normally I would suggest commenting and then flagging. The comment should explain the steps for the user to take. This comes in handy when flagging as then the moderator can also see what your desired path is, reducing ambiguity. I personally would flag a couple ...


2

I really want to opine that it's fine. It can be educationally useful, especially for students who might assume these code practice sites are modelling good practice. Nevertheless, it probably is not a strictly valid target because of the authorship requirement. The challenge defines an interface. Interfaces are code. If you're hobbled by a shoddy ...


Only top voted, non community-wiki answers of a minimum length are eligible