44 votes

What would Clippy say?

No code in the question Very easy to test for. If there is not a single formatted full line of code in a question: Code Review questions must include the code to be reviewed in the body of the ...
  • 8,800
43 votes

Must the code be "clean"?

Make the code as clean as you can before submitting it for review. The more work you put into your code, the more you're likely to get out of review. That's because reviewers (especially the ...
  • 49.4k
37 votes

Checklist for how to write a good Code Review question

Simon's Guide for posting a good question There are a lot of questions that appear on Code Review, and all questions are fighting for reviewer attention. This is a non-exhaustive list of items that I ...
33 votes
Accepted

Should I leave in documentation in code for review?

Is it a best practice to include things like function documentation and inline comments when posting code for review? If you normally document your code, then include the documentation when posting ...
32 votes
Accepted

Must the code be "clean"?

No it doesn't have to be clean. It can get reviewed, but people will point those problems out. If you know they are bad you should probably clean them, that way we won't badger on about them, and ...
  • 41.8k
28 votes

What would Clippy say?

Machine Learning There's way too many cases to consider here, we should apply Machine Learning to this to make a machine learn what makes a question likely to be a bad question. I have recently ...
27 votes

Found a serious bug in my question after posting it

If the question has been answered, you must not edit it in a way that would invalidate the answers; that is not permitted on Code Review. If the question is still unanswered, and the bug is easily ...
  • 65.4k
26 votes
Accepted

I've observed many toy/homework questions

Code Review is not like other Stack Exchange sites. Other sites create a 'corpus' of reference questions and answers to problems experienced by people in those specific subject areas. This difference ...
  • 97k
25 votes
Accepted

Can I use CR as an environment to foster an open source project?

Answering your direct questions first: .... or posting links to GitHub instead of code chunks, etc.? The keyword you use here is 'instead', and the answer is 'no'. You cannot post questions here ...
  • 97k
25 votes

What would Clippy say?

Title contains "this * code" or "do* this" Every single question with "this code" or "this [language] code" in the title has been retitled, closed, and/or downvoted; some have comments asking for ...
25 votes
Accepted

Should I include my testing code?

Yes, if you have automated tests, please include them. Some folks will take the posted code and paste it into a dev environment/IDE and make changes there (so they can ensure that their answer has ...
24 votes

Is code ever clean enough? - Can there be too many follow-up questions?

The problem is not the number of follow-up questions. The problem is the rate of posting them. If you post a follow-up once a week, probably nobody will even notice. As long as it's well done, for ...
  • 110k
23 votes
Accepted

Please provide me feedback on my badly received questions

I wasn't one of the downvoters, so I can only speculate. However, it is site policy to include textual summaries of programming challenges. This policy was actually instated when Project Euler went ...
  • 30.8k
22 votes

What would Clippy say?

Title that looks like a question The following patterns in a question title predict a problematic post: How …? Can …? Should …? Would …? …? (i.e., a title that ends with a question mark) The tip ...
22 votes

Is asking for a review of boiler plate for a minimal repro okay?

The line between real and hypothetical code is sometimes blurry, but I would consider this code sample to be on the wrong side of the line for Code Review. Code that contains ...
22 votes

Code Review Clippy

Yay! Thanks! Just one note, if I would see this as an entirely new user: Titles that contain a specific question are generally inappropriate for Code Review. I would be very confused. If I would ...
22 votes

Hide the "describe what you've tried" bullet (new askers' modal)

Yes. This statement implies that if you've tried and failed, then you can post your non-working attempt on CR. We should remove that instruction.
  • 65.4k
20 votes

Is it too easy to post your code for review?

To answer the surface question, "Is it too easy to post your code for review?", the answer is an emphatic No. It certainly is not too easy to post code for review. I don't think it could be too easy. ...
  • 30.8k
20 votes
Accepted

Small portion of reviewable code isn't mine, but credited

Not a problem If it would be a problem, you wouldn't be allowed to use someone else's libraries either. That rule is there to prevent people from dumping code that they don't understand and/or 80% ...
  • 13k
19 votes

Does preventing exact duplicate titles makes sense here?

I personally quite like that "warning", it inspires you to create titles that are more imaginative than "FizzBuzz from a file" - how about "IFSFB - Input File Specified FizzBuzz" Do something ...
  • 97k
19 votes
Accepted

Policy regarding "flooding" Code Review with questions

To be completely clear: homework[1] [2] and coding challenges are on-topic. Issues with tags should be edited, it's rare to get questions with perfect tags - I get them wrong all the time too. This ...
  • 41.8k
18 votes

What would Clippy say?

Title or body contains the word "wrong" or "incorrect" These words almost always indicate that the code is broken. The tip could say: Please note that questions containing code that produces ...
18 votes

What would Clippy say?

Body contains only code, or only a few, short, non-code parts This could indicate that the user is not explaining what their code doing and it, more or less, providing a code dump. The message could ...
  • 13.2k
18 votes

Should I leave in documentation in code for review?

Going purely from subjective impressions and without actually checking them, quite a lot of my answers specifically point out parts of the code which I think are underdocumented. There are at least ...
18 votes
Accepted

Clarifying Code Review Scope

It really depends on your intention writing your question! Are you looking to make your code work on other browsers? If so, you're looking for someone to write a new feature/fix bugs for you, in this ...
  • 12.3k
17 votes
Accepted

Can I ask the same question with a different language?

I don't think there would be a problem with this. In fact, I'm sure several people have posted fizzbuzz in 2 or more languages. However... you'll realize that lots of comments you can receive are ...
  • 25.2k
17 votes
Accepted

Posting the same program in three different languages in three different sections

Posting three separate questions and having them link to each other is a perfectly alright thing to do. The removing of your links was either an error, a case of two edits being done at the same time,...
17 votes
Accepted

Is this question popularity normal?

The algorithm that makes a question hit the Hot Network Questions (HNQ) list isn't public AFAIK, but it definitely involves views, votes, answers, and a time factor is documented here. Your question ...
16 votes
Accepted

Which licenses are compatible with Code Review?

We require that the asker posts code that they have written themselves. In that case it can be assumed that the asker owns the copyright for that code and can license that code to Code Review under CC-...
  • 12.4k
16 votes
Accepted

Will a question be downvoted for poor code?

Are you aware that you keep making the same mistakes over and over? From a comment My guess is that this is the source of the down votes. It's a user who keeps asking questions, but isn't learning ...
  • 30.8k

Only top scored, non community-wiki answers of a minimum length are eligible