Skip to main content
17 votes
Accepted

How should we revisit our standard close reasons?

As I see it, some of the problems with the existing close reasons are: Ambiguity of "broken code". Some users seem to think that anything that compiles is not broken. Accusations of "not real code". ...
200_success's user avatar
17 votes
Accepted

"Who Wrote This?" and What Do We Actually Consider Authorship?

I think the close vote is inappropriate. The close reason says "author or maintainer". In this case I think it makes sense to assume that the poster is the maintainer of the cloned code, especially ...
janos's user avatar
  • 111k
15 votes
Accepted

Clarification on close reason

Yea that close-reason is a bit difficult. It's two, maybe three different reasons packed into one. "Authorship of code: Since Code Review is a community where programmers improve their skills ...
Vogel612's user avatar
  • 25.2k
15 votes
Accepted

Should we close a question of a non existing user?

No, we should not close it just because the user has not joined Code Review. If the question is on-topic, it should be treated just like any other question. Note that questions, answers, reviews are ...
rolfl's user avatar
  • 97.4k
15 votes
Accepted

"unclear what you're asking" vs "Lacks concrete context"

Note: "unclear what you're asking" has been changed. This answer still holds with the new version. Closed. This question needs details or clarity. It is not currently accepting answers. ...
Peilonrayz's user avatar
  • 43.4k
14 votes

Why was this question closed as off-topic after a bug was discovered by the answers?

I'm one of the users who voted to close. I saw that at least two bugs were discovered, and that made me think the code is severely buggy and therefore troublesome to review. But I saw it wrong. After ...
janos's user avatar
  • 111k
11 votes

What is "best to the author's knowledge"?

Onto the core of your question: It seems to be a manifestation of the larger problem, namely the vagueness of to the best of the author's knowledge clause. When an author admits the problem we are ...
Peilonrayz's user avatar
  • 43.4k
11 votes

The context of "Lacks concrete context": let's fix it

IMO the biggest and simplest problem is LCC being used as UCWYA. But why is this happening? I don't know, but I can guess. The reason's name "Lacks Concrete Context" makes it sound like any context. ...
Peilonrayz's user avatar
  • 43.4k
11 votes

Is a memory leak and a lack of concurrent safety enough to make code unreviewable?

Indeed neither memory issues or concurrency should be a reason for closing a questions. Seems like someone is a bit trigger-happy on the close vote. (And possibly down-vote trigger-happy as well). ...
Simon Forsberg's user avatar
10 votes

Confusing phrasing of the "off-topic" close reason

Unfortunately I agree with the close reasons. To the best of your knowledge, your code fails the google test cases, therefore it does not work. Just because you don't know what the problem is, does ...
rolfl's user avatar
  • 97.4k
10 votes

"unclear what you're asking" vs "Lacks concrete context"

"Unclear what you're asking" is, paradoxically, unclear for Code Review, because every question is asking the same thing: "How can I improve this code?". I interpret it as "...
Toby Speight's user avatar
  • 76.2k
10 votes

How do we train our self-moderators?

Use Comments and Chat You could leave a comment challenging the VTC. This way, both OP and the community are aware of the pending VTC and your concerns about it. OP may react to reflect on their ...
dfhwze's user avatar
  • 13.9k
10 votes

Forcing detail when none is needed

You have just asked a question on Meta that: has a title that is clear, specific, and concise has an introduction that provides great context, and examples of what your expectations are based on it ...
rolfl's user avatar
  • 97.4k
9 votes
Accepted

Wouldn't it be more useful to notify OPs automatically about close votes, instead of having (stock) comments all the time?

Wouldn't it be more efficient to notify the OP (even below 250 rep) directly about close votes, Yes it would. Feel free to make a feature-request on the site-wide meta. instead of that constantly ...
Simon Forsberg's user avatar
9 votes

Wouldn't it be better to edit this question instead of closing it?

No, this question should remain closed as "Not working as intended": "My code does not work some of the cases on hackerrank for some reason but I can't figure out why. It is not caused by timeout ...
rolfl's user avatar
  • 97.4k
8 votes

Confusing phrasing of the "off-topic" close reason

The phrasing in the close reason is a long-fought-over compromise. The Scylla and Charybdis that we are trying to avoid are: We don't want to turn into a debugging service where people post broken ...
Gareth Rees's user avatar
  • 49.6k
8 votes
Accepted

Review a piece of code bought from someone else

All we know is that the OP bought a script: we know nothing of the license it came with (if any), and we don't know whether the terms of that license allow the OP to modify it, let alone putting the ...
Mathieu Guindon's user avatar
7 votes
Accepted

What more context can you provide about a one-liner macro?

I agree, there have always been discussions about 1-liner questions, and I feel the specific question here has been closed because the closers saw the "use case" as being example code, but it's just a ...
rolfl's user avatar
  • 97.4k
6 votes

Wouldn't it be more useful to notify OPs automatically about close votes, instead of having (stock) comments all the time?

Once a question is closed it does automatically add a notice that the OP can see as to the reason for closure and how to possibly remedy it, for example: Some of us who regularly help with moderation ...
Phrancis's user avatar
  • 20.4k
6 votes

Why was this question closed as off-topic after a bug was discovered by the answers?

Since I wasn't involved in this question at all, I'll just try to make sense of the situation based on the norms of this site. The first answerer, @Dair, wasn't originally aware that the code was ...
Jamal's user avatar
  • 34.9k
6 votes

The context of "Lacks concrete context": let's fix it

I have never liked this as a close reason. I believe it does damage to the site. Community consensus at the time was significant, and I've come to accept it over time as a potentially necessary evil. ...
rolfl's user avatar
  • 97.4k
5 votes

What more context can you provide about a one-liner macro?

I'm one of those who close-voted the initial version of the question. My personal reason was that the macro was embedded in example code around a hypothetical scenario and example. What's under review?...
Zeta's user avatar
  • 19.3k
5 votes

Confusing phrasing of the "off-topic" close reason

Phrasing things is difficult. I want to make it clearer what is currently on-topic and off-topic. I have a bug in my code, please help me fix it. (Off-topic) Is there any bug in my code? (On-topic) ...
Simon Forsberg's user avatar
5 votes
Accepted

When is a question too broad?

To addresses your first two paragraphs, too broad is for when a single Code Review question asks what should be multiple Code Review questions. The broken code close reason isn't a single close ...
Peilonrayz's user avatar
  • 43.4k
5 votes

Insecure links in custom close reasons should be HTTPS

JNat, GraceNote and myself went through all the sites and edited these reasons to have valid meta links. If you find one that we missed... Let me know & I'll fix that too.
Shog9's user avatar
  • 101
5 votes

How should we revisit our standard close reasons?

I mostly agree with 200_success' answer. However there is one close reason I think that should be moved - the no code reason. This is mostly for three reasons: Not including the code to be reviewed ...
Peilonrayz's user avatar
  • 43.4k
5 votes

What is "best to the author's knowledge"?

I look at working correctly, to the best of the author's knowledge from the other direction. If the poster knows that the code is broken, or should know that the code is broken, it is off topic. By ...
1201ProgramAlarm's user avatar
5 votes

Can we have a guide to wonderland? (includes v1)

I appreciate that you've spent a lot of time working on this, but I have to say that frankly in my opinion a solid block of links is not very useful. I see myself as a reasonably engaged member of ...
Peter Taylor's user avatar
  • 24.1k
5 votes

Let's not close fixable posts without explanation

I made a query questions-in-need-of-a-friendly-helpful-comment to try to find questions where moderating comments are invited. Feel free to tweek this query at own will. Note that the database this ...
dfhwze's user avatar
  • 13.9k
4 votes

How should we revisit our standard close reasons?

Just for context and additional information. The current close-reasons have been used as in the following picture for the last 30 days: Almost 300 questions have been closed, which is not quite 30% ...
Vogel612's user avatar
  • 25.2k

Only top scored, non community-wiki answers of a minimum length are eligible