19
votes
Accepted
Tackling overwhelmingly long questions
There is no requirement for a Code Review answer to critique every part of the code exhaustively. If a question contains a lot of code, some possible responses might be:
Ask for clarification in a ...
- 144k
19
votes
Accepted
Can I ask for review for something specific without posting too much context?
Strictly speaking, Code Review requires you to post real code from a project that you are working on.
In practical terms, though, any plausible realistic code is acceptable too. If your real project ...
- 144k
13
votes
Accepted
Should I be asking shorter questions?
Your code is average, maybe a bit on the large size, nothing that I'd not answer.
Your problem is I see a wall with code, text, some lists, more text, more code, more text, more code and then 'how ...
PeilonrayzMod
- 42.7k
12
votes
One Question Per Question
The size of the post should not be a major consideration. We've had questions about everything from one-liners up to the 64 kB limit.
Rather, the issue is whether there is unity in the question — a ...
- 144k
12
votes
Accepted
Is it appropriate to ask for review on an entire GitHub repo?
No, it wouldn't be ok. Your question would get closed quite quickly, with a dedicated close reason, stating:
Questions must include the code to be reviewed. Links to code hosted on third-party ...
- 75k
9
votes
Is it okay to post questions that don't contain a full program/library?
You are always welcome to post just part of your code for review. It is always best though, to provide enough context to make sure the code you post is sensible.
The code you post does not need to ...
- 97.3k
8
votes
Accepted
How should I structure my post if my code is over 400 lines?
First of all, you're allowed to post the whole thing as-is, all in the same question. 13,000 characters is well within the limit of what a post may contain (65,536 characters as a hard limit), leaving ...
MastMod
- 13.1k
8
votes
Project translation from Java to C#
If your code is not working as intended, you should not ask about how to fix it on Code Review. Such a question would be considered off-topic.
Assuming that your code does work as intended, you still ...
- 144k
7
votes
One Question Per Question
We had questions here which had only a small amount of code in it but got rather long answers regardless if it stated no question, or only one question, like for instance "How can this be improved ...
- 50.3k
7
votes
Accepted
May I post this Huffman tree program with several files?
As a general rule, we prefer to see: Your full code, unedited, exactly as it appears in your IDE. Code Review has an extended 65,535 character limit. Unless you're getting close to exceeding that, ...
- 8,810
7
votes
Should I be asking shorter questions?
I don't think that there is anything wrong with your question length. If anything, I would guess that the fact that your questions are written in Clojure is a bigger factor in explaining why they ...
- 144k
7
votes
Tackling overwhelmingly long questions
What @200_success said.
For the particular post in question, I just started at the top, started critiquing the Naming and, well, never even got past the first Sub ...
- 8,810
7
votes
Accepted
What was wrong with my question?
Like @1201ProgramAlarm mentioned in the comment
The problem is that the code to be reviewed must be embeded directly
in the question. As it stands, there is no code in the question and
nothing to ...
- 50.3k
7
votes
Accepted
Where can I find an expert opinion on a large codebase?
It's hard to answer this kind of question without knowing very much about your specific code.
But basically, a single question can contain 65,536 characters. This should of course also include a ...
- 59.1k
6
votes
Is it appropriate to ask for review on an entire GitHub repo?
To add to Mat'sMug's answer, it is best to focus on individual pieces of code, chances are that reviews of that code will be applicable to the rest of your project.
I would suggest that you find ...
- 20.4k
6
votes
Accepted
Does Code Review require OPs to provide an MRE?
Code Review is not Stack Overflow.
If you look under the "Asking your question" section of the How do I ask a good question help topic, you'll see that it says that you can leave supporting, ...
- 7,666
6
votes
Accepted
Posting a whole project, ready for public review
If you read that entire section, you see:
If you are looking for feedback on a specific working piece of code from your project in the following areas…
Best practices and design pattern usage
...
- 20.1k
6
votes
Should I be asking shorter questions?
There are a couple of subjective reasons which may or may not impact the lack of answers.
You seem to be quite focussed on code-length. Some of the reviewers, including myself, are not interested in ...
MastMod
- 13.1k
5
votes
Tackling overwhelmingly long questions
You can always ask a user in a comment to improve the question. I often suggest question askers to read Simon's guide for asking a good question, which contain many tips for making a question easier ...
- 59.1k
4
votes
Can I ask for a review of an entire library?
Lets break down your question into separate and more digestible parts.
Are reviews of libraries allowed? yes
Are large questions allowed? ("an entire library", "contains several files&...
PeilonrayzMod
- 42.7k
4
votes
Accepted
Seeking project wide input rather than modification of individual pieces of code
While I will answer your raised concerns one-by-one and it's perfectly possible to get your project reviewed, I'm not convinced Code Review is your best bet.
Does Code Review allow for posting (or ...
MastMod
- 13.1k
4
votes
One Question Per Question
I voted to close primarily because I think there's no advantage to putting them all into one post. It creates mild confusion by putting them all together. The only benefit is reducing it to one post, ...
- 13k
4
votes
Accepted
What is the recommended length of the code for review?
The community likes lots of code, it allows us to do a good review. You might notice some delay in getting an answer because a lot of code takes time to review the code. If you look at my questions, ...
- 23.5k
3
votes
May I post this Huffman tree program with several files?
My full code is split across 9 different files. 8 of these are little classes that make the rest of my code easier to work with, and they are each 30-70 lines long. If I give a short explanation of ...
- 59.1k
3
votes
Project translation from Java to C#
We have a higher characterlimit here on CR, but usually lots of code will scary off answerers so I would suggest you strip your question down to one class or some methods out of this class (if the ...
- 50.3k
2
votes
Should I be asking shorter questions?
It seems like you're looking for a review... a Code Question Review!
I looked over your unanswered questions, and they seem to be very long (as you have noted). Actually, the code is fine, but you ...
- 646
2
votes
One Question Per Question
Arguments could reasonably be made for either side of this coin, so I'll take OP's side here and see where that takes us.
Sure, it could be 5 independent posts. But this isn't the first to combine ...
- 75k
2
votes
Accepted
Is it possible to get feedback on the structure of an application (with code posted)?
In (now-deleted) comments, you confirmed that your entire code exceeds the post limit. In a smaller program, the way to leave open the possibility of feedback on the arrangement of the code (modules, ...
- 59k
1
vote
Can I ask for a review of an entire library?
I have posted 25 questions on Code Review, 24 have been answered. 23 of the questions are non trivial (multi file questions). You will get an answer in time, it may not be as fast as you want. As a ...
- 23.5k
Only top scored, non community-wiki answers of a minimum length are eligible