26

This is intended as a ready copy & paste version for including in the Auto-Comments script. The Auto Comments script also has support for a "remote" feature where you can use this URL: http://www.zomis.net/codereview/auto-comments ###[Q] Broken Code I'm afraid this question does not match what this site is about. Code Review is about improving existing,...


19

Question contains non-working code. Welcome to Code Review! I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. Code Review is not the site to ask for help in fixing or changing *what* your code does. Once the code does what you want, we would love to help you do the same thing in a ...


19

Sure you can remove them. If you feel other comments are left in an awkward state, then feel free to flag them as obsolete. That way a moderator will review them and remove them if deemed appropriate. There is also a SE meta post about flagging whole comment conversations, which you may find relevant.


18

There are multiple things you can do, most of which unfortunately require reputation. Accept an answer If you think one answer is better than the rest, then you can accept the answer by selecting the hollowed out tick under the voting buttons. This gives the answer 15 reputation. Vote Up At 15 reputation you possess the ability to up-vote questions and ...


16

Yes I am a comment lover. Comments helps a lot. Especially when it's not crystal clear for everybody that the code is not working as intended. Sometimes it's even good if two or more users independently considers the code not working as intended and adds a comment about that. (Just to avoid five close votes because "one person says so") The benefits of a ...


15

I was not a part of this, so this answer is based only on what the OP has shown us. I am afraid that I may catch a lot of flak for this post, but here is how I see things. Part 1: Embedding Code Let's go from the beginning: @RavenHursT broke our rules for not posting the code here. @rolfl posted a polite response clarifying our rules. @RavenHursT posted ...


15

OP has edited their question to include feedback received in answers, effectively invalidating existing answers. Adapted from the famous meta post, "For an iterative review, is it okay to edit my own question to include revised code?": I have rolled back the last edit. Please see *[What to do when someone answers](/help/someone-answers)*. The answer-...


13

Question contains Hypothetical Code / Pseudocode I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. The example code that you have posted is not reviewable in this form because it leaves us guessing at your intentions. Unlike Stack Overflow, Code Review needs to look at concrete code in ...


13

Remember, Comments are ephemeral ... General Obsolete comments The most common 'obsolete' comments on CodeReview are comments like: Hi, and welcome to CodeReview. Your question is off-topic because your code is only available through a link. Please update your question with the actual code. If you see comments like that, which are still around after ...


12

Yes Comments are not considered to be 'permanent'. These comments, in particular, were flagged as being 'obsolete', and 'chatty': I agreed, there was no reason to keep them after your answer had been updated: I love suggestion number 2 - I'm amazed I didn't think of it myself. Suggestion 1 is good too. Could you explain suggestion 3 more? It sounds ...


11

There are two types of contest-questions posted to Code Review. contests/interviews which have been completed, or are not competitive contests which are active, and "current". Code Review is a good place to post any code related to 'expired' or non-competitive contests. When we are made aware of it, code for active/current contests are removed. This has ...


10

An answer contains a completely different solution with no explanation or justification. You have presented an alternative solution, but haven't reviewed the code. Please explain your reasoning (how your solution works and why it is better than the original) so that the author and other readers can learn from your thought process. In addition, please ...


10

Title is too generic The desire to improve code is implied for all questions on this site. Question titles should reflect the purpose of the code, not how you wish to have it reworked. See [ask] for examples. Another wording: The current question title, which states your concerns about the code, is too general to be useful here. The site standard is ...


10

I have something to add concerning the "not working" code: we hardly know whether our code is 100% safe or not, and often assume ("know") that some corners cases remain and even if we wrote the best possible code we could, there would still be some obscure errors which would generally not trigger but which could trigger someday. We often feel that there are ...


10

Comments aren't on or off topic. Comments are just that: comments. I read OP's comment as asking for further clarifications about the scalability of a proposed solution, which is exactly what comments are for. I deleted that noisy comment thread.


10

There's a list of them on Meta.SE. They are also known as 'magic-links'. Some examples of these are [meta], [main] and [edit]. However, the above link doesn't contain them all. In this meta.se question, it shows that you can also use [faq#dontask], rather than [help/dont-ask], which comes up as faq, rather than help center. In case you're wondering [...


9

It's not really rude as such — you don't speak down to or insult the person — but I think it could be improved. When you're trying to correct a behavior, it's important to explain: What the person did that's wrong; Why the behavior is wrong; What they can do to correct the behavior. Your comment only touches on the third point, so without ...


9

I like all of these in one single place! I put together and am actively maintaining a list of easily usable copy-paste responses on Github, which everyone is free to use, copy and clone as they please. They are inspired by the responses found here. I made that because I find it easier to keep it organized and up-to-date this way, rather than trying to ...


9

In a way, I don't think it's possible to specify a "site-policy" about this. It is up to each user to post comments as they wish, and up to each user to improve their comments as they wish. This one comes directly from a collection of Frequently Posted Comments for users of the Auto-Comments script, as such it is several users that already uses the comment. ...


9

As the moderator involved, I'm obligated to respond. This specific question I have to admit, it was a complex decision process for me, with many factors to consider. Code Review is a place where programmers post their code for feedback… … subject to a condition that the code must work as intended, to the best of the author's knowledge. If the question ...


8

I'm writing this answer from a working mindset at my job, I appreciate this isnt your job and you probably do not need to remain 100% professional for your own livelihood. I don't think you can ever stop a flamer from flaming, this being said he clearly had a problem with the rules of the site which wasn't helped by the way he was responded to. I think you ...


8

Generally speaking, when a name is not auto-completed, it's the sure sign that the user will be notified. No need to spell out his name. You don't need to remember "quirks", or how Stack Exchange works. Just understand that if a name is not auto-completed, that's because it doesn't need to be. This is especially useful when you want to address two users at ...


8

No - such comments are too chatty. You should vote accordingly. And if you have enough reputation, you could consider starting and awarding a bounty. The Help Center page What should I do when someone answers my question? states the following under the heading What should I not do?: Please refrain from posting a comment that merely says "thank you." ...


7

Code Challenge Missing Description Links can rot. [Please include a description of the challenge here in your question.](//codereview.meta.stackexchange.com/q/1993)


7

Question contains little to no description about what the code does. This question is incomplete. To help reviewers give you better answers, please add sufficient context to your question. The more you tell us about what your code does and what the purpose of doing that is, the easier it will be for reviewers to help you. [Questions should include a ...


7

My take on what happened: Dialog between OP and rolfl Other users (starting with Mat's Mug) weigh in to defend and back up rolfl My take on how to prevent it happening: If you post, do it to inform ("our rules are X", "you can improve your post by adding Y"), but not to criticise ("don't disrepect the community", "don't argue with the moderator"); if you ...


7

In general, comments are ephemeral.... they are not designed to have long-lasting content. Comments are to seek clarification on posts, and point out short term issues. Once the issues are addressed, the comments should be removed. In the case of this specific question, things became a real mess.... in part, because the question started off "broken", and ...


6

It Depends My favorite answer to these questions. ;) No matter the scenario, I don't recommend editing the question. The sort of statement you're talking about is part of the definition of "as intended" in the phrase "works as intended". By editing the statement, you're editing the users definition of the intended functionality of the code. So, what ...


6

I don't think your comment is rude. That being said if you wanted to soften it a bit and be more explicit about the "call to action" for the user, you could word it along these lines: Welcome to Code Review! Your question title in its current form is ambiguous. Because we want to better understand your question so we can review it, please consider ...


6

Unfortunately I wasn't a part of this, I wish I could have been there to help. I'll make a small note here though: tone is everything. Whenever you are writing something to be read, the it is up to the reader to decide how you will "sound" in their head. At first I think we handled ourselves pretty well as a community. We (for the most part) were pretty ...


Only top voted, non community-wiki answers of a minimum length are eligible