194

What distinguishes Code Review from Stack Overflow? Different communities have different rules to address different needs. A quick summary: Code Review Stack Overflow Open-ended questions Questions with a specific goal Answers can suggest any improvement Must answer the question Code must already work as intended (No such requirement) Prefers code in ...


148

You have several options for follow-ups: Accepting an answer If one of the answers gives you good advice with clear directions for improving your code, just accept the best answer and upvote any other answers you feel were helpful. The checkmark that you confer is the best way to show appreciation on this site, as it gives 15 reputation points and raises ...


79

Code Review is not graduated (Note: WIP) This site has become the pity-site - the site that is graduated, but is not graduated, it's big, but not big enough, it's a beta site, but it's too busy to fit with the beta logic. The biggest issue for Code Review is uncertainty. We can't attract more answerers because the people "in the know" don't look at ...


73

Perhaps something like this could help situate CR in StackLand:


69

Meme: Zombies Originator: Mathieu Guindon (aka retailcoder, lol.upvote, ... and/or Mat's Mug) Cultural Height: During The Mission Background: In a (successful) attempt to motivate the community in reducing the number of unanswered questions, a Call of Duty was made in which every unanswered question (no upvoted answers) is to be regarded as a Zombie. ...


63

Meme: Jamalized Originator: Jamal ♦ (actually, apparently me) Cultural Height: All over CR (see this chat transcript search) Background: Jamal being a frantic editor. And he's fast. So fast, we're all waiting for the day he will edit a bad question title before it's even posted. You never know, maybe mods will have the power to edit post drafts one day. ...


58

No. We require the code to be contained within the question, for the following reasons: To avoid dependency on third-party hosting services. These links tend to go away after a while. To prevent review requests of huge projects. To make it easier to see the code and so it can interest more reviewers and get more reviews. To avoid confusion when the OP ...


57

When you ask your question Your question is (should be) presented in 4 basic parts. The Title, Tags, Text, and Code. I suggest that you build your question up in that order too. Title Use a title that is catchy, and describes the problem your code solves. A question with the title "New programmer looking for advice" is both 'obvious' and ...


53

I personally would like to see more reviewers drawn to this site. We almost always have a larger number of questions coming in than reviews, causing our unanswered count to increase over time. Fortunately, we don't have to have a question answered quickly (reviews, especially long ones, do take time). However, a short review is always encouraged, and ...


52

How to NOT write a zombie. A zombie is a question that remains unanswered. As a question asker, your goal is to avoid writing one. Beyond meeting the on-topic requirements, I think "good CR questions" can be broken down into several question types. This answer is longer than I would have liked, but there are pictures. The Minimalist These ...


51

Too much broken code According to Question Close Stats (2K+ / Moderator Tools link), in the last 30 days we have closed: 225 questions with broken code - 58.4% of closed questions. 14 were reopened. 64 questions with hypothetical/pseudo-code - 16.6% of closed questions, 10 were reopened. 32 unclear questions (8.3%) - 11 were reopened. 29 questions that didn'...


47

Code is not malicious (guns don't kill). It is the way that code is used that makes things a problem. I am certain that every piece of 'malicious' code has an 'angelic' corollary. If code can be 'malicious' then computers are 'malicious', and operating systems are 'malicious', and networks are 'malicious', etc. If I feel that the code in a particular ...


46

Before you ask your question... Understand the community Code Review is a collection of users with different experience levels in different technologies. These users each have different time commitments and availability. Understand that you are requesting a review, and you cannot demand one. Code Review is not just a 'service' to be used for free. It is a ...


46

We need to be better about pointing out what the OP of a question did right. Particularly if "the code looks good." It's an important part of a review that often gets overlooked. It's good for morale and stops questions containing impeccable code from zombifying.


46

Thank you 200_success, rolfl, Jamal Thank you for moderating us! And thanks to all the moderators that we had before you. I bet we'll see at least some of you as moderators again soon!


45

I think that such question should clearly state that it is a follow-up question to a previously asked question. A good follow-up question should include, in my opinion: Which question it is a follow-up to What changes has been made in the code since last question Why a new review is being asked for If a question does not include (at least some of) these ...


43

No code in the question Very easy to test for. If there is not a single formatted full line of code in a question: Code Review questions must include the code to be reviewed in the body of the question.


43

Make the code as clean as you can before submitting it for review. The more work you put into your code, the more you're likely to get out of review. That's because reviewers (especially the volunteers here) have a limited amount of time and energy to put into a review. If they have to spend their time pointing out basic issues such as lack of ...


42

I'd like to describe what I would like to see on this site, rather than the current practice. As noted in Answering Guidelines (answer length), there is a desire for cultural change on this site. Allowing shorter answers should improve the answer rate by lowering the barrier to contribution, and hopefully increase reputation scores all around. I think ...


42

Meme: Java vs. JAVA Originator: Jamal(?) (to be determined) Cultural Height: The 2nd Monitor (as usual), but also in various comments scattered across meta. Background: Question with the word JAVA (instead of Java) in the title or body, is often an indication that the poster is a beginner and/or that it's a low-quality question. This has led to the ...


42

Upvote for effort I think that it's important to keep in mind what it's like to post to Code Review as a total newcomer. After all, they don't teach you in school how to post a question to Code Review. If a user's first post is… On topic, Includes sufficient context, Has a good title or can easily be given a policy-compliant title, then that means that ...


40

I looked through the major SE sites and their logos and noticed they're quite minimalistic. So I grabbed my sketch blog and a pen. This is what I came up with: Update 1 No more beta-blue Better angles for the breaks, so people actually figure out what the letters may be. :~) Update 2 Based retailcoder's T-Shirt question Update 3 Another T-Shirt ...


39

Note Accumulating multiple discussions about why the 'own code only' restriction is in place on Code Review There are multiple reasons why Code Review has the restriction that the code has to be your own code. Moral / Polite The purpose of a code review is to provide constructive criticism. Criticism can only be constructive if given to the person who is ...


39

After you ask your question So you have asked a question, how do you ensure it succeeds? Note: there are two sets of rules for editing your question - one set applies before there are answers to your question, and the other set applies when it has already been answered. Feel free to edit all parts of your question before answers are given, but read up on the ...


38

Meme: TS | RSA Originator: SimonAndréForsberg (TS), rolfl (RSA) Cultural Height: star-power Background: The 2nd Monitor is quite a star-happy chatroom. How many of you know that there's only a number of times you can "star" a chat post - a star cap (like the rep cap and the vote cap, a star cap). And just when you run out of stars to sprinkle, someone ...


38

Meme: "Thanks, Santa!" Originator: Jamal ♦ Cultural Height: The 2nd Monitor Background: Votes are anonymous. So whenever someone upvotes a post of yours, and you think the voter might be in the chatroom, just say "Thanks, Santa!", the voter(s) will know that was for them.


38

Not all tags have enough reviewers. Objective C has @nhgrif answering most of the questions, and I personally find it hard to get ActionScript code reviewed (although it's practically Javascript with classes and strong typing). Looking at the other answers, maybe the point is more this: There's not enough answerers. Code Review is pretty special here: ...


38

The Golden Rule of migration, of course: Don't Migrate Crap


38

You're not wrong. Unfortunately, because we are a smaller site (we're 27th/166 of main sites in the network, and 27th/73 of graduated sites) and we only have ~40,000 questions, it's difficult in some more obscure languages to get up votes and accepts. It's harder to see the value. If we compare ourselves to a site like DBA (they only have 11k more ...


Only top voted, non community-wiki answers of a minimum length are eligible