New answers tagged discussion
2
In the question, you wrote:
… so I am not relying on libraries like cats even if they might already provide solutions for what I am doing.
That sounds like a good reason for applying the reinventing-the-wheel tag — to let reviewers know that you are deliberately doing something the complicated way, so that they don't post an answer that says "why don't ...
4
A moderator didn't edit your question to add the tag, a normal user did.
I did not rewrite anything from the library mentioned earlier or any other library I know, and this statement was supposed to veer of answers pointing out how what I am doing could be done with half the code with a certain library at hand.
Then remove the tag, it probably isn't ...
9
You could go for a humourous approach. Instead of embedding “explicit” words in the code, you could embed “dirty” words.
# Explicit words replaced with "dirty" words during code review.
explicit_words = [
"stain", "stained", "staining",
"dust", "dusty", # Note: "dusting" would be a clean word
"soil", "soiled", "soiling",
"...
16
There is no simple answer to this question.
On one hand, Code Review requires real code. Anytime you redact something for the sake of posting it, something is lost in the process.
Different people react differently to profanity. Should sed -i -e 's/f.ck/hug/i' be applied to the Linux kernel? That's debatable, and therefore it is a valid topic to be ...
1
I'm the sinner adding the "ROP" tag - changed to "railway-oriented" by 200_success. I had no idea of the ambiguity, and didn't investigate further about it, because I thought it was a more well established term and pattern than it apparently is.
My primary references are:
The documentation for the Result<'t, 'err> type
and
Railway Oriented ...
2
I edited that question without having been aware of this Meta question. I would like to give a chronology for the record:
I saw it at Rev 2, and had the confusion as you. The first search engine hits for "rop" (e.g. Wikipedia) led me to believe that it stood for "Return-oriented programming", which made no sense in this context. The rop tag had no ...
4
Burn it
Before thinking about another name, let's see if the tag is useful at all. And I don't see a use for it. If you want to use either railway- or return-oriented-programming, fine, leave a note in the question. But we already have functional-programming and I'm not a fan of having a tag for each variation within it.
Note: at the time of writing this ...
10
As I see it, being nice to new contributors means that we give them more friendly guidance on how to make their questions and answers acceptable for Code Review. It doesn't mean that we lower our quality standards or ignore our rules.
I believe that the question is off-topic, as originally posted, because it asks for help to fix the code to accommodate ...
10
I can see why the question has been closed. It clearly does not work as intended, the author states:
So essentially I can encrypt a single word, but not a sentence. The
program crashes on me if I try to input more than one word. How would
I go about encrypting a sentence?
If the code is intended to encrypt sentences, and it does not encrypt sentences,...
6
Questions on Code Review must have the code in the post.
Can I put my code on a third party site and link to the site in my question?
Reviews of code not stored here
Can I ask for a review on a website?
Questions that ask for you to e-mail them to get the code
If you want reviews of each video:
Post the relevant final code from the video you want reviewed....
2
Videos are no substitute for actual code.
However, if the code is included in the question and the question complies to the help center, I don't see a problem.
12
Sorry that you're feeling that your answer is not appreciated, but looking through it, I can understand why it has been downvoted.... your answer does not review your code, it just presents an alternative solution without really indicating why the code in your answer is an improvement on your original code.
Code Review answers are expected to review the ...
4
https://repl.it/repls/WrathfulYummyTransversal is currently "Offline for maintenance" (which is why it's a good idea for why to include all the relevant code in the question itself).
Right now I can't tell if all the code is there or not, but assuming that it is I just read it briefly and noticed "There's no way this can generate a Sudoku puzzle" (Yes, I ...
7
Questions can be on-topic and still attract downvotes.
The general rule for downvotes is to cast them when:
This question does not show any research effort; it is unclear or not useful
That's the exact hovertext when you keep your mouse over the downvote arrow.
In theory (not in practice), downvotes have nothing to do with a question being off-topic or ...
3
The lock was introduced after the second rollback to your question. A lock is a moderator tool that is powerful to use in order to calm things down. While I probably would have used a lock in the case of a third rollback, I still support its usage here after the second rollback.
The alternative to a lock would have been to just rollback and risk a ...
8
The edit was a change to the code, and specifically a change to an aspect that has been mentioned in a review. If you make changes to your question, you are expected to ensure that the answers remain correct - this generally means not changing the code that's been reviewed.
There's really no need to change the code in the question anyway - any subsequent ...
4
Meme: Skiwi (verb), e.g. "skiwi'd"
Originator: IvenBach (?)
Cultural Height: VBA Rubberducking
Background: Skiwi has long been renowned to consistently have well over 1000 open tabs in his browser. "To skiwi something" means to open a browser tab and leave it opened to get back to it... eventually.
2
Code review requires "working code" to be an on-topic question. There is no specification of what the language of the code is, just that it works, so, it really comes down to what "works".
To me, working code is code that, when put in the correct context, can be executed, and will produce results that match the design expectations.
Although it is not ...
5
The comments on the post were auto flagged for being excessive. Further, they are, at times unfriendly... approaching rude and abusive. I locked the post for an hour in order to force any further discussion in to chat. I believe the desired effect was achieved. I was not able to hang around and monitor the post directly, so preventative cooldown was the ...
2
The specific question you refer to was automatically unlocked 20 minutes after you posted this question. The lock was explicitly set to automatically time out after an hour.
Discussing the specifics of this action seems to have little merit, because opinions around temporarily locking a question are almost guaranteed to be different.
19
To be completely clear:
homework[1] [2] and coding challenges are on-topic.
Issues with tags should be edited, it's rare to get questions with perfect tags - I get them wrong all the time too.
This means the questions are on-topic and so we shouldn't close the questions.
TL;DR: It's recommended to ignore who the user is, but ultimately it's your choice to ...
10
Know what you are doing
If you know the language in question just like you know your best friend, then I'd say feel free to edit and correct it.
In this particular case the code was a mix of Python and some C-style language, so the edit makes perfect sense and I would have also voted to approve.
Think about what the best value for the site is. Don't just ...
7
clean-code would be a meta-tag - a tag that describes what you want the code to look like, not what the code is, or does. Additionally, all questions should be asking to review for clean code, for readability, and for a number of other things that are common to good, production code.
So, clean-code would be a bad tag for Code Review, and we are actively ...
Top 50 recent answers are included
