New answers tagged

-3

Welcome back, I know you'll do as good a job as always! On the other hand, elections take a while to arrange, and the SE community team has plenty on their plate at the moment [...] we will need a bit of time to assess whether an election should be held, but with me getting back on the moderator team now, we get to take urgency out of the equation, and ...


7

Putting your hyperboles aside, I completely understand and respect your decision. SE has succeeded in alienating itself from its user base over the last weeks. The new CoC, while crafted with the best of intentions, has massively backfired. Most can be backtracked in MSE - FAQ Gender Pronouns and CoC Feedback and on Twitter. Minorities are being ...


7

Thank you for stepping up in our place, Mug Mathieu! I know you will do great! And thanks for reminding me to blame the monkey, I knew I forgot something when I stepped down as a moderator a few months ago...


14

I think you're making this more complicated than it really is. The new CoC isn't hard, it boils down to be nice as it always has. The pronouns thing isn't supposed to make anyone walk on eggshells. If someone tells you they'd (see? it even comes naturally!) prefer you address them as "they" and you deny them that on purpose, then you're being a jerk. Do ...


14

Welcome back, Mathieu, and thanks so much! As I tried to communicate to Mathieu, that while I hold to my belief that resigning my diamond is, on balance, in my best interests, I know that I have put the mod team and the community as a whole in to a state of turmoil. As I said to Mat: "I understand your concern about the "appearance" aspect of being "...


2

I really want to opine that it's fine. It can be educationally useful, especially for students who might assume these code practice sites are modelling good practice. Nevertheless, it probably is not a strictly valid target because of the authorship requirement. The challenge defines an interface. Interfaces are code. If you're hobbled by a shoddy ...


11

Rolfl, feeling sad to see you step down. I surely understand your reasons but hope you stick around. That beeing said, thanks a lot for endless hours of keeping the site running. See you in the 2nd monitor


17

Here I was hoping CR would survive this intact. Instead, a veteran moderator steps down. !@#$. I don't blame you. I really don't. Given the circumstances and the risk you'd take by continuing, there's a lot of wisdom in your choice. Considering you're the wisest monkey I've ever seen, it's not unexpected to see you make the wise move. We've seen you can ...


24

Thank you, rolfl! There are too many things I feel thankful for when I think of you to list them all, but here are a notable few: You have always been welcoming and kind to newcomers. I feel sure many new users of this site—like myself some years ago—have appreciated your guidance and have come back for more, or even stayed and became a regular as I have. ...


16

I was hoping this mess would not involve CR, but here we are losing a Moderator that has provided a sane and mature outlook on CR for a while. Thank you for all your efforts.


20

Ouch. And Thanks for all the bananas. I have been watching all of this in the Moderator Chatroom with growing trepidation, but unable to articulate why. But you just managed to say this way more eloquently than I could have managed. Thanks so much for sharing you thoughts, and good luck to you.


32

I'm very sad to see you go and I want to thank you for being a hugely positive influence to this site in your elected tenure, your appointed tenure, before and in between. I've learned incredibly much from you, both on a technical and a social level and I look forward to seeing you around the site :) Thank you so much!


11

Code Review only allows for reviews of code that is written/maintained by the author. We have that requirement for multiple reasons, including legal (copyright) and moral (to avoid code-shaming). When a question asks to compare the poster's solution against some arbitrary solution found on GitHub, that is a underhanded way to ask for a review of third-party ...


4

I don't see a problem with challenging the questionable requirements of a programming challenge, however, I think the answer should have given priority to the OP's code rather than the silly requirements. I would have organized the answer somewhat differently with the silly requirements after the observations about the OP's code.


3

The question is for questions, not for responding to answers. It's sufficiently simple and clear-cut that I have, as Wikipedia puts it, be[en] bold and rolled back to a version of the question which was pretty much just question. (I was tempted to roll back to version 1, but I thought that might be overdoing it). On the more general subject of how to ...


7

From the comments: But my point is, that I do not really want feedback on how to write the code. I want feedback on the api and documentation. Like, do you see why the library is useful? Are you able to use from the examples provided? Emphasis mine. That actually changes things. If you don't want a review of the code, what do you expect from a site ...


3

Should something be done about the "reasoning" part, that brings no value to the post? Should it be edited out? IMO voting is the way to go here. Editing out the reasoning part won't make the question any better. If I look at the question above the reasoning part I don't see a good question. It reads more like an answer to a question.


19

Is it on-topic to review a challenge's requirements? To the extent that the requirements force bad code, Yes. The core of every question at Code Review is "How can I make this code better?" It is not "How can I solve this challenge?" If the asker has not gotten at least that far already, their question is off-topic here. Therefore every question at Code ...


0

I understand the point the answerer was trying to make, but I feel like challenging the challenge's requirements has one big flaw : The OP cannot use the review to make the code better. The challenge has a very specific context and the question is set in that scope, it's very possible that the OP is already aware that the challenge's requirements are ...


6

A rollback is a dangerous option and should always be considered carefully. And yes, I've screwed this up myself at least once, so don't beat-up yourself too much about it either. The entire point of a rollback is to prevent a question and answer being out-of-sync. So, a rollback causing this, is not a good situation. Does the question need to be rolled ...


9

There shouldn't be a problem with a library. Clearly state that it is a library in the title and explain what the library does in the title and in text before the code. Clearly identify the API(s) in in the text before the code. Possibly list the unit test cases before the library code. You might want to look at the help pages at https://codereview....


-3

I enjoyed reading http://meta.stackexchange.com/questions/3528/dealing-with-questions-of-nefarious-intent - there's a lot of important nuance there that hasn't really been mirrored here in CR meta, so despite this question being already answered I need to add my two cents. Saying "code is not malicious, guns don't kill" is a non-argument. As practitioners, ...


5

Cracking/Hacking is not a reason for a post to be off-topic, but this specific question has incomplete, and non-functional code, so it's not working as intended, so it is off-topic. I have closed it with that reason. Having said that, if/when the code works, it would possibly be ready to reopen as working code. There is a question answered about these ...


9

I'm not asking to review the code This alone dismisses the idea of a meta-review as invalid, for me. We only review code. The OP could easily just post the new code and receive valuable feedback about it. Whether that's feedback about portions of the new code that have been affected by the changeset or portions of the new code that were unaffected is fairly ...


6

We have a tag "Comparative Reviews". I believe this indicates that we do support these kinds of reviews. The user went one step further by including the git diff, I don't see that as a problem.


8

Code Review is different to Stack Overflow in several ways, some of which are addressed in other answers. One important difference is that Stack Overflow is a repository of useful answers to specific problems - the value is to all the people, now and future, who have the same problem. In contrast, Code Review answers are directed very much at the specific ...


15

pacmaninbw wrote a decent answer already, but let's clarify this further by an overly long answer. People come here to get their code reviewed. Enthusiasts, starting professionals and veterans, all on the same site. Advice useful to somebody without background in software may not be useful to veterans. Veterans are likely helped by different answers than ...


Top 50 recent answers are included