Podcast #128: We chat with Kent C Dodds about why he loves React and discuss what life was like in the dark days before Git. Listen now.
32

Nice rant. My turn now. "Perfectly on topic" The aftermath of my test: the question is closed as "off topic" / "broken code", while it's perfectly on topic, and the code actually works! It received three good answers, one of the answers is really in-depth, and with good measure of understanding. And it was downoted at least twice. The question is not "...


26

Voting (in either direction) is a very subjective and personal thing. As you've mentioned, you've already had a comment on your answer explaining where one person feels your answer is lacking. Whilst you've posted this question, you haven't responded to the comment. You may 'totally disagree with the comment', but you've not provided an explanation as to ...


25

I agree that insightful reviews deserve more points than answers that are merely linting. However, I believe that no answer should be downvoted unless it contains advice that is actually harmful. Code Review's policy is to allow critique on any and all aspects of the code. As per in Let's work together to offer ultimately better content, faster and Short ...


24

This question was, in my opinion, improperly closed, because it could have been an allowable question with some minor changes. I applied those minor changes and reopened the question. You rolled it back. I've closed the question again. As for extrapolating this closure into general accusations of negativity… that's not appreciated. Please focus on the ...


20

Speaking as somebody who joined CR very recently and didn't do a great job finding out all the rules beforehand, I've found the community to be very welcoming. We have relatively few rules, and as a result we are quite strict about enforcing them. The code must be your own The question must be clear and actually be a question (even if it's just "how good ...


18

To throw some more accurate numbers into the mix, here is the query for the following results. As of 1 Sept 2015 14:26 UTC-4, there were the following breakdowns for questions (on SEDE, which is always behind): Code Review: 26507 Total questions 24876 With a score of 1 or more (93.85%) 1289 With a score of 0 (4.86%) 342 With a score of -1 or less (1.30%) ...


16

Your example of x = a + 1 + b - 1 is a bit disingenuous. As on the main site, we should be discussing real code rather than hypothetical examples. I see from your history that this is not your first complaint. The community consensus is that code-only answers are not acceptable. Several of your past answers have been forcibly deleted: Alternately taking ...


16

Your question, as originally written, was marginal for Code Review. As of Rev 6, it is now a fine question. The problems were: Your question had a generic title that did not meet the guidelines in How to Ask a good question. You also dumped a bunch of code in the question without explaining what the code is supposed to accomplish. As a result, the code ...


16

You are conflating trivial with bad. In the specific case you complained about, I agree that it's useless. The original proposal of template aliases was not to introduce a redundant feature for typedef. In general however, the other stuff you mentioned isn't useless. People make the same mistakes over and over or ignore advice, thinking it's unimportant. ...


16

Are you aware that you keep making the same mistakes over and over? From a comment My guess is that this is the source of the down votes. It's a user who keeps asking questions, but isn't learning anything. I don't think it's a good reason to downvote a question though. We should vote on questions, not users. For the record though, I've never seen a ...


16

First of all, some simple statistics. (...) I participate in several other SE sites, and until today I only had this vague feeling that TeX is kinda welcoming and Codereview is not so much. I understand that you have good intentions by posting statistics, but there are a couple of problems with statistics. First of all, the statistics does not include ...


13

I didn't downvote, and I can't say that these are the reasons for your downvotes, but I can critique your answer anyway. You made two main points: Random-number generation. You correctly spotted a bug: that it is possible to accidentally generate duplicated multiple-choice answers. However, your explanation is misleading: the possibility of coincidences ...


12

I don't think that this site suffers from a lack of down-votes. Rather, it suffers from a lack of up-votes, and up-votes are always free. It's kind of perverse, actually. Often, the good questions are the ones with crappy code. It's a bit counterintuitive to vote up crappy code. On the other hand, short answers attract up-votes faster, and it's hard to ...


12

Everyone is free to vote as they see fit. Even if we would encourage people to down-vote "too trivial" answers, there will be a discussion about "what is too trivial?" - which is a highly primarily opinion-based discussion that I'm not interested in engaging in. Personally, I have down-voted answers that I consider "too trivial" or "not really important in ...


12

Sorry that you're feeling that your answer is not appreciated, but looking through it, I can understand why it has been downvoted.... your answer does not review your code, it just presents an alternative solution without really indicating why the code in your answer is an improvement on your original code. Code Review answers are expected to review the ...


11

Stack Overflow is about solving a problem. A question, an answer. "Try this {code dump}" are somewhat frequent and often acceptable SO answers, especially when trivial. Code Review is about reviewing OP's code. It's not quite Q&A, so it's not quite "a question, an answer". "Try this {code dump}" are somewhat frequent, but never quite acceptable CR ...


11

Downvoting has benefits. A while back I asked what happens to questions with a negative score? on Meta SO. Interesting things happen when a question goes negative. Current questions At -4, the question does not show up on the front page. All questions -1 or lower score, more than 30 days old, no answers, not locked... deleted by ...


11

If we take a look at https://codereview.stackexchange.com/help/on-topic we see To the best of my knowledge, does the code work as intended? if the OP answered this for him/her-self with yes, then the question should be on-topic (if the other questions on the on-topic section could be answered with yes as well). That being said, it looks like the downvote ...


10

At first I was quite reluctant to downvoting. When you have < 500 rep and getting there took all your spare change (I hope that translates well), you think twice before giving away a single point just because someone wrote a bad post. This is the same on every SE site BTW - at one point or another, you stop caring much about your reputation score, and ...


10

If I had to speculate, I would guess that it was this statement in Rev 1: On mobile I am not able to indent the code.. sorry Especially since indentation is significant in Python. The code was just unintelligible the way it was originally posted.


10

Bumping a bad (off-topic) post off the front page. Any post below -4 is thrown off the front page, so we get an on-topic front page with interesting questions.


10

Let me give this specific-answer question a specific answer. You say your answer isn't notably different from the other answers. Let's check that against the "facts". For context: Here's my explanatory comment: Your first point is not sourced at all ... I'd say [citation needed]. The second point is a link-only answer, which is discouraged and the third ...


9

Votes are anonymous and, up or down, don't need to be justified to anyone. Vote as you see fit, regardless of the votes already on a post.


9

Possible reasons behind a downvote (for otherwise on-topic questions): Code-dump question (probably already implying a review) Lots of typographical errors and no desire to fix them Someone is just having a bad day Overall, vote as you see fit. You can't expect everyone to follow some set of guidelines, either. Downvoting may only become an issue if, for ...


9

Unfortunately, your question is based on a faulty premise. The code to be reviewed consists of a makeBst() function with one test case. That test case produces incorrect output: class BinaryTreeNode { constructor(value) { this.value = value; this.left = null; this.right = null; } } function makeBst(arr){ if(!arr || arr.length <= ...


8

All stack exchange sites suffer from meta-effect - the action on main-site posts as influenced by discussions on the meta site about that question. That users' questions were recently discussed here: Users that appear to learn nothing Hence the impact on their latest question.


8

Because, ultimately, the point of Code Review is to make code better - and if you're not making the code better, if you're not addressing the actual problems in the code by just grabbing the low-hanging free-rep fruit, then you're really not helping anybody. The points you mentioned, while they are easy suggestions, they do make the code better. size ...


7

Note: I'm not one of the downvoters. Your question is at 0/-2, which means nobody thought your question was worthy of an upvote and 2 thought it was worthy of a downvote. That's not good. Why? Well, the only way to be sure is if they tell themselves. However, downvotes are anonymous and nobody is forced to explain why he or she deemed a certain question/...


7

To rectify: At the time of writing, the question has 0 / -2. Now let's get into why these downvotes might be there: The question presents two alternatives: Believe it or not, I know of users that by principle downvote questions that present two (or even more) approaches to solving the same problem. I can somewhat understand them: "What code is up for ...


7

Questions can be on-topic and still attract downvotes. The general rule for downvotes is to cast them when: This question does not show any research effort; it is unclear or not useful That's the exact hovertext when you keep your mouse over the downvote arrow. In theory (not in practice), downvotes have nothing to do with a question being off-topic or ...


Only top voted, non community-wiki answers of a minimum length are eligible