Podcast #128: We chat with Kent C Dodds about why he loves React and discuss what life was like in the dark days before Git. Listen now.
16

Four years later, we now have over a dozen questions on Project Euler #1, including multiple implementations in the more popular languages. We also have hundreds of linked-list questions, many of which solve the same problem. Considering the rule that Code Review answers can cover any or all facets of the code, the threshold for considering two questions ...


15

Obviously, SQL injection is a major source of anxiety among beginner PHP programmers. It doesn't help that the deck is stacked against them: The language makes it easy to do the wrong thing and hard to do the Right Thing. Learn PHP in n Hours books gloss over the subject, and even teach them to do the wrong thing. There are a lot of bad examples out there. ...


12

Well, whatever it is, it is certainly not a duplicate. The follow-up question asks about the proper use of divs and spans; the original question contains no spans. I agree that it is rude to ask a follow-up question without adding mutual links, because that wastes other users' time. However, the author has not concealed the fact that it is a follow-up ...


9

From my own personal experience, finding accurate information regarding SQL injection, and even basic PHP security, is actually quite difficult for the novice. A search on Google can bring the best of tutorials and the worst of home-made blog posts. For the rookie, it all seems to work. I think if we could offer these guys a good resource that stays up-to-...


8

More or less, I'm of the thought that the answers the asker receives takes care of this. There are cases where users are actively adding additional features and it makes sense if it all leads to a related task to have an iterative series. Review focused on a, implement suggestions and create A, add b + c, post new question Abc. Sometimes, follow up ...


8

Duplicates are harder to determine on this site in particular, and this is something we're still unsure about overall. I don't think we've never had a situation where the asker has found an existing question to have enough relevant material. In your case, you're free to do that if you're certain. However, even as the asker, your flag is still subject to ...


7

Yes, and No Let's be clear here, the code works for the purpose given. The code presented will never be called in a way that exposes that bug, so is it a bug? Not for the asker. That code is not intended for review but is intended to provide background for the actual algorithm/process he wants to accomplish. The bug is only a bug if you extend the usage of ...


7

For me an answer is related to a question. An answer about formatting and naming the vars correct is also a very common answer. Do we have to redirect them to answers of the other questions for that? That said, I think I would vote to close the second one as duplicate or broken code if the first answer already has the duplicate answer before the posting of ...


7

If I remember correctly, the user in question posted a very similar question within 24 hours before that one, and removed it after 15 mins when it received only 2 comments, one from me linking to the tags in w3schools. The reason this stood out to me was because he commented angrily and rudely about the site. Since the post has been deleted, I have no proof, ...


6

Yeah, the comment "your question is a duplicate so we closed it, please ask again" doesn't make any sense in its current form. However, let's keep in mind that the situation is quite hypothetical, because as @rolfl said it too, legitimate duplicates are extremely rare on Code Review, and I don't think that's going to change in the foreseeable future. That ...


6

I'm not sure it's entirely appropriate to mark any questions concerned about injection as duplicates of any other question. Why? Because it's not a duplicate question. It's a new question about the same topic. The appropriate response may be to down vote the question and leave a comment suggesting some reading material on the subject. I'm not convinced that ...


5

I will disagree with Jamal here ;-) Your question is not a duplicate. The nature of Code Review is that different code, even though they accomplish the same task, have different styles, inconsistencies, strengths, and weaknesses. A review for your code will be different to a review for the other code, even though the output is identical. Just looking at ...


5

Unfortunately, this is not something we can support or special-case, at least not in the foreseeable future. As most of you are aware, Code Review is a bit of a special site; questions are not asked for the same purpose here that questions are asked on most other Stack Exchange sites, nor are they held to the same expectations as questions asked elsewhere. ...


4

The problem as I see it is that the Poster created a new question rather than updating the original and getting that re-opened. Is there some way to instruct the poster that it would have been better to fix the original question rather than post a new one? I would also recommend that the original question be deleted. If the original is deleted I will remove ...


4

Perhaps I'm late to the party, but just looking at the code, these two questions don't appear to be duplicates at all. The code is quite clearly different (and Code Review doesn't have quite exactly the same duplicate rules as Stack Overflow). I do agree that when users post follow-ups or other questions and quite clearly haven't taken into account the ...


3

I suggest the wording You may read the following reviews on code that solves the same problem as yours.


2

In one sentence: I think on Code Review labeling something as a duplicate should be done sparingly. I think this touches on a greater "problem," however, in that a strict interpretation of the StackExchange ethos would say that posts must ask a question, and in response, one answer must rise to the top as "the" answer. I will add that I don't really think ...


1

This is an example of incorrect handling I feel people are taking the idea that an OP should be able to improve their off-topic questions too far. To the point where they're only allowed to improve an off-topic question and that they're not allowed to post a new one. This should not be behavior we want on Code Review. This post which has been otherwise ...


1

As you said, it does not make sense to close them as a duplicate as they should be just as welcome, not only because the code may be a little different, but also that conventions may (READ: will) change over time. As @SimonForsberg said, it would make sense to change its purpose, but with the new name, it would not make much sense as a flag. Hence it would ...


1

Really, this question is redundant. Code Review should have no duplicates (I wonder how many it actually has?). Code Review is very strict on what is defined as a duplicate. To qualify, the code is essentially identical on each question - this is rare, indeed. Now, why does this make this meta question redundant? Because if there really are duplicates, ...


1

This started off with a two-way duplicate; That is, two questions contained the same code-pattern. In that light, I would have said "each question is separate". If a question happens to contain the same code(pattern) as another, it's perfectly valid to post answers on both questions listing the same points. Just make sure your answer is valid (if they say "...


Only top voted, non community-wiki answers of a minimum length are eligible