Hot answers tagged

24 votes
Accepted

Can I edit broken code if I'm sure I'm recreating OP's original code?

I prefer to err on the side of commenting and closing, rather than fixing the code for them. Reasons include: Fixing broken code is a slippery slope. Newer users will see that and assume that ...
200_success's user avatar
15 votes
Accepted

Removing leading white space in question code blocks

In general you shouldn't be editing code in the question, but instead reviewing it. But there are at least two cases where it's fine to make an exception: Where the poster has fumbled the formatting. ...
Gareth Rees's user avatar
  • 49.6k
13 votes

Discouraging gigantic headers in answers?

I believe this is more a matter of personal preference than anything else. Personally I tend to use ### (h3 in HTML) for ...
Simon Forsberg's user avatar
13 votes

Discouraging gigantic headers in answers?

I think it would be inappropriate to change headers into bold text. For one thing, it's a trivial edit — if it were a suggested edit, would it really be worth +2 and bothering other users to review ...
200_success's user avatar
13 votes
Accepted

Is it allowed to edit code if there is no answer?

Sure you can edit your question/code if there are no answers. Just don't place alternative code-junks without adding the comperative-review tag. Replacing the code in question is fine without ...
Heslacher's user avatar
  • 50.4k
13 votes
Accepted

Does a question with (a lot of) OP response to a posted review qualify for a rollback?

The state of the question as seen in https://codereview.stackexchange.com/revisions/214917/6 (before my rollback) literally says "In response to Peter Taylor's answer". It makes the question ...
Simon Forsberg's user avatar
13 votes
Accepted

Should we improve the code to be reviewed in an edit?

This specific case is a bit unusual in that the edit was "suggested" by a user with the same username as the original author. Note also that the original author's account is unregistered, which ...
Vogel612's user avatar
  • 25.2k
11 votes

Indentation in answers

There's no unwritten rule for that, no. People (me included) edit answers to improve formatting all the time, here or anywhere else on SE - there's even incentives (imaginary Internet points!) for ...
Mathieu Guindon's user avatar
11 votes

Not notified of unwanted edits to question

Let's try adressing the questions first and then some more general stuff: Why did I not get a notification that my question received and edit? This MSE post suggests that edits need to meet ...
Vogel612's user avatar
  • 25.2k
10 votes

Discouraging gigantic headers in answers?

Disclaimer: I use H3 headers all the time I agree that gigantic headers don't look good. But we might disagree on where we draw the line on what is "gigantic". As @200_success wrote in his answer, ...
janos's user avatar
  • 111k
10 votes

Major edits made to my question about using a string or array to index object in JavaScript

Thank you for revising the question — Rev 5 is much better as a Code Review question than the original. That said, I hesitate to reopen it, because I'm not 100% sure I understand what you are trying ...
200_success's user avatar
10 votes

A moderator edited my question. I don't like the way it looks now

Let's check the edit diff and see what it's about: title diff ...
Vogel612's user avatar
  • 25.2k
9 votes

Regarding editing questions

The edit with approval system requires three people to participate. There was a decision made in the beginning that three people should not get bogged down in small edits that could be easily ...
mdfst13's user avatar
  • 21.5k
9 votes

Should Code Review serve as a refactoring cookbook?

Getting the best value out of Code Review I disagree with the premise that Code Review is about "Whatever your XXX, apply YYY". Code Review looks at your code, holistically and in the context of its ...
200_success's user avatar
9 votes
Accepted

Should Code Review serve as a refactoring cookbook?

The point with CR (again - IMnsHO) is rather to present a proper, readable and maintainable coding style. This is where we might disagree. The point of Code Review Stack Exchange is to ask for ...
Simon Forsberg's user avatar
9 votes
Accepted

Rollback reason

Lock the question as soon as it is answered. Sound a bit too drastic. Locking is a moderator tool with good reason. For one the lock mechanism implemented by SE currently only allows completely ...
Vogel612's user avatar
  • 25.2k
9 votes
Accepted

Preventing edit wars

If there were a mechanism (?) to impose an edit freeze while discussion happens, I'd vote for that, but I don't know that there is one. Actually... there is a mechanism for that. It's just not ...
Vogel612's user avatar
  • 25.2k
8 votes

How should question bodies be organized?

Honestly, as long as it's all there, I don't mind the order of things. Especially if headers or other methods of formatting are properly used to keep it all tidy. Questions should contain a problem ...
Mast's user avatar
  • 13.3k
8 votes

An edit of mine was rolled back and the question locked

The edit was a change to the code, and specifically a change to an aspect that has been mentioned in a review. If you make changes to your question, you are expected to ensure that the answers remain ...
Toby Speight's user avatar
  • 74.5k
8 votes

Peculiar application of [reinventing-the-wheel] tag on my question

In the question, you wrote: … so I am not relying on libraries like cats even if they might already provide solutions for what I am doing. That sounds like a good reason for applying the ...
200_success's user avatar
8 votes
Accepted

On/off-topicness of "conclusions" added to the original question

We have an existing FAQ that discourages adding updated code. You also should not append your revised code to the question. Posting improved code is an answering activity, not a questioning ...
Peilonrayz's user avatar
  • 43k
7 votes

Is it okay for OP to edit to include Benchmarking results?

If the code in the question already contains a benchmark, or it is obvious how the performance will be evaluated, then a simple comment on each answer would suffice. For example: Thanks to your ...
200_success's user avatar
7 votes
Accepted

Can an OP add missing keyword(s) to code?

No the question should stay as it is, because not only would this edit invalidate two answers (first, second) but I think we would send the wrong signals as well. It would look like it could be ...
Heslacher's user avatar
  • 50.4k
6 votes

Is adding a single tag enough to constitute a meaningful edit?

I believe that adding a single, relevant tag is a meaningful edit. If it helps someone in the future to find a question that matches their search, or favourites, then, yes, it's a good edit. Note ...
rolfl's user avatar
  • 97.3k
6 votes

Regarding editing questions

Just to throw this out there for everyone: I'm actually not the most persistent SE editor ever, though I am on CR. ;) Anyway, you're right that the system does place priority on those with editing ...
Jamal's user avatar
  • 34.8k
6 votes
Accepted

Should complexity formatted as code be updated to use MathJax?

Why not? Especially if there's more to edit than just a single instance of O(n)... I presume screen readers treat MathJax differently than inline code, too. I ...
Mathieu Guindon's user avatar
6 votes
Accepted

The character threshold for editing questions needs redressing

The reason you see this 'restriction' is due to the fact that Stack Exchange employs some 'trust' requirements before you can go unilaterally editing other person's questions/answers, regardless of ...
Der Kommissar's user avatar
6 votes
Accepted

Should we allow answer invalidation for otherwise off-topic questions?

Let me quote the answer to which @Mast posted a link in his answer: Answers to off-topic questions are already invalid One way to look at this is to say that if a question is invalid, it ...
Heslacher's user avatar
  • 50.4k
5 votes

Is it okay for OP to edit to include Benchmarking results?

No. Questions aren't about polling the results of the answers, questions should contain absolutely no information about results of answers. If you want the OP's timings of the answer, get the OP to ...
Quill's user avatar
  • 11.9k
5 votes

Can I edit broken code if I'm sure I'm recreating OP's original code?

IMO the code of a question should never ever be edited. The only exception to this rule is if it is a clear copy&pasta error. If the OP knows the language well enough I assume he/she could edit ...
Heslacher's user avatar
  • 50.4k

Only top scored, non community-wiki answers of a minimum length are eligible