33
votes
Accepted
How can I be a nice reviewer?
Empathy...
I am not necessarily a good example of a good reviewer, I have been the 'victim' of many reviews, and I have given a lot too. I am often tactless, and pedantic. I blame that on the fact ...
- 96.8k
27
votes
How can I be a nice reviewer?
Be impersonal
The goal of code review is to improve the quality of the code (and to produce shared knowledge that will contribute to the quality of code written in the future), not to evaluate the ...
- 49.2k
23
votes
Accepted
Are explicit words allowed in source code?
There is no simple answer to this question.
On one hand, Code Review requires real code. Anytime you redact something for the sake of posting it, something is lost in the process.
Different people ...
- 142k
20
votes
How can I be a nice reviewer?
This ought to be an interesting discussion. Let me pitch in a few things. Here is what I picked up from your answer, at a glance.
It is honest, which is good.
It points out a bug, which is also good.
...
- 20.3k
16
votes
Accepted
Self-accepting own answer when competing answers exist
There's nothing wrong with self-answering a question. There isn't even anything wrong with accepting your own answer if you review your own code and provide new insight that others haven't.
The ...
- 107k
15
votes
Self-accepting own answer when competing answers exist
Don't get me wrong, there is nothing bad with self-answering a question. There isn't even anything wrong with accepting your own answer if you review your own code with distinct points not stated in ...
- 21.7k
12
votes
Are explicit words allowed in source code?
You could go for a humourous approach. Instead of embedding “explicit” words in the code, you could embed “dirty” words.
...
- 31.2k
10
votes
If I implement suggestions from a review, where do I reply to say what I did / thank the reviewer?
Presumably, reviewers want to know that their suggestions were useful.
Indeed! As with all Stack Exchange sites, useful answers receive upvotes from readers. If you haven't done that already, give ...
- 74.7k
10
votes
How active should moderators be in opening/closing questions?
This specific question is directed toward 200_success, but I think the point you are raising is independent of that.
Let's break down your question in to what I think are the relevant parts:
Is ...
- 96.8k
9
votes
Self-accepting own answer when competing answers exist
In this scenario I think that specific user actually misunderstood site policies, See the screenshot below.
If it really is a misunderstanding as he claims we should forgive him, If he follow site ...
- 4,501
9
votes
Accepted
How can I make this comment asking for better titles more polite and friendly?
It's not really rude as such — you don't speak down to or insult the person — but I think it could be improved.
When you're trying to correct a behavior, it's important to explain:
What ...
- 859
8
votes
How active should moderators be in opening/closing questions?
General remarks
First of all, I appreciate the feedback. While good moderators can strengthen a site, bad ones (whether deliberate or unwitting) can be toxic. If any community member is unhappy ...
- 142k
8
votes
Accepted
Is the quality of my posts declining?
It's impossible to assign an absolute and correct indicator of quality to contributions, and their various facets, such as the value of the specific recommendations, and the delivery of the message.
...
- 107k
8
votes
Accepted
Should we un-delete useful answers that were deleted by OP?
Once the answer was posted here, it wasn't really OP's to withhold
from the world anymore. It belongs to the community and Stack Exchange
as well as OP, per the CC-By-SA license.
This bit right ...
- 9,779
6
votes
Reviewing Inexperience vs Reviewing Style
I don't agree with you.
The ternary in a ternary is hard to read, and your option to miss brackets can and does lead to bugs.
Both probably are in style guides, but both are definite problems with ...
PeilonrayzMod
- 41.7k
6
votes
How can I make this comment asking for better titles more polite and friendly?
I don't think your comment is rude. That being said if you wanted to soften it a bit and be more explicit about the "call to action" for the user, you could word it along these lines:
Welcome to ...
- 1,171
5
votes
Self-accepting own answer when competing answers exist
In recent discussions about Low Quality answers in the Low Quality Queue it was said that
a code dump is not a review, and therefore not an acceptable answer.
By Mat's Mug
Meaning that the ...
MalachiMod
- 28.5k
5
votes
How active should moderators be in opening/closing questions?
Basically, the gist of this is, we should be having discussions on the meta before overturning a close vote on a question that has received no edits since the close vote, right? At the barest of ...
JamalMod
- 34.7k
5
votes
How active should moderators be in opening/closing questions?
Speaking as a private contributor, rather than as a moderator…
Our mission is to review code or to have our code reviewed. Any other activity is a distraction from that goal.
Of course, some ...
- 142k
5
votes
Are explicit words allowed in source code?
This is a good question, and I think you made all the right moves with your actions:
You left the explicit words out;
You asked a question on Meta as to whether they're acceptable or not;
So, let's ...
- 20k
4
votes
Should we un-delete useful answers that were deleted by OP?
I have requested that an answer be undeleted, but that was because I was the Question Asker and I thought that the answer had really useful information in it that I wanted to use in my code, and I ...
MalachiMod
- 28.5k
3
votes
Is the quality of my posts declining?
Many things influence how many votes you receive. The biggest factor is probably how many people read the question; if you choose to review code written in "minority" languages, you'll almost ...
- 58.1k
3
votes
How active should moderators be in opening/closing questions?
To answer your question; I like my moderators active and involved, in all aspects.
That said, (and perhaps this should be a feature request), if a mod single-handedly undoes a close/open decision by ...
- 32.7k
3
votes
How can I make this comment asking for better titles more polite and friendly?
How about:
Welcome to Code Review! We would appreciate if you edited the title of your question to describe the function of your code. There are at least 2 advantages to this: (1) It will get more ...
- 20.3k
2
votes
Non-OP edits to change the original question to make it on-topic
Leave open. Nearly always. (*) If the OP claims, it supports Unicode and it doesn't... it's a bug w.r.t. their claims, but it doesn't mean it's a bug w.r.t. the specification. Maybe the claim was just ...
- 13.4k
1
vote
Reviewing Inexperience vs Reviewing Style
You post your code on this site, and you get feedback. Just like anything else you read on the Internet, some of the feedback will be valuable, and some of it, frankly, will be garbage. For that ...
- 142k
1
vote
Reviewing Inexperience vs Reviewing Style
public static int AsClamped(int index, int start, int end)
{
return index < start ? start
: index > end ? end
: index;
}
This isn't ...
- 20.7k
1
vote
How can I make this comment asking for better titles more polite and friendly?
This is what I came up with. Stating what the community has to offer first makes it easier for the user to invest and enjoy doing so. Please let me know what you think.
Welcome to Code Review! We'...
- 205
1
vote
How can I make this comment asking for better titles more polite and friendly?
Here is the quick comment that I settled on. I added a link to How to get the best value out of Code Review - Asking Questions
Welcome to Code Review! We're all here to receive constructive
...
1
vote
How can I make this comment asking for better titles more polite and friendly?
I think the comment itself is not bad. In my opinion, you should explain to the user what's the plus value to change his title so it sounds more of a friendly advice than "do this otherwise your ...
- 12.3k
Only top scored, non community-wiki answers of a minimum length are eligible