15

What should I do when someone answers my question? The page needs to mention that incorporating suggestions from answers into the question is unacceptable. It should also suggest options for follow-ups (posting a self answer or a second question). Basically, it needs to include a summary of the advice in this answer.


15

This site being Code Review, we require working code. We review excerpts of code that aren't complete programs. They could be library functions or even just a line or two of code. Let's not change our wording from "code" to "program" just because some users have an excessively liberal concept of what "working" means.


14

I propose to add a new section: I improved my code based on the reviews. What next? First of all, consider accepting one of the answers. The one that helped you the most, or the one you consider the best, the most worthy to stand at the top as recommendation for future readers. If you'd like to share the revised version of your code, the ...


12

The How to ask page is a little lacking. It doesn't mention that we expect titles to describe what the code does, not the concerns about it. The "Be specific" section could also be polished up a bit. I'm not sure how to go about it, but we should be specific about being specific. In my mind good questions detail both the purpose and methodology of the code ...


11

Let's focus on getting important ideals of the site across to potential new users. We expect the code to work, and we expect it to be yours to share. Code Review is a question and answer site for seeking peer review of your code. It's built and run by you as part of the Stack Exchange network of Q&A sites. We're working together to improve the ...


11

You're absolutely right; that header doesn't make sense. This does indeed only apply to questions without answers, which can be edited freely without violating this policy. I'll make this change to that header in the Help Center. Bearing this in mind, feel free to edit your question until it does get an answer.


10

The Help Center page and its deficiencies and more What questions can I ask about here? Code Review is a question and answer site for seeking peer review of your code. We are working together to improve the skills of programmers worldwide by taking working code and making it better. If you have a working piece of code from your project and are ...


10

The Help Center page and its Deficiencies and then some more What should I do when someone answers my question? The first thing you should do after reading someone's answer to your question is vote on the answer, like any user with sufficient reputation does. Vote up answers that are helpful, and vote down answers that give poor advice. Other users ...


10

The Help Center page and its Deficiencies How do I write a good answer? Thank you for taking the time to contribute an answer. It’s because of helpful peers like yourself that we’re able to learn together as a community. Here are a few tips on how to make your answer great. What goes into an answer Every answer must make at least one insightful ...


10

What should I do if no one answers my question? If no one answers, try The 2nd Monitor? Maybe the question is too vague, too confusing, too complicated, or just happened to fall through the cracks. In any case, mentioning it in the chat room can help.


10

Stack Overflow's Help Center also has a "What's Beta?" page. It's a generic page that is present on all sites, and doesn't mean anything about our status. I don't think it's that harmful to leave it there, but if you want, you can point this out on Stack Exchange meta.


10

My simple solution would be to add a third header after the "Do not add an improved version of the code", like so: Instead... and then show the list.


10

Two words: Intellectual Property. If it's not your property it is unethical to submit it for review. Hence the exception for maintainers.


10

Onto the core of your question: It seems to be a manifestation of the larger problem, namely the vagueness of to the best of the author's knowledge clause. When an author admits the problem we are happy to close (and downvote) the question; when the author does not, we keep going even if the bugs are gaping, and the code couldn't possibly work (see e.g. ...


9

https://codereview.stackexchange.com/help/tagging Regarding tagging... Each question may only contain 5 tags at a maximum, so choose the ones that best describe your question. "Please fix my duplication" -> duplication Could we change this to "that best describe what your code is about." This strangely seems conflict with beginnerperformancetime-limit-...


9

I think part of the problem is that people that only take a quick look at the page will find "Trouble-shooting, debugging, or understanding code snippets" under a bold heading that says "What topics can I ask about here?". I suggest we change it to something more... explicit. Something like this: What topics can I ask about here? Code ...


9

The Help Center page and its Deficiencies How do I ask a good question? Asking a question that is well-received by the community will get you more upvotes and quicker answers. Here are some tips for asking a successful question. Be on-topic Do not ask questions about broken code, hypothetical code, or non-existent code, as such questions will be ...


9

How do I write a good answer? This paragraph is a non-sequitur (for any site, not just Code Review): Pay it forward Saying “thanks” is appreciated, but it doesn’t answer the question. Instead, vote up the answers that helped you the most! If these answers were helpful to you, please consider saying thank you in a more constructive way – by ...


9

I make all my answers personal. Please don't make me delete all my answers! Making an answer personal doesn't make the answer contentious. Neither of the following are contentious: 'I think using a generator over a list could be better here', 'Your code doesn't adhere to PEP8, Pythons style guide.' It's also easy to be contentious without being personal: "...


9

I agree. That small change in wording will make a significant difference, but the part about "for your specific project" makes it a little unclear. I would recommend the change... From: Best practices and design pattern usage To: Application of best practices and design patterns


7

A question asking to turd-polish deliberately golfed or obfuscated code would violate the intent of the Good-Code Rule, and, by my interpretation, it would violate the letter of the rule as well. If the code that is posted for review is deliberately obfuscated, then it was not written with the intention of being "good" code. The standard I would use is, ...


7

What types of questions should I avoid asking? Much of the text is irrelevant or inaccurate for Code Review. In my opinion, the whole page needs to be rewritten. You should only ask practical, answerable questions based on actual problems that you face. Chatty, open-ended questions diminish the usefulness of our site and push other questions off the ...


7

Here is a proposal for the sidebar text. How To Ask Improve code that you wrote or maintain, through peer review. Your question must contain code that is already working correctly, and the relevant code sections must be embedded in the question. Please avoid stripping out key details that may be relevant to the review. If your code is ...


7

I agree that this is a bad rule. First, I reference the wiki for best-practice (emphasis of mine). Best-practice questions generally involve a short excerpt of code with a question of general interest, usually focused more on maintainability concerns than the algorithm to solve the task at hand. Note that questions must include a real code excerpt ...


6

This is not an answer, but a talking point about whether this is on, or off topic Version 1: (off-topic - asking for code to be written) What is the best practice regarding synchronization? I have this class that works really well, but I need to make my application multi-threaded. I have read that synchronization can help. What are the best ...


6

I think that one of the things that this rule was meant to avoid is questions that are primarily opinion-based. Many of these primarily opinion-based are asking something like "What is the best (practice) and why?". Considering that there is a separate close reason for "primarily opinion-based", the on-topic rule about "best practice" doesn't apply much here ...


6

The Help Center page and its Deficiencies What are tags, and how should I use them? A tag is a word or phrase that describes the topic of the question. Tags are a means of connecting experts with questions they will be able to answer by sorting questions into specific, well-defined categories. Tags can also be used to help you identify questions that ...


6

The Help Center page and its Deficiencies What should I do if no one answers my question? First, make sure you’ve asked a good question. To get better answers, you may need to put additional effort into your question. Edit your question to provide status and progress updates. Document your own continued efforts to answer your question. This will ...


6

The page explains things that no longer apply to the site. It explains what beta is and how the process works for sites that are still proving that they have value. Code Review the latter half hasn't really been relevant for CR as it was pre-approved for graduation long ago, and the other half is no longer relevant since nowhere says "beta" any more. I'd ...


Only top voted, non community-wiki answers of a minimum length are eligible