25 votes

Is code ever clean enough? - Can there be too many follow-up questions?

The problem is not the number of follow-up questions. The problem is the rate of posting them. If you post a follow-up once a week, probably nobody will even notice. As long as it's well done, for ...
janos's user avatar
  • 111k
20 votes
Accepted

Should I give credits to reviewers when I post revised code?

Sure, giving credit is always a good idea, to satisfy legal obligations, for academic honesty, and just out of courtesy. The exact form in which you choose to give credit is up to you, to be decided ...
200_success's user avatar
15 votes

Is code ever clean enough? - Can there be too many follow-up questions?

The only logical point at which a follow-on process becomes too much, is when the code becomes a duplicate of previously posted code. Follow-On questions are important on this site, they add a lot of ...
rolfl's user avatar
  • 97.3k
15 votes

Is code ever clean enough? - Can there be too many follow-up questions?

On the same day? Depends on the substance of the question and of the answers received, but as a general rule of thumb I'd say... one... but that can't be carved in stone: it depends™. There simply ...
Mathieu Guindon's user avatar
14 votes

Is code ever clean enough? - Can there be too many follow-up questions?

Can there be too many follow-up questions? Considering that some follow-up questions can get massively down-voted, I think the answer is Yes, there can be too many follow-ups (at least in a certain ...
Simon Forsberg's user avatar
13 votes

Is code ever clean enough? - Can there be too many follow-up questions?

Thought I'll chime in here as the other answerer in the downvoted revision 5 question... To be frank, I was hesitant about answering that revision initially, as I do not know if another answer is ...
h.j.k.'s user avatar
  • 19.2k
10 votes
Accepted

How long should we wait before asking for an iterative review?

Is there any system we can use if we don't yet have that intuition? Sure. We can share and reverse-engineer a bit of our intuition to create a system. A bunch of rules-of-thumb, so to speak. The ...
Mast's user avatar
  • 13.1k
8 votes
Accepted

How many questions with same script can I ask, if code not only merged reviews but adds new functionality

How many questions with same script can I ask, if code not only merged reviews but adds new functionality? If it has new functionality (or even when it doesn't but it has been rewritten significantly ...
Mast's user avatar
  • 13.1k
7 votes

Should I give credits to reviewers when I post revised code?

Should I actually give credits to the reviewers who contributed to the new version? Yes. If we look at the bottom of this Stack Exchange page, we have the footer: site design / logo © [year] Stack ...
Peilonrayz's user avatar
  • 42.7k
6 votes

Could Code Review also serve as a code repository?

No (kinda) It's not okay to edit revisions of code into questions, because someone's review for revision 1 will be irrelevant for future revisions. This is called answer invalidation, and is something ...
Quill's user avatar
  • 11.9k
5 votes

Iterative platform for Code Review

It's hard for me (even as a regular user of Code Review) to evaluate this proposal, because it doesn't explain what the problem is. What exactly is the trouble that would be avoided by this proposal? ...
Gareth Rees's user avatar
  • 49.6k
5 votes

How can I post updates/implementation of changes after a code review?

You will find the answer to most of you questions in this almost duplicate discussion. Should I edit the original question, should I post the update as an answer or what? Never, ever edit the code ...
janos's user avatar
  • 111k
4 votes

How can I post updates/implementation of changes after a code review?

Should I edit the original question, should I post the update as an answer or what? Editing the original question after you have received answers to show updated code isn't allowed by our site ...
Heslacher's user avatar
  • 50.3k
1 vote

Do I edit my question based on answers?

I do see mention of 'iterative' code reviews, which I assume refers to "post, receive answer(s), edit, answers updated" type questions. An iterative review is multiple questions on the same problem. ...
mdfst13's user avatar
  • 21.4k
1 vote

Do I edit my question based on answers?

No, because editing the question by integrating answers would invalidate the answers.
Heslacher's user avatar
  • 50.3k
1 vote

Is code ever clean enough? - Can there be too many follow-up questions?

Why would a user direct his attention to an earlier rev of a question when that was marked with an accepted answer and linked to an open "follow-up"? Either desist in chasing the update links and ...
Maroloccio's user avatar
1 vote

How to post a follow-up question?

Everything that Simon wrote. Additionally, you can help readers of the original question find your improved version: Include a link to the original question. This will ensure that each question ...
Toby Speight's user avatar
1 vote

Can we have collapsible code blocks?

I can only see a couple of pros and cons to this: Pros: Reduce question size, this causes users to not be as daunted by questions with lots of code blocks. Allows reviews to read only the question ...
Peilonrayz's user avatar
  • 42.7k

Only top scored, non community-wiki answers of a minimum length are eligible