150 votes
Accepted

For an iterative review, is it okay to edit my own question to include revised code?

You have several options for follow-ups: Accepting an answer If one of the answers gives you good advice with clear directions for improving your code, just accept the best answer and upvote any ...
23 votes

Is code ever clean enough? - Can there be too many follow-up questions?

The problem is not the number of follow-up questions. The problem is the rate of posting them. If you post a follow-up once a week, probably nobody will even notice. As long as it's well done, for ...
user avatar
  • 107k
20 votes
Accepted

Should I give credits to reviewers when I post revised code?

Sure, giving credit is always a good idea, to satisfy legal obligations, for academic honesty, and just out of courtesy. The exact form in which you choose to give credit is up to you, to be decided ...
user avatar
15 votes

Is code ever clean enough? - Can there be too many follow-up questions?

The only logical point at which a follow-on process becomes too much, is when the code becomes a duplicate of previously posted code. Follow-On questions are important on this site, they add a lot of ...
user avatar
  • 96.7k
14 votes
Accepted

Navigating between question-answers parts

I think you are thinking of the iterative process for an entire production size application, that is not what we do on Code Review. If the process goes farther than like 10 iterations, it's a very ...
user avatar
  • 28.5k
13 votes

Is code ever clean enough? - Can there be too many follow-up questions?

On the same day? Depends on the substance of the question and of the answers received, but as a general rule of thumb I'd say... one... but that can't be carved in stone: it depends™. There simply ...
user avatar
13 votes

Navigating between question-answers parts

The answer to the first part of your question I think should be: As many as you need. However.... be reasonable. You can't ask a follow-up to an unanswered question. You shouldn't ask a follow-up ...
user avatar
  • 25.2k
12 votes

Harmless duplicate or are we being taken advantage of?

Well, whatever it is, it is certainly not a duplicate. The follow-up question asks about the proper use of divs and spans; the original question contains no spans. I agree that it is rude to ask a ...
user avatar
12 votes

Is code ever clean enough? - Can there be too many follow-up questions?

Can there be too many follow-up questions? Considering that some follow-up questions can get massively down-voted, I think the answer is Yes, there can be too many follow-ups (at least in a certain ...
user avatar
12 votes

Is code ever clean enough? - Can there be too many follow-up questions?

Thought I'll chime in here as the other answerer in the downvoted revision 5 question... To be frank, I was hesitant about answering that revision initially, as I do not know if another answer is ...
user avatar
  • 19.1k
10 votes
Accepted

How long should we wait before asking for an iterative review?

Is there any system we can use if we don't yet have that intuition? Sure. We can share and reverse-engineer a bit of our intuition to create a system. A bunch of rules-of-thumb, so to speak. The ...
user avatar
  • 12.6k
8 votes

Does there exist any conditions for closing iterative review questions as duplicates?

More or less, I'm of the thought that the answers the asker receives takes care of this. There are cases where users are actively adding additional features and it makes sense if it all leads to a ...
user avatar
  • 9,779
8 votes
Accepted

How many questions with same script can I ask, if code not only merged reviews but adds new functionality

How many questions with same script can I ask, if code not only merged reviews but adds new functionality? If it has new functionality (or even when it doesn't but it has been rewritten significantly ...
user avatar
  • 12.6k
7 votes

Harmless duplicate or are we being taken advantage of?

If I remember correctly, the user in question posted a very similar question within 24 hours before that one, and removed it after 15 mins when it received only 2 comments, one from me linking to the ...
user avatar
  • 3,002
7 votes

Should I give credits to reviewers when I post revised code?

Should I actually give credits to the reviewers who contributed to the new version? Yes. If we look at the bottom of this Stack Exchange page, we have the footer: site design / logo © [year] Stack ...
user avatar
  • 41.6k
6 votes

Could Code Review also serve as a code repository?

No (kinda) It's not okay to edit revisions of code into questions, because someone's review for revision 1 will be irrelevant for future revisions. This is called answer invalidation, and is something ...
user avatar
  • 11.8k
5 votes

Iterative platform for Code Review

It's hard for me (even as a regular user of Code Review) to evaluate this proposal, because it doesn't explain what the problem is. What exactly is the trouble that would be avoided by this proposal? ...
user avatar
  • 49.1k
5 votes

How can I post updates/implementation of changes after a code review?

You will find the answer to most of you questions in this almost duplicate discussion. Should I edit the original question, should I post the update as an answer or what? Never, ever edit the code ...
user avatar
  • 107k
4 votes

How can I post updates/implementation of changes after a code review?

Should I edit the original question, should I post the update as an answer or what? Editing the original question after you have received answers to show updated code isn't allowed by our site ...
user avatar
  • 49.9k
4 votes

Harmless duplicate or are we being taken advantage of?

Perhaps I'm late to the party, but just looking at the code, these two questions don't appear to be duplicates at all. The code is quite clearly different (and Code Review doesn't have quite exactly ...
user avatar
  • 25.2k
4 votes
Accepted

Asking for comparison of design of two code snippets giving same functionality

Provided that the code is already on-topic, and you're still seeking actual reviews (not "which of these is better?" or anything like that), multiple code blocks can be reviewed in a comparative ...
user avatar
  • 34.7k
3 votes

For an iterative review, is it okay to edit my own question to include revised code?

I came here because of The moderators have had a discussion, and we are proposing new guidelines for posting follow-up code. Specifically, we would like to end the practice of letting the OP append ...
2 votes

Versioning code and visualizing diffs in code review

Just a thought: Assuming if we solve the 'question' side of identifying multiple iterations of a code review, how should answers be referenced back to the particular iteration then? By an anchor link ...
user avatar
  • 19.1k
1 vote

Do I edit my question based on answers?

I do see mention of 'iterative' code reviews, which I assume refers to "post, receive answer(s), edit, answers updated" type questions. An iterative review is multiple questions on the same problem. ...
user avatar
  • 20.3k
1 vote

Do I edit my question based on answers?

No, because editing the question by integrating answers would invalidate the answers.
user avatar
  • 49.9k
1 vote

Is code ever clean enough? - Can there be too many follow-up questions?

Why would a user direct his attention to an earlier rev of a question when that was marked with an accepted answer and linked to an open "follow-up"? Either desist in chasing the update links and ...
user avatar
1 vote

How can I ask for a review of the same item after making an update?

When you've asked a question, had feedback, made changes, and are ready for another review, You should post a new question with the updated code, but, link the original review, just for clarity. For ...
user avatar
  • 11.8k
1 vote
Accepted

Authors 'final result' post showing the 'final result' after the answer/corrections/suggestions

Feel free to answer your own question with the final implementation. Noting which answers helped you achieve your final result is acceptable, but sweeping statements like after looking at all the ...
user avatar
  • 12.6k
1 vote

Is asking for code review on a patch file OK?

I think that reviewing patches would be a bad idea. Since answers will likely suggest changes to the code, they will be, in a sense, a patch on a patch, and that would be nasty. I suggest posting ...
user avatar

Only top scored, non community-wiki answers of a minimum length are eligible