What distinguishes Code Review from Stack Overflow?
Different communities have different rules to address different needs. A quick summary:
Questions with a specific goal
Answers can suggest any improvement
Must answer the question
Code must already work as intended
(No such requirement)
Prefers code in ...
Checklist for migration to Code Review
Is the question off-topic on the originating site?
Are you sure? Do not migrate if there is doubt.
Is the question on-topic for Code Review?
The question must contain working code. Code Review is not a
debugging service. Reviewers may discover bugs in the course of
answering, but the code should be generally ...
I've rejected the migration because the presented code appeared to be example code.
Indications of this include:
"I simplified some stuff so that I could make a short code example"
If you see something like that, then it's very likely that the question is off-topic. It seems to be common for others to think that a question always belongs ...
For migrating to Stack Overflow, there are some good guidelines at What topics can I ask about here?. Quoting, specifically:
Stack Overflow is for professional and enthusiast programmers, people
who write code because they love it. We feel the best Stack Overflow
questions have a bit of source code in them, but if your question
a specific ...
Yes, shortening code by reducing redundancy is within the scope of Code Review — it naturally falls under the category of general code improvements.
However, migrating a question involves a more complex decision-making process than you described. Please read A guide to Code Review for Stack Overflow users for more information.
For the specific question ...
I'm the one who enabled the migration targets earlier today. I was going to post an announcement here on meta, but some other stuff popped up so I punted it until tomorrow... well, I guess I don't really need to anymore?
It was pointed out to me at the end of last week that CR was still missing migration targets and community ads*, which should have been ...
(the bulk of this answer is plagiarized borrowed from: What is migration and how does it work? - I have taken that and adapted it to focus on Code Review specific concerns)
Migrating to Code Review:
Migration allows a question that is off-topic on one ...
We have a checklist for migration to Code Review.
I didn't find any suitable function, so I made one and wanted some expert opinion on it. Please check the plunkr http://plnkr.co/edit/DNGWLh5cH1Cr1coZbwpa?p=preview . There are problems with animated scroll in FF, so please use Chrome to check the logic.
… and the bounty notice…
My migration checklist, applicable to all sites:
Is it off-topic here? (Remember that being a better fit elsewhere is not a reason to migrate.)
If it's off-topic, does it have potential to become on-topic? (A closed question can be reopened, but recalling a migrated question is trickier.)
Is it on-topic there?
Is it not crap (i.e. ...
How about we wait and see a little?
it's a problem that does not need a solution because it is a tiny problem to start with
Indeed, it's a tiny problem - why make a mountain out of it? The typical code dump "where's my bug?" broken code post is also off-topic on SO. There are much fewer viable migration candidates than off-topic questions we ...
Thanks for taking the time to ask on Meta!
I remember handling that flag. I didn't find the question particularly stellar, but I did notice this:
Is there a better way to add up all 16 uint16s and store the result in an int?
The rest of the question went well above my head, but if it all boiled down to finding a better way to [insert what the code ...
Question which are on-topic on Code Review
What is the best way to motivate posters to move their posts to a better site?
A common pattern on Stack Overflow is closing a question because "the question would be better on Code Review".
Rarely the recommendation is good, most of the time the recommendation is absolutely terrible.
I agree that the question is off-topic on the main site. It is better (though not perfect) on the meta site. The problem is that the post is old, and questions older than 60 days cannot be migrated (and that is what would be needed even between main and meta sites).
So the choice is to either close, delete, lock, or reopen the post.
Locking seems most ...
I gave my rationale in a comment when I migrated the question. Identifiers such as ScriptIAmMaking and test are placeholders akin to foo and bar, making it example code and therefore off-topic for Code Review. Are those identifiers peripheral to the question? I didn't make that distinction at the time, as the question didn't obviously state what code was ...
Since we are still in beta, we don't have full migration capabilities. The only current migration paths are to and from our Meta. At the same time, graduated sites don't have beta sites as migration paths since they are not yet "permanent" sites. This explains why, for instance, SO cannot have us as a migration path at this time, despite the ...
Don't migrate questions that are not suitable Stack Overflow questions.
If a question has been formatted to look like a Code Review question, with lots of code, and lots of text, then it is almost certainly not a good Stack Overflow question.
Stack Overflow questions should typically be small, self-contained code examples, or perhaps no code at all, and ...
Finally, the close-vote privilege is obtained at 500-rep, which is far too low for a site to have migrate-away privileges.
This is the problem I see with having a migration path at all right now. The migration path is a Good Thing(Tm), but giving that tool to users with such a low amount of experience is asking for trouble.
I've said it before, I'll say ...
It was migrated because it contained hypothetical content. This was indicated by the vagueness of the question as well as generic names such as do_something(). Such questions are off-topic as we only review real code with sufficient context. More information about that can be found here.
Update2: A CW-based meta post: My question was closed as being off-topic. What are my options? has been added that addresses the different off-topic close reasons. The Off-topic close reasons have been updated to point to the answers on the above post. The details there can be updated over time as needed.
There are no longer any direct links to either ...
Gareth Rees is correct about it being impossible to migrate directly due to our beta state. Until we graduate, we'll have to continue closing and/or flagging for migration.
I don't see this entirely as a bad thing, though. This will give us the opportunity to get used to knowing exactly which questions belong on SO. Sure, it's already simple enough (not ...
I'd consider it to be a poor candidate for migration, with my main concern being quality. Specifically,
The author didn't bother to write the question clearly. It takes a lot of effort to guess that the two input arrays are numbers and ages, and the output is union.
It's not clear why the union of two arrays would be a String. And what type are the two ...
You could either custom-flag it (if you really think it should be migrated) or just flag as blatantly off-topic if you know it's off-topic. For the latter, the higher-rep users can take care of flagging it for migration if necessary.
As for why your flag was declined (which wasn't done by me), it's probably because it was deemed on-topic due to this ...
You could always delete questions which got migrated to another site, on that site, if they are off-topic or you are getting down-votes. That should not affect your site rep or stats after being deleted, granted you don't have too many of them.
Ideally one should read the on-topic page for a site before posting, but on occasion some unexpected migrations ...
Reading the question I get the feeling that this question is split in two parts:
Review my code, please.
Review my approach (from viewpoint of all programmers), and whether it makes sense.
This question seems to be well-accepted on programmers, but IMO didn't need to be migrated.
Instead the correct approach would have been to comment to OP that reviewing ...
In addition to what @200_success has mentioned, the current bounty should also be canceled so that the question can be closed, and so that the bounty is not wasted on an off-topic question. A moderator flag will take care of that.
Create a meta-question titled "Code Review, Stack Overflow, or Software Engineering"
Make the second part of the OP above an answer to that question; optionally expand/improve it
Add a hyperlink to that topic to the custom close reason(s):
Questions asking for code to be written to solve a specific problem are off-topic here as there ...
For the record, in retrospect, I agree it was a mistake on my part to migrate that question. It's a gimmeh-teh-codez style, crap question, violating our golden rule of "don't migrate crap", period.
In my defense, I'm fairly active on SO these days, and as such, I'm used to seeing a lot of far worse crap, which dulls my crap-sense a little bit, leading to ...