21
votes
Accepted
PSA: Excel going "Not Responding" isn't broken code
If you don't do VBA, you probably don't know this, but most VBA host applications are single-threaded, and when VBA code runs for a long time it's completely normal that the main window's caption says ...
- 75k
20
votes
Are we voting to close too quickly?
If anything, we don't vote to close quickly enough.
An off-topic question can often be fixed. In the meantime, it shouldn't be answered. It helps to close the questions for answers, so they don't get ...
MastMod
- 13.1k
18
votes
Accepted
What to do with Code Only Answer in Low Quality Queue
Deleting a good start to a review seems like a bad idea
Indeed. But you don't delete the post, you vote to delete it. Just do it. And downvote.
You could also come across one such answer outside the ...
- 75k
15
votes
Accepted
Removing leading white space in question code blocks
In general you shouldn't be editing code in the question, but instead reviewing it. But there are at least two cases where it's fine to make an exception:
Where the poster has fumbled the formatting. ...
- 49.6k
15
votes
Are we voting to close too quickly?
The Close-/Reopen system is at least partly predicated on quickly closing questions that are not on topic and quickly reopening those that were edited to be on topic. Let me quote Shog writing on the &...
- 25.2k
13
votes
Accepted
Are we voting to close too quickly?
Not enough people that VTC are leaving helpful comments, or even comments that refer to the How do I ask a good question help page. This answer is in support of @vogel612 answer.
When I come upon a ...
- 23.5k
10
votes
Accepted
How should we handle edits to answers to make code congruent with the language of the question?
Know what you are doing
If you know the language in question just like you know your best friend, then I'd say feel free to edit and correct it.
In this particular case the code was a mix of Python ...
- 59.1k
10
votes
Accepted
Flagging users who select "No Action Needed" in First Posts review queue
As an extended answer to Simon's answer, which I agree with in general, I want to point out that there have been occasions in the past where a user has been bordering on system-abuse in the review ...
- 97.3k
10
votes
Do we want to enable the review auditing feature that discourages robo-reviewing?
No
Audits are a premature solution to a problem that's not particularly bad, and will also be fixed by other solutions "soon".
Currently the reputation needed to participate in the review queues is ...
- 97.3k
9
votes
Accepted
Why was "Get minimum of four and maximum up to a limit" not reopened after the code was fixed?
Thanks for bringing this question to attention.
I have run the program and verified that it indeed produces the expected output given the sample input. I have therefore upvoted and reopened the ...
- 144k
9
votes
Flagging users who select "No Action Needed" in First Posts review queue
I was the one who declined this flag this time. I did this after several hours of no other moderator taking action on it - and I knew that some of the other moderators had seen the question.
There ...
- 59.1k
8
votes
Accepted
"I'm Done" option disabled
That's not a radio button you can ever select. If you edit the question, leave a comment or flag/vote-to-close, it will be selected automatically.
It should've moved up automatically and luckily there'...
MastMod
- 13.1k
7
votes
Accepted
First post appeared on the review queue long time after being asked
Well, it seems like the question had been closed 2 minutes after being asked. It had then be reopened 21 minutes ago.
Check the timeline: https://codereview.stackexchange.com/posts/185169/timeline
- 50.3k
6
votes
Why was "Get minimum of four and maximum up to a limit" not reopened after the code was fixed?
I voted to leave it closed because the revised version removed the problem description that the code was purporting to address. So although the code was updated, it would have earned an "unclear what ...
- 65.3k
6
votes
Accepted
Is there a way to accept a suggested, but rejected, edit?
No.
Once an edit is rejected, it's removed from the review queue and can no longer be accepted.
Of-course, you can simply make the same edit yourself instead. You're the author of the post in ...
MastMod
- 13.1k
6
votes
Adding alternative answer comment to low quality posts queue
When I come across these answers I mark them as This is a different question posted as an answer.
To me that's the best option of the current set - it is not a ...
- 97.3k
5
votes
Accepted
Why did I receive this moderator message?
It appears that for 13 of the 21 reviews have resulted with No Action Needed being selected.
I didn't know this either until a moderator pointed it to me in a private chat room: there is a Meta ...
Sᴀᴍ OnᴇᴌᴀMod
- 27k
5
votes
Accepted
"Find out how review queues work" pop-up even after 1k reviews
Note: the feature is still under development. This answer risks being out-of-date the moment I post it. For up-to-date information, see the MSE post "New onboarding for review queues".
Is ...
MastMod
- 13.1k
4
votes
Accepted
Adding alternative answer comment to low quality posts queue
I'm reasonably sure that the set of review comments is common to the whole Stack Exchange network, so we can't adapt these to Code Review.
My usual approach is just to add a canned comment (using the ...
- 72k
4
votes
Accepted
How to handle a VTC as duplicate that goes the wrong way around?
The problem as I see it is that the Poster created a new question rather than updating the original and getting that re-opened. Is there some way to instruct the poster that it would have been better ...
- 23.5k
4
votes
Incorrect suggested edit review - how to educate users?
Most importantly, you should reject the suggested edit with a good description about why it should be rejected, then you can just hope that other reviewers sees this decision somehow.
As said in the ...
- 59.1k
4
votes
Removing leading white space in question code blocks
Indentation vs conventions
I recently declined the following suggested edit: removing-leading-white-space-in-question-code-blocks.
While the indentation was a good suggestion, the editor took it a ...
- 13.9k
4
votes
Do we want to enable the review auditing feature that discourages robo-reviewing?
Yes
Audits will make reviewers more careful.
Even after the privilege levels are corrected (as they should be on a graduated site), the audits will always have the positive effect of making ...
- 111k
3
votes
Accepted
The "Edit" screen seems to be broken
Code Review uses very original layout comparing to other SE network sites. We had to use quite a lot of CSS hacks to make it looking good. Some of those hacks apparently affected popup module and its ...
- 101
2
votes
Removing leading white space in question code blocks
The general rule is that people should make code look like it does in their IDE. It is common in an IDE for code to appear something like
...
- 21.4k
2
votes
Do we want to enable the review auditing feature that discourages robo-reviewing?
I agree audits sound like a good idea. However, if adding comments on on-topic questions will make the audits fail, I feel the drawback is bigger than the gain and we'll have to look for a better ...
MastMod
- 13.1k
1
vote
How to handle a VTC as duplicate that goes the wrong way around?
This is an example of incorrect handling
I feel people are taking the idea that an OP should be able to improve their off-topic questions too far. To the point where they're only allowed to improve an ...
PeilonrayzMod
- 42.7k
1
vote
Do we want to enable the review auditing feature that discourages robo-reviewing?
Yes
I think having review audits will sharpen our skills for doing good reviews. It will lead to having a closer look at the question/answer before we take action.
IMO this will improve the site'...
- 50.3k
Only top scored, non community-wiki answers of a minimum length are eligible