Podcast #128: We chat with Kent C Dodds about why he loves React and discuss what life was like in the dark days before Git. Listen now.

Hot answers tagged

38

No Personally, I think that they should usually NOT be allowed for questions. This site is about code reviews. Readability is an important issue in code reviews, as are syntax errors. Editing the post is not constructive. It is much more helpful to leave a comment or answer that points out the shortcomings. If the code in the question is edited, other ...


29

What items appear in this queue? Overview: What are the Review Queues? History: New Review Queue: First Posts Help: Review privilege The first question a user asks, and the first answer a user provides, will be automatically added to this queue. First posts may also be added to the 'late answer' queue (if the question was asked a long time ago). What is ...


21

If you don't do VBA, you probably don't know this, but most VBA host applications are single-threaded, and when VBA code runs for a long time it's completely normal that the main window's caption says "(not responding)" until the code completes. THIS IS NOT BROKEN CODE. So please stop downvoting and voting to close Excel/VBA questions as "broken code" ...


20

If anything, we don't vote to close quickly enough. An off-topic question can often be fixed. In the meantime, it shouldn't be answered. It helps to close the questions for answers, so they don't get answered anyway. We actively discourage answering off-topic questions[1][2], but new users don't necessarily know this and others don't necessarily comply with ...


15

Deleting a good start to a review seems like a bad idea Indeed. But you don't delete the post, you vote to delete it. Just do it. And downvote. You could also come across one such answer outside the review queues. Often, this results in [correct] NAA flags. Let's be clear: a code dump is not a review, and therefore not an acceptable answer. However if the ...


15

In general you shouldn't be editing code in the question, but instead reviewing it. But there are at least two cases where it's fine to make an exception: Where the poster has fumbled the formatting. See for example this question, where the poster didn't know how to follow a numbered list with a code block. It's fine to fix this kind of mistake. Where ...


15

The Close-/Reopen system is at least partly predicated on quickly closing questions that are not on topic and quickly reopening those that were edited to be on topic. Let me quote Shog writing on the "purpose of closing": I would like to propose the following four-part sentence as a summary of purpose for closing - and the larger "close / edit / reopen OR ...


13

Unlike Stack Overflow, at Code Review we are interested not only in a solution that works, but a solution that is well expressed as code. Therefore, we review all facets of the code, including whitespace. If you feel that the code in the question is improperly formatted, do not silently edit the question, but rather write an answer that addresses the ...


13

Not enough people that VTC are leaving helpful comments, or even comments that refer to the How do I ask a good question help page. This answer is in support of @vogel612 answer. When I come upon a question that has one or more votes to close but no comments at all I feel that we are doing the poster and the community an injustice. The first person to VTC ...


11

No Audits are a premature solution to a problem that's not particularly bad, and will also be fixed by other solutions "soon". Currently the reputation needed to participate in the review queues is 500 rep. In full sites the reputation needed is 3000 Fixing the problem by introducing review audits is a backward process. The problems in the review queues ...


10

As an extended answer to Simon's answer, which I agree with in general, I want to point out that there have been occasions in the past where a user has been bordering on system-abuse in the review queues just to get badges, etc. If it is clear that someone is "gaming" the system, rather than just someone who is not "optimal", then please bring that to the ...


10

Know what you are doing If you know the language in question just like you know your best friend, then I'd say feel free to edit and correct it. In this particular case the code was a mix of Python and some C-style language, so the edit makes perfect sense and I would have also voted to approve. Think about what the best value for the site is. Don't just ...


9

Thanks for bringing this question to attention. I have run the program and verified that it indeed produces the expected output given the sample input. I have therefore upvoted and reopened the question. I encourage everyone to upvote it as well for the effort that the author has made. I've also found that the question was an undeclared cross-post from ...


9

You did 'the right thing'. The options you list have been considered by me too. The end result of such an answer, I hope would be the following: Downvote (it's not a good answer) Comment (polite - saying it needs more information) Then, one of two things should happen: User improves the answer Answer languishes, and maybe gets deleted. Review Process ...


9

This question was answered on Meta Stack Overflow. It's the total [number of review items]. It doesn't take individual user actions into account at all at the moment. Essentially, asking SE's servers to keep track of each user's number of review items is simply too much load to handle, so the number of review items for all users is cached, displayed, and ...


9

Short answer: Yes, they go through the first post queue. I have seen many posts there where the poster has 101 reputation. Your first post, in fact, was reviewed here


9

I was the one who declined this flag this time. I did this after several hours of no other moderator taking action on it - and I knew that some of the other moderators had seen the question. There are three questions I would like to ask here: Is it an important problem that users choose "No action needed"? Should a moderator inform the user about it and ...


7

Yeah, this one is a bit of a stretch, isn't it? For the moment, please focus on the quality of the answers. I will review the results once the evaluation is over and see if it's going to make sense to run another one, ever. We've disabled future self-evaluations on Code Review to avoid confusion. It really doesn't make much sense to be comparing questions ...


7

Well, it seems like the question had been closed 2 minutes after being asked. It had then be reopened 21 minutes ago. Check the timeline: https://codereview.stackexchange.com/posts/185169/timeline


6

I voted to leave it closed because the revised version removed the problem description that the code was purporting to address. So although the code was updated, it would have earned an "unclear what you're asking" close vote even after the edit. I see it's been edited again since then to restore that vital bit of information. I'd have edited it myself, ...


6

No. Once an edit is rejected, it's removed from the review queue and can no longer be accepted. Of-course, you can simply make the same edit yourself instead. You're the author of the post in question after all.


6

Statistics for each reviewer's recommended actions (or inaction) are available. Moderators should be checking those statistics, but we haven't been actively doing so. The statistics would have revealed the anomaly that you pointed out. Once we spot such problems, we can warn the reviewer, and if necessary, follow up with disciplinary action.


5

The only other thing that I may have done (depending on how long the question had been there after you flagged it) is Down Vote the question or if not entirely worthy of a down vote you could have commented on the question about why you think it is off-topic. I would have also posted the share link in The Second Monitor so that the Mods and the Regulars ...


5

If you've noticed something from a specific user, and they have at least one post, you can flag any of their posts and explain the situation. It's not a big deal on a low-activity site like this, but doing so anyway can keep you anonymous and also give moderators a better starting point.


5

There are three ways an answer gets into the Low Quality review queue: Flagged by a user Flagged by the system based on various quality checks run when the answer is posted Directly added by the system based on a combination of the checks in #2 and various other criteria... Including the post's score. The quality checks used for #3 are pretty weak; there ...


4

I approved the question. For me the question of "too minor" is not about how many characters you changed, but rather how fundamentally you changed the nature of the question. In this case although it was a minor textual change, it was a major change to an important detail of the question.


4

That speed is normal for this site. We are not StackOverflow (and I feel that the speeds for suggested edits on StackOverflow has been increasing lately). I myself rejected your edit as "Too minor" (Other people will probably approve it though). I would suggest that you instead post a comment on the question stating that you believe it's about problem 32 ...


4

If the answer is worth keeping as a comment, flag it for moderator attention. Only moderators have the ability to convert an answer into a comment. Otherwise, just press the Recommend Deletion button. Keep in mind, though, that any remark that points out a concrete fault with the code should be an answer rather than a comment, even if it is short.


4

This must be due to the fact that only mods can edit locked posts. Both the suggested edit and the first review did indeed take place before the lock. I don't believe this is a case of robo-reviewing, either. Anyway, I've reviewed the suggestion myself, so it's now off the queue. As to whether or not this is really a bug, a dev may have to address that.


4

Yes Audits will make reviewers more careful. Even after the privilege levels are corrected (as they should be on a graduated site), the audits will always have the positive effect of making reviewers more careful. That's a very good thing, isn't it? In response to the points in @rolfl's answer: The current reviewers are not doing too badly, all things ...


Only top voted, non community-wiki answers of a minimum length are eligible