Episode #125 of the Stack Overflow podcast is here. We talk Tilde Club and mechanical keyboards. Listen now

New answers tagged

5

Off-topic Code Review requires code. If there is no code then there is nothing we can work off to improve, and so there's no way for us to help. It should be noted that even if you have 'managing code' (via GNU make or Invoke), you may not get the answer you're looking for as we'll try to make that code better. But we may not necessarily make your ...


2

I really want to opine that it's fine. It can be educationally useful, especially for students who might assume these code practice sites are modelling good practice. Nevertheless, it probably is not a strictly valid target because of the authorship requirement. The challenge defines an interface. Interfaces are code. If you're hobbled by a shoddy ...


11

Code Review only allows for reviews of code that is written/maintained by the author. We have that requirement for multiple reasons, including legal (copyright) and moral (to avoid code-shaming). When a question asks to compare the poster's solution against some arbitrary solution found on GitHub, that is a underhanded way to ask for a review of third-party ...


4

I don't see a problem with challenging the questionable requirements of a programming challenge, however, I think the answer should have given priority to the OP's code rather than the silly requirements. I would have organized the answer somewhat differently with the silly requirements after the observations about the OP's code.


20

Is it on-topic to review a challenge's requirements? To the extent that the requirements force bad code, Yes. The core of every question at Code Review is "How can I make this code better?" It is not "How can I solve this challenge?" If the asker has not gotten at least that far already, their question is off-topic here. Therefore every question at Code ...


0

I understand the point the answerer was trying to make, but I feel like challenging the challenge's requirements has one big flaw : The OP cannot use the review to make the code better. The challenge has a very specific context and the question is set in that scope, it's very possible that the OP is already aware that the challenge's requirements are ...


Top 50 recent answers are included