New answers tagged

4

You are kind of missing the point that this whole site Code Review is about code reviews, which is a well-known term for peer review by other programmers. It is not about discussing language features and mechanics. Anyway, your question is almost a perfect match for https://stackoverflow.com. Here is some migration advice for how you can ask it there instead:...


3

To me this is a rather clear case of authorship of code; the spirit of that rule is that you're supposed to come here with a piece of code you've written, to get feedback on any/all aspects. This includes unexpected undefined behavior, yes (but then, where are your test cases?), but also your naming conventions and any other nitpick any reviewer might think ...


1

tl;dr I find your question to potentially be off-topic for Authorship of Code, being obviously broken and 'lacking context'. I don't see much of a link with our rational for AoC as you're not asking us to explain the code. Your code doesn't seem to have glaring issues that'd prevent usage, so isn't broken. At least one user has enough context to see issues ...


1

The code in the question consists solely of a type definition, not even a variable declaration. Without executable code it is impossible to tell if there will be undefined behavior or not. Because of the nature of the code (type definition) and the type name given to it, example_bitfield this code seems to be very hypothetical which would be a valid reason ...


Top 50 recent answers are included