34 votes
Accepted

Should pedantry be discouraged?

The answer that you are referring to has been voted up quite a bit. I'd like to point out that we cannot really predict or influence how the votes go. People tend to upvote stuff that they find ...
200_success's user avatar
26 votes
Accepted

Downvotes on an answer which answers the question

Voting (in either direction) is a very subjective and personal thing. As you've mentioned, you've already had a comment on your answer explaining where one person feels your answer is lacking. ...
forsvarir's user avatar
  • 11.6k
25 votes
Accepted

Should Code Review be a place for discussing sensitive topics?

Since this is an opinion question, here's my opinion answer, the first part wearing my "regular hat" as an individual, and then my "mod hat" as how it impacts me as a moderator. You ask: "Should Code ...
rolfl's user avatar
  • 97.3k
21 votes
Accepted

Must answers be limited to the code only?

No. While alternative implementations without reviewing the code are usually unacceptable, going 'beyond' the code is certainly all-right. Let's give some examples. In security questions, people ...
Mast's user avatar
  • 13.3k
20 votes

Should pedantry be discouraged?

That answer is .... a little special For what it's worth, pedantry is explicitly encouraged on Code Review. It helps find problems in code and makes it easier to maintain. To enjoy writing answers ...
Vogel612's user avatar
  • 25.2k
16 votes

I saw no notification about my answer that was to be deleted

It's very unfortunate that you have not received a notification when the post notice. We (mods) were under the impression that users receive a notification when we do this, but it seems that's not ...
janos's user avatar
  • 111k
16 votes

Should pedantry be discouraged?

No IMO, the only useful criteria for answers is Is it a net improvement? (however small). That answer is useful, not by a huge amount, but still an improvement. The moment you start saying "...
Kaz's user avatar
  • 8,790
15 votes

Why was my edit to fix an answer rejected, even though it was approved by the author?

When you do a suggested edit, the only information besides the edit that is shown to reviewers is the edit reason. Yours was Fixed the answer in regards to the question. This does not indicate ...
mdfst13's user avatar
  • 21.5k
13 votes
Accepted

What is the reason for the downvotes on my answer to "Country Guessing Game"?

I didn't downvote, and I can't say that these are the reasons for your downvotes, but I can critique your answer anyway. You made two main points: Random-number generation. You correctly spotted a ...
200_success's user avatar
13 votes

Should Code Review be a place for discussing sensitive topics?

I completely agree with you - this "answer" makes no attempt to review the code. All it does is attack the problem statement, which was not even written by the author of the question. It provides no ...
Toby Speight's user avatar
  • 74.4k
12 votes
Accepted

Is an answer that doesn't provide any code review, only how to unit test on-topic?

The "on-topicness" for answers is not nearly as clear-cut as for questions (and even that has plenty of grey areas). The very first sentence, on its own, is enough to make it a valid code review: "...
rolfl's user avatar
  • 97.3k
12 votes
Accepted

Why is my self answer being downvoted?

Sorry that you're feeling that your answer is not appreciated, but looking through it, I can understand why it has been downvoted.... your answer does not review your code, it just presents an ...
rolfl's user avatar
  • 97.3k
12 votes

Why was my edit to fix an answer rejected, even though it was approved by the author?

First of all, your edit is totally legit (thank you!), and it should have been approved. The edit was rejected because 2 of 2 reviewers voted so, and by the powers that be (the Stack Exchange ...
janos's user avatar
  • 111k
10 votes
Accepted

Peer review a code review?

As in any academic pursuit, the most interesting answers are ones that lead to more questions! Some of my Code Review answers have also been reposted as questions: Reddit mirror encryption challenge ...
200_success's user avatar
10 votes

Downvotes on an answer which answers the question

Let me give this specific-answer question a specific answer. You say your answer isn't notably different from the other answers. Let's check that against the "facts". For context: Here's my ...
Vogel612's user avatar
  • 25.2k
8 votes
Accepted

Peer review rejects bugfix edit on ground of it being aimed at the author

The correction of the compilation alone, without the junk comment would have been a great edit, appropriate and encouraged. The rejection message is a stock message, and doesn't reflect the real ...
janos's user avatar
  • 111k
8 votes
Accepted

Is StyleCop bad?

The default StyleCop rules do run counter to VS2015's recommended style guide, and you can point that out if you wish. That said, if OP is using StyleCop, it's part of a requirement (and should be ...
Dan's user avatar
  • 3,738
8 votes

Can you have an answer without any code in the question?

The question at hand should be (and is) closed. Off-topic questions should not be answered. It's as simple as that. The answer should never have been written. It has been written by a new, ...
Mast's user avatar
  • 13.3k
7 votes

I saw no notification about my answer that was to be deleted

You were already given a post notice, which was also to provide an explanation on the issue with the answer: We are looking for answers that provide insightful observations about the code in the ...
Jamal's user avatar
  • 34.8k
7 votes

I saw no notification about my answer that was to be deleted

The answer in question showed up in the low quality queue, and is not a good answer in general for Code Review. We expect code to go along with explanations and answers to not just be a code dump. I ...
Dan's user avatar
  • 3,738
7 votes
Accepted

Can an OP add missing keyword(s) to code?

No the question should stay as it is, because not only would this edit invalidate two answers (first, second) but I think we would send the wrong signals as well. It would look like it could be ...
Heslacher's user avatar
  • 50.4k
7 votes

How do we handle answers that pertain solely to other answers?

The post didn't in itself strike me as a commentary on first read, and seemed to somewhat relate to the OP - it even had a positive score! "the answer" confused me I guess; the flag would likely have ...
Mathieu Guindon's user avatar
6 votes

Must answers be limited to the code only?

No. @Mast gave a good example, and his last paragraph is quite correct, I'm just extending the concept a little bit. In a professional software engineering environment code reviews will quite often ...
pacmaninbw's user avatar
  • 23.8k
6 votes
Accepted

Are answers that discuss design/architecture related aspects of an on-scope question valid?

Reviewers are always free to voice concerns about any & all aspects of the code - and since the code is the design, the design is always somewhat implicitly up for review as well. We ask that ...
Mathieu Guindon's user avatar
6 votes

Is an answer that doesn't provide any code review, only how to unit test on-topic?

which gives no code review feedback only how to write unit tests Oh? Please take another look at the result posted in that answer. It's pointing out failing edge-cases in a very constructive (...
Mast's user avatar
  • 13.3k
5 votes

Can you have an answer without any code in the question?

I was the one declining the flag. My definition of "not an answer" might not match what others have. My definition is that if it is an attempt at answering the question, it is an answer. I find it ...
Simon Forsberg's user avatar
4 votes

Can you have an answer without any code in the question?

As I said it before, you should refrain from answering a question that's likely to get closed. But what if somebody did answer? What to do with that? The "not an answer" flag is not a good fit. If ...
janos's user avatar
  • 111k
4 votes

Is StyleCop bad?

IMO, no. If the user has a constraint that, for this particular code, they need to use Stylecop then that's a legitimate reason not to use your advice, but that doesn't make your review any less ...
Kaz's user avatar
  • 8,790
4 votes

Peer review rejects bugfix edit on ground of it being aimed at the author

Leaving the reasonability of rejection as a "reply-to-author edit" aside, I noticed something in your edit: -- SE disallows edits shorter than 6 chars! Grr! This ...
Vogel612's user avatar
  • 25.2k
3 votes

Dealing with "edits must be at least 6 characters long"

You leave a comment, and if you don't get a reaction, you go to the 2nd monitor and ask there. Padding your edit is NOT allowed and gets you an instant reject, because adding that padding is just, ...
Pimgd's user avatar
  • 22.3k

Only top scored, non community-wiki answers of a minimum length are eligible