Podcast #128: We chat with Kent C Dodds about why he loves React and discuss what life was like in the dark days before Git. Listen now.
35

The answer that you are referring to has been voted up quite a bit. I'd like to point out that we cannot really predict or influence how the votes go. People tend to upvote stuff that they find funny. People tend to upvote stuff that is short and easy to understand. Answers that take five minutes to read and ten minutes to understand usually don't get ...


34

Yes, modern suggestions should be allowed on old questions. Initial authorship of code is only part of the software lifecycle. It is quite possible that code that was posted to Code Review years ago is still alive today, and the author might even be interested in maintaining it up to modern standards. Times change, and unmaintained code can "rot". For ...


26

Voting (in either direction) is a very subjective and personal thing. As you've mentioned, you've already had a comment on your answer explaining where one person feels your answer is lacking. Whilst you've posted this question, you haven't responded to the comment. You may 'totally disagree with the comment', but you've not provided an explanation as to ...


25

Since this is an opinion question, here's my opinion answer, the first part wearing my "regular hat" as an individual, and then my "mod hat" as how it impacts me as a moderator. You ask: "Should Code Review be a place for discussing sensitive topics?" The answer is: NO. Code Review is for reviewing code.... not reviewing social, cultural, political, ...


21

That answer is .... a little special For what it's worth, pedantry is explicitly encouraged on Code Review. It helps find problems in code and makes it easier to maintain. To enjoy writing answers here, IMO a little pedantry is a necessity. yet, the community upvotes it to the #2 answer No that's not quite the case. That answer is a little overvoted ...


21

No. While alternative implementations without reviewing the code are usually unacceptable, going 'beyond' the code is certainly all-right. Let's give some examples. In security questions, people often tend to write their cryptography. That's a bad idea. So it's certainly allowed to point it out. Other times, people are re-inventing the wheel without ...


17

I don't see anything wrong with posted answers with new technology on old posts. Times change and what would have been good advice 2 or 3 years ago might not be the best advice to give today. It is also reasonable to assume that OP just might still be maintaining the code and should be alerted to new alternatives. I think we should be careful about two ...


17

It's very unfortunate that you have not received a notification when the post notice. We (mods) were under the impression that users receive a notification when we do this, but it seems that's not always the case. We'll work with the community managers on that. It's also very unfortunate that you have not received a notification about the deletion of the ...


16

No IMO, the only useful criteria for answers is Is it a net improvement? (however small). That answer is useful, not by a huge amount, but still an improvement. The moment you start saying "Answers should meet some minimum standard of "worthiness" (defined by who, exactly?)" is the moment the site becomes elitist and we drive away most of the user base, ...


15

We can understand your keenness to correct this mistake, but this isn't the way to go about it. You have several options: Participate normally in the site until you have enough reputation (50 points) to leave a comment. (This is your best bet: the mistake has been there since August 2014, so I doubt that many people will be harmed if you leave it ...


15

When you do a suggested edit, the only information besides the edit that is shown to reviewers is the edit reason. Yours was Fixed the answer in regards to the question. This does not indicate that you and the poster of the answer had agreed on this change. So the natural presumption was that you had chosen to make that change on your own. Yes, if ...


14

I think one issue here is that, essentially, the answer breaks down as: I wrote a blog, here it is My blog has relevant information about X My blog has relevant information about Y My blog has relevant information about Z Oh, this one line could be faster in your code. Now, on Code Review, and on Stack Exchange in general, links are allowed if they provide ...


14

Yes The answer doesn't have much information, but the information that is there seems like it provides some useful advice. It could probably use a little editing after being un-deleted. (if that's what happens.) No Look at the above answer. This answer is a copy-paste from that.


14

I completely agree with you - this "answer" makes no attempt to review the code. All it does is attack the problem statement, which was not even written by the author of the question. It provides no value at all (though the final paragraph, about an equivalent and possibly less controversial framing, might make a worthwhile comment).


13

I didn't downvote, and I can't say that these are the reasons for your downvotes, but I can critique your answer anyway. You made two main points: Random-number generation. You correctly spotted a bug: that it is possible to accidentally generate duplicated multiple-choice answers. However, your explanation is misleading: the possibility of coincidences ...


12

I wouldn't say that encrypted answers should be banned, and I also agree with 200_success' comment that I don't think it's worth it to establish a policy for every possible odd situation. However, spoiler tags are preferable instead of encrypted answers. In many cases, I guess it's just the case of the poster not knowing about the other options ...


12

Yes Comments are not considered to be 'permanent'. These comments, in particular, were flagged as being 'obsolete', and 'chatty': I agreed, there was no reason to keep them after your answer had been updated: I love suggestion number 2 - I'm amazed I didn't think of it myself. Suggestion 1 is good too. Could you explain suggestion 3 more? It sounds ...


12

You raise an important issue. From time to time, other answers on a question that you are answering will… contain ideas that you hadn't previous thought of, but agree with Upvote that answer. If you also have some substantial thoughts of your own that have not been mentioned by anyone else, write an answer. mention similar thoughts that you arrived at ...


12

Is it always ok to suggest best formatting practices on code that doesn't follow popular conventions? YES on Code Review, you can review any aspect of the code you want (Do I want feedback about any or all facets of the code?). If you feel the best formatting practices are not being followed, then feel free to comment on it, and suggest improvements. I ...


12

No, answers that just contain code are not acceptable, even if it is a self-answer. I have added a notice calling for an explanation. Related posts: For an iterative review, is it okay to edit my own question to include revised code? Short answers and code-only answers


12

First of all, your edit is totally legit (thank you!), and it should have been approved. The edit was rejected because 2 of 2 reviewers voted so, and by the powers that be (the Stack Exchange software), that's enough to reject a suggested edit. Your next question might be why did those 2 users vote to reject? Only they can answer that. But I'll venture a ...


12

The "on-topicness" for answers is not nearly as clear-cut as for questions (and even that has plenty of grey areas). The very first sentence, on its own, is enough to make it a valid code review: "First the good: your code provides a testable function." Abusive answers, or answers which do nothing more than provide links, or an alternative solution without ...


12

Sorry that you're feeling that your answer is not appreciated, but looking through it, I can understand why it has been downvoted.... your answer does not review your code, it just presents an alternative solution without really indicating why the code in your answer is an improvement on your original code. Code Review answers are expected to review the ...


11

Who reviews the reviewers? Voters do. You have some options for this: Add a comment (if you have the reputation) Downvote (if you have the reputation), and if you downvote it is recommended that you also add a comment. You did the right choice by adding a comment. Given the number of questions and answers on this site, I don't expect everyone to ...


11

First of all, you must never fix a bug in the question just by editing the question. This is Code Review, not GitHub hack fest. (The only possible exception would be obvious trivial whitespace issues due to the author's inability to copy-paste the code correctly into the text box.) If the question specifically asks for help to get the code to compile, fix ...


10

When looking at the 2-minute tour: Code Review is a question and answer site for sharing code from projects you are working on for peer review. In scientific peer reviews, peers are usually not aware of each other. They do their work alone. They suspect/know others are reviewing it as well but they don't know who those others are. At Stack Exchange, it'...


10

The issue here is not that this is spam, it's that it's not a good answer. It's perfectly acceptable to post a link back to your blog, given that it is relevant. As much as I hate to say it, the link is relevant. I'll refer to Limits for self-promotion in answers on meta stack exchange and quote Jeff Atwood. May I promote products I am affiliated with ...


10

Let me give this specific-answer question a specific answer. You say your answer isn't notably different from the other answers. Let's check that against the "facts". For context: Here's my explanatory comment: Your first point is not sourced at all ... I'd say [citation needed]. The second point is a link-only answer, which is discouraged and the third ...


10

As in any academic pursuit, the most interesting answers are ones that lead to more questions! Some of my Code Review answers have also been reposted as questions: Reddit mirror encryption challenge Fastest possible text template for repeated use? 'Tis the season for gift-wrapping Celsius → Fahrenheit conversion table Just a lowly counter that turned ...


9

In addition to @Simon's suggestions (commenting and downvoting), you have two more options: Edit the answer to fix a bug (if you are certain that a small change will take care of the problem) Post a rebuttal as a competing answer. In that case, it would probably pay off to advertise your new answer in chat, since the original broken answer already has so ...


Only top voted, non community-wiki answers of a minimum length are eligible