36 votes
Accepted

New answers on old questions using new language features

Yes, modern suggestions should be allowed on old questions. Initial authorship of code is only part of the software lifecycle. It is quite possible that code that was posted to Code Review years ago ...
user avatar
28 votes
Accepted

Edit dispute - Indentation on questions

There are times when it is obvious that people (new folk?) don't know how the markdown works on Stack Exchange. They take their block of code and paste it in to the edit box (and indent nothing): ...
user avatar
  • 96.7k
23 votes
Accepted

Please provide me feedback on my badly received questions

I wasn't one of the downvoters, so I can only speculate. However, it is site policy to include textual summaries of programming challenges. This policy was actually instated when Project Euler went ...
user avatar
  • 30.7k
22 votes

What to do with bitter disappointment?

"There are no wrong questions." Actually, I believe the phrase is that there are no bad questions, but the thing is, I have to disagree — at least in the context of a question and answer site. The ...
user avatar
  • 25.2k
22 votes
Accepted

Complete code rewrite

For the record, the linked question asks: Is there any better way to do this? I believe that is the question we all want the answer to when posting code here, more or less. Is a question that ...
user avatar
21 votes

Asking questions - including full code

I have my 'pet theory' about Code Review. This is my personal theory, and it is about human psychology, so you will have to take it with some salt..... It goes like this: You post code for review, ...
user avatar
  • 96.7k
19 votes

Are censored URLs considered example code?

Censoring private URLs, usernames, and passwords is completely reasonable, and in no way makes this question example code. The exact URL has no bearing on correctness, readability, efficiency, or the ...
user avatar
19 votes

Should code be forcibly translated into English?

Stack Exchange in general has an English-Only policy. There are some exceptions for language-specific sites (like Stack Overflow in Portuguese). Code Review is not an 'exception' site. It is clear ...
user avatar
  • 96.7k
19 votes
Accepted

Does getting OutOfMemoryError really mean broken code?

In my opinion, programs that run out of memory with large inputs are in the spirit of Code Review (assuming that everything else about the question is OK). Performance and scalability are among the ...
user avatar
19 votes

Should we nuke this post from orbit?

No. We shouldn't nuke it. Not only is it a piece of CR folklore at this point, but it's an on topic question. Just wondering if there was someone out there that could offer help in optimizing my ...
user avatar
  • 30.7k
19 votes

Should answers to clearly off-topic questions be encouraged or discouraged?

No, we shouldn't encourage this. Broken code is broken code, and we're not Stack Overflow. I left this comment on the answer: Please note, questions involving code that's not working as intended, ...
user avatar
18 votes
Accepted

How broken does code have to be to for a question to be closed?

OP doesn't seem to know their code is broken. Perhaps due to insufficient testing, but to the best of their knowledge, the code works and produces the expected output. The "spirit" of the "working ...
user avatar
17 votes

New answers on old questions using new language features

I don't see anything wrong with posted answers with new technology on old posts. Times change and what would have been good advice 2 or 3 years ago might not be the best advice to give today. It is ...
user avatar
  • 30.7k
17 votes
Accepted

Why was my question which contains the code written by me closed as off topic?

The cited reason for the closure is not that it was someone else's code, but that the code looked hypothetical. Normally, function names like foo, ...
user avatar
17 votes
Accepted

My suggested review would suggest not using the code altogether

I personally believe security questions can be answered in such a way. That's because one of the main rules in security is "Don't roll your own". Examples: Generating XKCD passwords Password hashing ...
user avatar
  • 12.7k
17 votes
Accepted

Is this question popularity normal?

The algorithm that makes a question hit the Hot Network Questions (HNQ) list isn't public AFAIK, but it definitely involves views, votes, answers, and a time factor is documented here. Your question ...
user avatar
16 votes
Accepted

Can we review spreadsheet formulas?

Actually, it's not even asking for a review in my opinion. It seems to be directly asking for an alternative, which makes me think that it's SO territory. It is actually asking for "Is there any ...
user avatar
16 votes

Editing in missing #includes

So questions must compile and work, in order to be considered on-topic questions. No. The code must compile and work in author's environment, so that OP isn't asking the CR community to fix their ...
user avatar
16 votes
Accepted

Am I misunderstanding the basis for Code Review?

Your question, as originally written, was marginal for Code Review. As of Rev 6, it is now a fine question. The problems were: Your question had a generic title that did not meet the guidelines in ...
user avatar
15 votes
Accepted

Asking questions - including full code

The code that you want to have reviewed should be included. There are several questions on Code Review containing a whole lot of code, I myself tend to have very much code in my questions, and it's ...
user avatar
15 votes
Accepted

Post Mortems - Episode I: A new hope

I was not a part of this, so this answer is based only on what the OP has shown us. I am afraid that I may catch a lot of flak for this post, but here is how I see things. Part 1: Embedding Code Let'...
user avatar
  • 1,942
15 votes
Accepted

What to do if the asker's code contains bugs?

Fixing non-obvious bugs is part of code review. What this means is that if the OP ran their code and it seemed to work, then such question is on-topic and shouldn't be closed. If you find a bug in the ...
user avatar
  • 24k
15 votes

Isn't this whole site opinion based?

Code Reviews are all opinionated yes, even math is opinionated (occasionally, and for some values of math). Now, if you are seeking a code review, then your question is not opinionted as per the ...
user avatar
  • 96.7k
15 votes
Accepted

What about this SO question renders it unsuitable for migration to CR?

I've rejected the migration because the presented code appeared to be example code. Indications of this include: class SomeClass "I simplified some stuff so that ...
user avatar
  • 34.7k
15 votes

Should there be evidence for a provided reason when a question is put on hold?

No, there should not be. A question can only be put on hold by three means: Five users with 3,000 reputation or more (500 on beta sites) have cast a close vote. A user with a gold badge in one of ...
user avatar
  • 25.2k
15 votes
Accepted

Design for a question about thread abortion and related process

I'm the moderator that cleaned up the 25-or-so comments on your post, and reopened your question after the // do something placeholders were replaced with actual ...
user avatar
15 votes
Accepted

Clarification on close reason

Yea that close-reason is a bit difficult. It's two, maybe three different reasons packed into one. "Authorship of code: Since Code Review is a community where programmers improve their skills ...
user avatar
  • 25k
14 votes
Accepted

Closing a question because the posted code was produced quickly

I was the close voter. After some back-and-forth with the OP, I was eventually able to get the code to run, and I started writing a review, but after a bit I gave up, because the whole program is ...
user avatar
  • 49.2k
14 votes

Why was the question too vague?

I was one of the users that voted to close this question. First and foremost I did this not because the "question" was actually unclear. Basically closing the question as "unclear what ...
user avatar
  • 25k
14 votes

Why was this question closed as off-topic after a bug was discovered by the answers?

I'm one of the users who voted to close. I saw that at least two bugs were discovered, and that made me think the code is severely buggy and therefore troublesome to review. But I saw it wrong. After ...
user avatar
  • 107k

Only top scored, non community-wiki answers of a minimum length are eligible