Skip to main content
17 votes
Accepted

My suggested review would suggest not using the code altogether

I personally believe security questions can be answered in such a way. That's because one of the main rules in security is "Don't roll your own". Examples: Generating XKCD passwords Password hashing ...
Mast's user avatar
  • 13.4k
17 votes
Accepted

Is this question popularity normal?

The algorithm that makes a question hit the Hot Network Questions (HNQ) list isn't public AFAIK, but it definitely involves views, votes, answers, and a time factor is documented here. Your question ...
Mathieu Guindon's user avatar
15 votes
Accepted

Clarification on close reason

Yea that close-reason is a bit difficult. It's two, maybe three different reasons packed into one. "Authorship of code: Since Code Review is a community where programmers improve their skills ...
Vogel612's user avatar
  • 25.2k
14 votes

Why was this question closed as off-topic after a bug was discovered by the answers?

I'm one of the users who voted to close. I saw that at least two bugs were discovered, and that made me think the code is severely buggy and therefore troublesome to review. But I saw it wrong. After ...
janos's user avatar
  • 111k
14 votes

Are questions with undiscovered bugs allowed?

For this particular case, it's a common beginner error, that wouldn't show up during runtime unless the out-of-bounds reads lead to a win because it happened to look like 4 in a row. I've had plenty ...
Cris Luengo's user avatar
  • 5,688
13 votes
Accepted

Why were two very similar questions posted by possibly the same user?

I originally saw the CR version and later saw the SO one. I flagged the latter for migration here, but since the code wasn't exactly the same, I decided not to merge the answers into one and delete ...
Jamal's user avatar
  • 34.9k
13 votes

Are questions with undiscovered bugs allowed?

If you ask yourself: Can you play a game of connect four with their code? And your answer is: Yes, except in some special case - which someone may be unlikely to test. Then no the question ...
Peilonrayz's user avatar
  • 43.4k
13 votes
Accepted

Does a question with (a lot of) OP response to a posted review qualify for a rollback?

The state of the question as seen in https://codereview.stackexchange.com/revisions/214917/6 (before my rollback) literally says "In response to Peter Taylor's answer". It makes the question ...
Simon Forsberg's user avatar
13 votes
Accepted

Why is my self answer being downvoted?

Sorry that you're feeling that your answer is not appreciated, but looking through it, I can understand why it has been downvoted.... your answer does not review your code, it just presents an ...
rolfl's user avatar
  • 97.4k
12 votes
Accepted

Someone plagiarized my question when cross-posting, and now it's locked. How do I unlock it?

Moderators lock questions when they need to cool things down. There's nothing an ordinary user can do about it. This time we just needed some time to figure out what was going on. Since neither ...
Simon Forsberg's user avatar
12 votes
Accepted

Help a new user avoid being off-topic

The problem in your question is that your code looks simplified just for posting it here. Although you state that it is real code, the name ProcessCommand() is a ...
Simon Forsberg's user avatar
12 votes
Accepted

Removing a question I don't like anymore

Just because you can't think of a better option doesn't mean someone else can't. It doesn't make sense to me why you'd close a question because you can't answer it. If you don't think the approach is ...
Peilonrayz's user avatar
  • 43.4k
11 votes

Is stack overflow on-topic for Code Review?

To an extent, yes. In this particular case, no. I don't see a problem with allowing questions that have Stack Overflow Exceptions, provided the code works acceptably on a smaller input set. If we ...
Der Kommissar's user avatar
11 votes
Accepted

Why is "Building a good C++11 template library - compile-time checked enum array" on-topic?

I have long been uneasy about this opinion that interfaces are reviewable. In my opinion, it conflicts with the current site standard, which is that stub code is off-topic. I suppose that it might be ...
200_success's user avatar
11 votes

Not notified of unwanted edits to question

Let's try adressing the questions first and then some more general stuff: Why did I not get a notification that my question received and edit? This MSE post suggests that edits need to meet ...
Vogel612's user avatar
  • 25.2k
11 votes
Accepted

has the site became less welcoming...?

No, the site has not become less welcoming. Code Review users are not out to harm anyone. Rather, we're looking out for the quality of questions on the site. The comments you received were trying ...
200_success's user avatar
11 votes
Accepted

Are questions mostly unrelated to the presented code on-topic?

Existing rules These are covered in multiple questions Question body: Should a post with no specific question(s) imply a general review? Should [programming-challenge] questions require a summary of ...
Peilonrayz's user avatar
  • 43.4k
10 votes
Accepted

Are just data structures enough for a question?

Questions asking to have a database schema reviewed are on-topic. However, without any background information about what the application does, this code cannot be meaningfully reviewed. I recommend ...
200_success's user avatar
10 votes
Accepted

Why is my post still on hold after several edits?

From box below your question Questions containing broken code or asking for advice about code not yet written are off-topic Your question has Try changing top 0 to Bottom 0 for the .text:after and ...
reducing activity's user avatar
10 votes

Major edits made to my question about using a string or array to index object in JavaScript

Thank you for revising the question — Rev 5 is much better as a Code Review question than the original. That said, I hesitate to reopen it, because I'm not 100% sure I understand what you are trying ...
200_success's user avatar
10 votes

A moderator edited my question. I don't like the way it looks now

Let's check the edit diff and see what it's about: title diff ...
Vogel612's user avatar
  • 25.2k
10 votes

Question about "Polymorphic implementation of == with CRTP" on hold as off topic

So, do you think my original post it theoretical? or maybe pseudo-code or hypothetical? do you think it is off topic? Yes, and unclear, since it was lacking a description. In my opinion, it has been ...
Mast's user avatar
  • 13.4k
10 votes

Caesar Cipher in C++

I can see why the question has been closed. It clearly does not work as intended, the author states: So essentially I can encrypt a single word, but not a sentence. The program crashes on me if I ...
rolfl's user avatar
  • 97.4k
10 votes

Caesar Cipher in C++

As I see it, being nice to new contributors means that we give them more friendly guidance on how to make their questions and answers acceptable for Code Review. It doesn't mean that we lower our ...
200_success's user avatar
10 votes
Accepted

Changed question code - what to do?

It somewhat pains me to do this, but as it stands, the question needs to be rolled back. So that's also what I did. As MartinR observed in the comments to your inquiry here, answers to off-topic ...
Vogel612's user avatar
  • 25.2k
10 votes

Forcing detail when none is needed

You have just asked a question on Meta that: has a title that is clear, specific, and concise has an introduction that provides great context, and examples of what your expectations are based on it ...
rolfl's user avatar
  • 97.4k
9 votes
Accepted

Why was "Get minimum of four and maximum up to a limit" not reopened after the code was fixed?

Thanks for bringing this question to attention. I have run the program and verified that it indeed produces the expected output given the sample input. I have therefore upvoted and reopened the ...
200_success's user avatar
9 votes
Accepted

Does the question "Testing current, new or friends firms as max output and least effort" lack code to be reviewable?

The question would be a good question, if the rest is added. Now it can be reviewed, but only shallow. We lack information for anything better. Questions with good context get good answers. Questions ...
Mast's user avatar
  • 13.4k
9 votes
Accepted

How can I flag a post for migration to SO?

Thanks for taking the time to ask on Meta! I remember handling that flag. I didn't find the question particularly stellar, but I did notice this: Is there a better way to add up all 16 uint16s and ...
Mathieu Guindon's user avatar
9 votes

Is it ok to conceal the origin of a programming challenge?

What's relevant is not the origin of the programming challenge, but its actual task. That's what the answer you linked to already states. It's also the primary guideline here. What you describe at ...
Vogel612's user avatar
  • 25.2k

Only top scored, non community-wiki answers of a minimum length are eligible