29
votes
Accepted
Edit dispute - Indentation on questions
There are times when it is obvious that people (new folk?) don't know how the markdown works on Stack Exchange. They take their block of code and paste it in to the edit box (and indent nothing):
...
- 97.3k
19
votes
Should answers to clearly off-topic questions be encouraged or discouraged?
No, we shouldn't encourage this. Broken code is broken code, and we're not Stack Overflow.
I left this comment on the answer:
Please note, questions involving code that's not working as intended, ...
- 75k
17
votes
Accepted
Why was my question which contains the code written by me closed as off topic?
The cited reason for the closure is not that it was someone else's code, but that the code looked hypothetical.
Normally, function names like foo, ...
- 144k
17
votes
Accepted
My suggested review would suggest not using the code altogether
I personally believe security questions can be answered in such a way. That's because one of the main rules in security is "Don't roll your own".
Examples:
Generating XKCD passwords
Password hashing ...
MastMod
- 13.1k
17
votes
Accepted
Is this question popularity normal?
The algorithm that makes a question hit the Hot Network Questions (HNQ) list isn't public AFAIK, but it definitely involves views, votes, answers, and a time factor is documented here.
Your question ...
- 75k
16
votes
Accepted
Am I misunderstanding the basis for Code Review?
Your question, as originally written, was marginal for Code Review. As of Rev 6, it is now a fine question.
The problems were:
Your question had a generic title that did not meet the guidelines in ...
- 144k
15
votes
Accepted
Clarification on close reason
Yea that close-reason is a bit difficult. It's two, maybe three different reasons packed into one.
"Authorship of code: Since Code Review is a community where programmers improve their skills ...
- 25.2k
14
votes
Why was this question closed as off-topic after a bug was discovered by the answers?
I'm one of the users who voted to close. I saw that at least two bugs were discovered, and that made me think the code is severely buggy and therefore troublesome to review.
But I saw it wrong. After ...
- 111k
14
votes
Are questions with undiscovered bugs allowed?
For this particular case, it's a common beginner error, that wouldn't show up during runtime unless the out-of-bounds reads lead to a win because it happened to look like 4 in a row. I've had plenty ...
- 5,178
13
votes
Accepted
Commenting on faulty code
Comments are for that exact purpose - pointing out issues that need clarification in the question, or otherwise need to be addressed. Editing the code is not an option on Code Review. If it was a ...
- 97.3k
13
votes
Accepted
Why were two very similar questions posted by possibly the same user?
I originally saw the CR version and later saw the SO one. I flagged the latter for migration here, but since the code wasn't exactly the same, I decided not to merge the answers into one and delete ...
- 34.9k
13
votes
Are questions with undiscovered bugs allowed?
If you ask yourself:
Can you play a game of connect four with their code?
And your answer is:
Yes, except in some special case - which someone may be unlikely to test.
Then no the question ...
PeilonrayzMod
- 42.7k
13
votes
Accepted
Does a question with (a lot of) OP response to a posted review qualify for a rollback?
The state of the question as seen in https://codereview.stackexchange.com/revisions/214917/6 (before my rollback) literally says "In response to Peter Taylor's answer".
It makes the question ...
- 59.1k
12
votes
One Question Per Question
The size of the post should not be a major consideration. We've had questions about everything from one-liners up to the 64 kB limit.
Rather, the issue is whether there is unity in the question — a ...
- 144k
12
votes
Accepted
Clarification as to why a question was closed as off-topic
When the question was posted, your question was probably perfectly on-topic. However, as sites grow and evolve, their scope and requirements for on-topic questions change.
In this case, it is ...
- 59.1k
12
votes
Does a single shell command constitute reviewable code?
Short answer: Yes.
Longer Answer: As long as it works and all requirements for a request are met I see no reason why not; code length has never been an explicit requirement of any review request.
...
- 9,819
12
votes
Accepted
Someone plagiarized my question when cross-posting, and now it's locked. How do I unlock it?
Moderators lock questions when they need to cool things down. There's nothing an ordinary user can do about it.
This time we just needed some time to figure out what was going on. Since neither ...
- 59.1k
12
votes
Accepted
Help a new user avoid being off-topic
The problem in your question is that your code looks simplified just for posting it here. Although you state that it is real code, the name ProcessCommand() is a ...
- 59.1k
12
votes
Accepted
Removing a question I don't like anymore
Just because you can't think of a better option doesn't mean someone else can't. It doesn't make sense to me why you'd close a question because you can't answer it.
If you don't think the approach is ...
PeilonrayzMod
- 42.7k
12
votes
Accepted
Why is my self answer being downvoted?
Sorry that you're feeling that your answer is not appreciated, but looking through it, I can understand why it has been downvoted.... your answer does not review your code, it just presents an ...
- 97.3k
11
votes
Accepted
Editing code without invalidating answers
I believe that the code added in Rev 5 should be kept, and the question reopened, because:
Rev 5 doesn't invalidate any existing answers.
That revision just added code, and didn't really modify ...
- 144k
11
votes
Is stack overflow on-topic for Code Review?
To an extent, yes. In this particular case, no.
I don't see a problem with allowing questions that have Stack Overflow Exceptions, provided the code works acceptably on a smaller input set. If we ...
- 20.1k
11
votes
Accepted
Why is "Building a good C++11 template library - compile-time checked enum array" on-topic?
I have long been uneasy about this opinion that interfaces are reviewable. In my opinion, it conflicts with the current site standard, which is that stub code is off-topic.
I suppose that it might be ...
- 144k
11
votes
Not notified of unwanted edits to question
Let's try adressing the questions first and then some more general stuff:
Why did I not get a notification that my question received and edit?
This MSE post suggests that edits need to meet ...
- 25.2k
11
votes
Accepted
has the site became less welcoming...?
No, the site has not become less welcoming. Code Review users are not out to harm anyone. Rather, we're looking out for the quality of questions on the site. The comments you received were trying ...
- 144k
11
votes
Accepted
Are questions mostly unrelated to the presented code on-topic?
Existing rules
These are covered in multiple questions
Question body:
Should a post with no specific question(s) imply a general review?
Should [programming-challenge] questions require a summary of ...
PeilonrayzMod
- 42.7k
10
votes
Accepted
Are just data structures enough for a question?
Questions asking to have a database schema reviewed are on-topic. However, without any background information about what the application does, this code cannot be meaningfully reviewed. I recommend ...
- 144k
10
votes
Accepted
Why is my post still on hold after several edits?
From box below your question
Questions containing broken code or asking for advice about code not yet written are off-topic
Your question has
Try changing top 0 to Bottom 0 for the .text:after and ...
10
votes
Major edits made to my question about using a string or array to index object in JavaScript
Thank you for revising the question — Rev 5 is much better as a Code Review question than the original.
That said, I hesitate to reopen it, because I'm not 100% sure I understand what you are trying ...
- 144k
10
votes
A moderator edited my question. I don't like the way it looks now
Let's check the edit diff and see what it's about:
title diff
...
- 25.2k
Only top scored, non community-wiki answers of a minimum length are eligible