12

Sorry that you're feeling that your answer is not appreciated, but looking through it, I can understand why it has been downvoted.... your answer does not review your code, it just presents an alternative solution without really indicating why the code in your answer is an improvement on your original code. Code Review answers are expected to review the ...


10

As I see it, being nice to new contributors means that we give them more friendly guidance on how to make their questions and answers acceptable for Code Review. It doesn't mean that we lower our quality standards or ignore our rules. I believe that the question is off-topic, as originally posted, because it asks for help to fix the code to accommodate ...


10

I can see why the question has been closed. It clearly does not work as intended, the author states: So essentially I can encrypt a single word, but not a sentence. The program crashes on me if I try to input more than one word. How would I go about encrypting a sentence? If the code is intended to encrypt sentences, and it does not encrypt sentences,...


9

It somewhat pains me to do this, but as it stands, the question needs to be rolled back. So that's also what I did. As MartinR observed in the comments to your inquiry here, answers to off-topic questions do not trigger answer-invalidation concerns. But since the question was on-topic when you answered it, this is a case of invalidation and needs to be ...


9

I see 2 questions: Is Jupyter reviewable? Is linkrot a dealbreaker? 1) Yes. 2) Yes. Jupyter is basically annotated Python. A global script cut in pieces. The link can stay as additional context, but anything not embedded in the question itself is not reviewable. With a Jupyter notebook, this means essential parts of the code are missing in the question ...


8

Traditionally, answers to off-topic questions (especially to those questions that are obviously off-topic) are not considered valid answers for the purposes of answer invalidation rollbacks. We'd rather have an on-topic question and inconvenience an answerer than having to roll back the question into an off-topic state just to avoid invalidating an answer. ...


8

We have an existing FAQ that discourages adding updated code. You also should not append your revised code to the question. Posting improved code is an answering activity, not a questioning activity. An example of such a problematic edit is Revision 2 of Optimize vector rotation. While the addendum to the question does not necessarily invalidate ...


8

In the question, you wrote: … so I am not relying on libraries like cats even if they might already provide solutions for what I am doing. That sounds like a good reason for applying the reinventing-the-wheel tag — to let reviewers know that you are deliberately doing something the complicated way, so that they don't post an answer that says "why don't ...


7

Questions can be on-topic and still attract downvotes. The general rule for downvotes is to cast them when: This question does not show any research effort; it is unclear or not useful That's the exact hovertext when you keep your mouse over the downvote arrow. In theory (not in practice), downvotes have nothing to do with a question being off-topic or ...


7

No the question should stay as it is, because not only would this edit invalidate two answers (first, second) but I think we would send the wrong signals as well. It would look like it could be allowed to invalidate answers if one just asks an answerer of the question if he/she is ok with it. This could lead to extensive comments and could weaken the ...


7

In general, comments are ephemeral.... they are not designed to have long-lasting content. Comments are to seek clarification on posts, and point out short term issues. Once the issues are addressed, the comments should be removed. In the case of this specific question, things became a real mess.... in part, because the question started off "broken", and ...


6

OP wants us to "adjudicate" some sort of opinion conflict they have in the comments on a Stack Overflow answer and that's not really something we do here. The only acceptable answers to the framing of the question are opinions. The code itself is not really relevant when answering. As such this question is soliciting opinions and not reviews. Any answer is ...


5

Cracking/Hacking is not a reason for a post to be off-topic, but this specific question has incomplete, and non-functional code, so it's not working as intended, so it is off-topic. I have closed it with that reason. Having said that, if/when the code works, it would possibly be ready to reopen as working code. There is a question answered about these ...


5

Yes, the rollback was justified. While we value both questions and answer posts on Code Review, we have found that answer invalidation (changes to the question that make the answers look wrong or disconnected) causes continuity problems in the Q&A format of the site. As a consequence, we enforce the no-code-edits-after-answers-exist "rule" to provide ...


5

At the moment of writing this, your question is an improperly formatted code dump without explanation of the requirements or the problem you solved with it. We are not magicians, we can't read your mind, so we don't have enough to work with here. The question is not reviewable. That's why it got closed. Is it salvageable? Yes. But you'll have to put some ...


5

Looking at the timechart of the percentage of answered questions on Code Review, there is indeed a declining trend, meaning that it's harder these days than it used to be. This data is gathered from what my chatbot @Duga is gathering every day. Unfortunately this chart only stretches back to ~December 2017, but through chat search you can find more. ...


5

To keep it simple the following are allowed: Your own language - only if we can run it, so you'd need to provide the interpreter/compiler. "reviews of the specific implementation" "test case reviewed" - if you mean unit tests or similar tests and a working program, rather than an example program that highlights the languages features independently. Asking ...


5

A moderator didn't edit your question to add the tag, a normal user did. I did not rewrite anything from the library mentioned earlier or any other library I know, and this statement was supposed to veer of answers pointing out how what I am doing could be done with half the code with a certain library at hand. Then remove the tag, it probably isn't ...


5

Getting it reviewed There are three ways an OP can get the code in the question. These are: Manually copy the code As shown in the linked question, manually copying some of the notebook over to a Code Review question is acceptable and can produce an ok question. Save the history as a plain old Python file A Jupyter notebook is just an IPython shell. The ...


4

https://repl.it/repls/WrathfulYummyTransversal is currently "Offline for maintenance" (which is why it's a good idea for why to include all the relevant code in the question itself). Right now I can't tell if all the code is there or not, but assuming that it is I just read it briefly and noticed "There's no way this can generate a Sudoku puzzle" (Yes, I ...


4

I think that Matt said it best here when he said "readers seeing your post for the first time, don't need to see which part was in the original post, and which parts were added." Granted he was talking about edits to the question that were done for other reasons, But the point is made clear that Stack Exchange sites are not forums and I would take it a ...


4

The problem as I see it is that the Poster created a new question rather than updating the original and getting that re-opened. Is there some way to instruct the poster that it would have been better to fix the original question rather than post a new one? I would also recommend that the original question be deleted. If the original is deleted I will remove ...


4

An answer does not invalidate any other answers. Answers are independent of each other and are responses to questions. (If you are referencing another answer and that answer changes it is up to you to update your answer accordingly.) It seems that the second answer simply adds an alternative approach to the existing answer. The fact that the second answer ...


3

We don't have the tools to help you with your request. If you want to keep the list updated, then creating a GitHub, SourceForge or BitBucket repository will be better equipped for that. Anyone with an account can create a PR and if you set the permissions up, you can get it so anyone can update the list without a PR. You also get additional features such ...


3

Please keep suggestions about the code in answers. Comments are about improving the question in ways that the OP is allowed, and so suggesting changes to the code in comments sends mixed messages that it's ok to change the code. A simple answer containing just the following is allowed. I think you want a cascade effect. This has the benefit that we ...


3

The question is for questions, not for responding to answers. It's sufficiently simple and clear-cut that I have, as Wikipedia puts it, be[en] bold and rolled back to a version of the question which was pretty much just question. (I was tempted to roll back to version 1, but I thought that might be overdoing it). On the more general subject of how to ...


3

Should something be done about the "reasoning" part, that brings no value to the post? Should it be edited out? IMO voting is the way to go here. Editing out the reasoning part won't make the question any better. If I look at the question above the reasoning part I don't see a good question. It reads more like an answer to a question.


3

This question has been answered already, and Vogel is absolutely right, but let's explain it further for posterity's sake. I know you know most of this already, this is for the rest of the internet. There was a bit of misunderstanding about what is and isn't the core of a question. On Code Review, the most important thing is that you want a review on your ...


3

Every 1 in 10 on-topic questions is left unanswered. That's a rough statistic that has been so for a long time now and it's slowly getting worse (as indicated by Simon's answer). Some questions are simply not interesting enough, too hard to answer or slipped through the net for another reason. We can't catch/answer them all. A bounty might work, but not ...


2

See the last section of the Help Center documentation: What does it mean if a question is "closed" or "on hold"? - Why are some questions marked "closed"? Questions are marked [on hold] for the first five days after closure to encourage edits and improvements to the question. If a question is edited by the original poster when it is marked [on hold],...


Only top voted, non community-wiki answers of a minimum length are eligible