We’re rewarding the question askers & reputations are being recalculated! Read more.
32

Editing out ruby from ruby-on-rails is basically equivalent to editing out c# or vb.net from asp.net questions (containing code in the relevant language). In short… it's a stupid idea. Please reject such edits as vandalism / non-improvement. A question concerning RoR code can be reviewed by ruby people, whether they know RoR or not. It's just that RoR ...


26

There are times when it is obvious that people (new folk?) don't know how the markdown works on Stack Exchange. They take their block of code and paste it in to the edit box (and indent nothing): import java.util.Scanner; public class MyClass { public static void main(String[] args) { ///do something here } } Some of those people fix their ...


16

This is one area where the community stance is fairly unanimous. The language tag is the most important. In fact, all questions on Code Review have the language tag. In fairness, the thought behind the perpetrator is likely that it is a more specific subcategory and implies the derived tag. Perhaps they desired an additional tag but five tags is more than ...


16

In short, our rule is that every question must have a language tag. There may be other tags which are redundant or more specific (e.g. python-2.7 or ruby-on-rails), but the language tag is still required.


15

In general you shouldn't be editing code in the question, but instead reviewing it. But there are at least two cases where it's fine to make an exception: Where the poster has fumbled the formatting. See for example this question, where the poster didn't know how to follow a numbered list with a code block. It's fine to fix this kind of mistake. Where ...


15

When you do a suggested edit, the only information besides the edit that is shown to reviewers is the edit reason. Yours was Fixed the answer in regards to the question. This does not indicate that you and the poster of the answer had agreed on this change. So the natural presumption was that you had chosen to make that change on your own. Yes, if ...


12

I often reject such edits, albeit with a different reason. The code posted by OP is how OP wrote it. It's the code he wants reviewed. Lacking decent indentation is something often pointed out in a review. This being edited away by somebody else than OP is against his intent and shouldn't happen on Code Review. Editing it away before it gets reviewed does ...


12

First of all, your edit is totally legit (thank you!), and it should have been approved. The edit was rejected because 2 of 2 reviewers voted so, and by the powers that be (the Stack Exchange software), that's enough to reject a suggested edit. Your next question might be why did those 2 users vote to reject? Only they can answer that. But I'll venture a ...


11

The whole issue of editing posts is currently being discussed at a Stack Exchange 'site wide' level. Just hours after this question as asked, Stack Exchange introduced the second of potentially many new features and processes in the Suggested Edit workflow (I consider the first to be the auto-convert-to-wiki process of many-times-edited posts being removed)....


11

The Edit Review queue is notorious for people making mistakes in the process. The problem is almost entirely related to the fact that answer edits are much rarer than question edits. Code Review has unfortunately got a lot of robo-reviewers in this queue, people who see a code edit - and auto-reject - without first checking whether the code is part of an ...


10

Should you edit some else's code in a question? Almost never. If the code is poorly indented, state so in an answer. Whitespace is a reviewable aspect of the code. If the code is written in a language where whitespace is significant, and the code is incorrectly indented, then vote or flag to close the question as broken code. If braces are mismatched, ...


10

I didn't reject your edit, but I would have rejected it too. Naming is hard, but the variable name shows the intent for the variable. Simply put, changing the variable name changes the real meaning of the variable. Say we had a list named array. If you came along and dictatorially changed it to list, as "it's a list", it could lose some of the meaning ...


10

Reviewers are indeed various degrees of pedantic, so this question isn't completely crazy. Using the correct words in proper context ensures that we can be understood, and that is the goal of all communications: that the receiver processes the information the way the emitter meant it to be. In the case of parameters vs arguments, my understanding is that a ...


10

Know what you are doing If you know the language in question just like you know your best friend, then I'd say feel free to edit and correct it. In this particular case the code was a mix of Python and some C-style language, so the edit makes perfect sense and I would have also voted to approve. Think about what the best value for the site is. Don't just ...


8

The correction of the compilation alone, without the junk comment would have been a great edit, appropriate and encouraged. The rejection message is a stock message, and doesn't reflect the real reason your edit was rejected. As @Vogel612 already said, the rejection is reasonable and correct, simply because the commentary is practically just junk. We ...


8

Yes, it is supposed to happen. An edit is only recorded on an existing post, and it is removed when the post is deleted. The rep with edits cannot be retained, but it'll come back (just like anything else) if the post ever gets undeleted. As @nhgrif has said in the comments, it's only 6 rep points. For someone with your rep count, I doubt it should ...


8

The original text of a post is valuable because it gives us clues as to the background and level of expertise of the poster, and these help us to judge the way we present the review. For example, a poster who is confused about terminology may be a student or beginner, and this could suggest that it would be best to pitch the review at an introductory level. ...


7

Answer edits are great, and improve the answer for everyone! Some kinds of edits are universally good: fixing spelling errors improving formatting improving grammar adding material to back up claims, e.g. links to a styleguide Other kinds of edits ought to be their own answer: discussing aspects of the code that were not covered in the original answer ...


7

At the time of your meta posting, one reviewer had voted to reject your suggested edit, but one vote is not sufficient to finalize the rejection. Your suggested wording for the status is an improvement. I think that this would be more accurate: 1 reviewer has voted on your suggested edit, but up to 3 votes are needed to accept or reject it. I say "up ...


6

Here is the edit in question. OP Chose to reject this with the following reason. This edit does not make the post even a little bit easier to read, easier to find, more accurate or more accessible. Changes are either completely superfluous or actively harm readability. I can't say I agree with OP. It does make it a little bit easier to read, but as Mast ...


6

It Depends My favorite answer to these questions. ;) No matter the scenario, I don't recommend editing the question. The sort of statement you're talking about is part of the definition of "as intended" in the phrase "works as intended". By editing the statement, you're editing the users definition of the intended functionality of the code. So, what ...


6

I have fixed the indentation for this specific question for the following reasons: Without proper indentation, the code is hard to review OP is new, and has only posted 1 question on StackOverflow before this one, which also had bad indentation and required editing by other users. OP had issues with our rules, first having to edit to include the relevant ...


6

No. Once an edit is rejected, it's removed from the review queue and can no longer be accepted. Of-course, you can simply make the same edit yourself instead. You're the author of the post in question after all.


5

As long as the edit looks legitimate (it still makes sense with the question), it should be okay to accept the edit anyway. That way, if it turns out that the edit was not done by the same user, it can easily be rolled back by a moderator. But if it's still rejected, then the OP will have to make the edit with the original account to ensure that it's done. ...


4

I approved the question. For me the question of "too minor" is not about how many characters you changed, but rather how fundamentally you changed the nature of the question. In this case although it was a minor textual change, it was a major change to an important detail of the question.


4

That speed is normal for this site. We are not StackOverflow (and I feel that the speeds for suggested edits on StackOverflow has been increasing lately). I myself rejected your edit as "Too minor" (Other people will probably approve it though). I would suggest that you instead post a comment on the question stating that you believe it's about problem 32 ...


4

Yes, suggested edits require two reviews since the 16th: In response to this, we've bumped up the number of reviews required to approve or reject a suggested edit: Network-wide: two reviews per edit suggestion. Stack Overflow: three reviews per edit suggestion. Moderators can approve suggested edits instantly in cases where an ...


4

This must be due to the fact that only mods can edit locked posts. Both the suggested edit and the first review did indeed take place before the lock. I don't believe this is a case of robo-reviewing, either. Anyway, I've reviewed the suggestion myself, so it's now off the queue. As to whether or not this is really a bug, a dev may have to address that.


4

When you perceive a suggested edit as too minor, consider looking for the rest of the post to see if there were obvious things that could've been improved. Of course, you can accept/reject and improve yourself, but it's not necessary. As this is a suggested edit, users should be taking more time to make sure the post is really improved. If there's nothing ...


4

Well, Stack Exhange just got rid of the "Too Minor" reject button, so my guess is that's out. I am 100% behind getting a reject reason for "Edit changed the code to be reviewed". Almost every time (to my recollection) that I reject an edit, it's because a well meaning person reformatted the code. We reject those edits because formatting is a valid subject ...


Only top voted, non community-wiki answers of a minimum length are eligible