Podcast #128: We chat with Kent C Dodds about why he loves React and discuss what life was like in the dark days before Git. Listen now.
12

Other than extremely minor edits, I think the answer has to be NO. If I've got the capitalization wrong on a case sensitive variable/function/method/class name in one out of the 20 times I used it in the pasted source code, or if I missed a singular semicolon or parenthesis or closing brace in several, several lines of source code, this is a very minor edit ...


11

I think that when this happens, it stops being code the OP "owns or maintains", so we shouldn't allow this.


11

I concur, and agree with its reopening. If you don't have anything to say about the code, you don't have to review it. If you don't like the question, you are free to downvote according to your conscience. If you feel strongly enough about it, you might even vote to close it as "Unclear what you are asking". Personally, I think it's somewhere between "...


9

Thanks for bringing this question to attention. I have run the program and verified that it indeed produces the expected output given the sample input. I have therefore upvoted and reopened the question. I encourage everyone to upvote it as well for the effort that the author has made. I've also found that the question was an undeclared cross-post from ...


6

Thanks for adding the code. On further consideration, though, I think that your question is currently more appropriate for Stack Overflow than Code Review, since you are asking to change the behaviour of the code — fixing a bug, so to speak, with the layout algorithm. There are existing Stack Overflow questions about graph layout algorithms. Some specific ...


6

I, and from what I'm reading, others too, are having significant problems understanding just exactly what the asker wants his code to do. He describes that people normally build webpages via string concatenation, which I can understand to be a problem. So he goes for a node based approach instead, sort of like building an XML tree. ... But then there's ...


6

I voted to leave it closed because the revised version removed the problem description that the code was purporting to address. So although the code was updated, it would have earned an "unclear what you're asking" close vote even after the edit. I see it's been edited again since then to restore that vital bit of information. I'd have edited it myself, ...


6

First I'd like to apologies that you've been put in this horrible situation. Whilst your code was off-topic to start off with, you've tried many ways to get the question to be on-topic. Mostly to be shot down because you supposedly answer invalidated. This is unfair on you, as someone else broke our rules. But you're the one to be punished. This is not the ...


5

it seems that the issue is that you needed to have content in the HTML enough to make it scroll before the button. I have added a stack snippet example that works for me and reopened the question.


4

I agree that it now has (more than) enough context, and that close reason is no longer valid. When it was closed, the question was confusing, and had other context problems. Now that the question is cleared up, I can't see a reason to leave it closed. Note that it went through (and was kept closed) a reopen review queue before the bulk of the clean-up was ...


3

I have seen a number of questions, involving exclusively large code, reviewed in only about 15 lines. The function I posted may be a one-liner, but that doesn't mean it: Is not subject to review Doesn't offer variety of possible improvements regarding the readability or the functionality Is not useful code And yet, it received a pretty good review. Why ...


3

No, mods are not notified about this. When this happens, the question is put into the reopen queue for regular users (and mods). The only case of a notification for a mod would be if, for instance, a single mod closes a question and a user pings them.


3

It happens regularly that the code in the post is broken (or otherwise not ready for review), but the problem is too complex to explain or demonstrate in the limited space afforded by a comment, and needs to be posted as an answer. Here's an example from earlier today, here's another from a week ago, here's a third with a detailed explanation of how to ...


2

See the last section of the Help Center documentation: What does it mean if a question is "closed" or "on hold"? - Why are some questions marked "closed"? Questions are marked [on hold] for the first five days after closure to encourage edits and improvements to the question. If a question is edited by the original poster when it is marked [on hold],...


2

The code in question, although you state it is your code and you maintain it and you have added enough context, is too much obfuscated. In its current form it just looks too much like example code because of all the "things". If you would have used different names like device instead of thing the code would speak for itself and one wouldn't need to read ...


Only top voted, non community-wiki answers of a minimum length are eligible