Winston Ewert
  • Member for 10 years, 11 months
  • Last seen more than a month ago
  • Waco, TX
Is it okay to add someone else's linked code to the question?
Accepted answer
31 votes

I agree with seand, but I'd also point another facet. Why doesn't the poster edit their question to put the code in? They don't want their code in that question, (seand's case) in that case we ...

View answer
Is pseudo-code alright when asking about performance?
Accepted answer
25 votes

No. Our focus is to improve working code. By definition, pseudo-code is not working code. The restriction is (partially) to make sure you've put effort in your code before showing it to us. ...

View answer
Winston Ewert is no longer a moderator?
Accepted answer
22 votes

Yes, I'm no longer a moderator. The deal is that I transitioned from being a grad student to a software engineer in the industry. As a result, I just don't have the same time to devote to being a ...

View answer
Should we help others reinvent the wheel?
Accepted answer
21 votes

Reinventing the wheel can actually be a useful exercise. But letting someone reinvent the wheel when they don't know they are doing it is a problem. Pointing out that a ready-made solutions exists ...

View answer
Is it appropriate to edit excessive line breaks from code?
17 votes

If someone has bad use of newlines in their code, that should be pointed out in the code review. It doesn't make any sense to fix it for them. The whole point is to show them where their code could be ...

View answer
How should a canonical question title be formatted on Code Review?
Accepted answer
16 votes

It seems to me that the only thing that makes any sense in a title is what the code does. The two examples you show were ones that ask for code reviews. But every last question on this site is ...

View answer
Questions that ask for you to e-mail them to get the code
Accepted answer
15 votes

That's clearly not following the FAQ. Code must be posted in the question to be on-topic here. If the poster doesn't rectify it, the question will be closed as off-topic.

View answer
Does my code example need to be compilable/runnable?
14 votes

Post the relevant snippet, link to a code repository for those who want to actually run it. Code is required to be in the question for a number of reasons: To prevent people from asking for reviews ...

View answer
How should one deal with code asking "Is this correct?" when it is in fact correct?
Accepted answer
14 votes

In my view, on Code Review you don't have to give the OP what they wanted. The whole point is to get feedback on your code. That feedback can be about anything. A lot of the time the correct feedback ...

View answer
Are questions about how to further golf a program on-topic here?
Accepted answer
13 votes

Code golfing isn't really what we do. We emphasize making code readable, which is really the opposite of code golfing. Its just not really in the right spirit for us. If the community agrees, I'll ...

View answer
How long is long code
12 votes

I think our policy is that you are allowed to post as much code as you want, so long as it fits in the question. You are encouraged to narrow the focus of your code in the interest of getting better ...

View answer
Why haven't I received my rep back after a bounty?
Accepted answer
12 votes

Keep reading: In any case, you will always give up the amount of reputation specified in the bounty, so if you start a bounty, be sure to follow up and award your bounty to the best answer! ...

View answer
Are comments asking the applications purpose really relevant?
11 votes

We allow posters to bring a wide array of issues with respect to your code. They are not restricted to simply answering the problem as you see it. A good portion of the time, people come here with ...

View answer
Is it appropriate to post 1k+ lines of code?
Accepted answer
10 votes

I'm thinking that 1.2k lines is a probably a bit much. You probably hit a limit on the size of posts before then. In cases where the code is too large, the recommended approach is to post part of the ...

View answer
Code-correctness in the FAQ
Accepted answer
9 votes

Proposed new wording changes in bold: Code Review - Stack Exchange is for sharing code from projects you are working on for peer review. If you are looking for feedback on a specific working ...

View answer
Add tag existing on SO, for which I have rep
9 votes

The point of having you wait until you have enough rep on this site is to make sure that you understand this site before you start creating new tags for it. The appropriate tags here are not the same ...

View answer
Flagging closed questions for deletion
Accepted answer
9 votes

My bad. I should have deleted those questions. You were the first to ever suggest the deletion of these questions and my initial reaction was not to as we've never done it before. I've deleted those ...

View answer
Off topic reason for questions that don't include code?
8 votes

I think adding this as a common close reason is a great idea. Needing to close questions for this reason is pretty common. Suggested wording: Questions must include the code you want reviewed in ...

View answer
Advice for reviewing edits
8 votes

To my mind, the biggest problem is comment like this: // Pi> Just noting that I edited this line too. You can edit someone's answer to improve it, but it should feel like a cohesive answer. If ...

View answer
Why are they 'questions' if this site is primarily for code review requests?
Accepted answer
8 votes

We do not have the ability to display custom UI text on the individual SE sites. The developers could implement it, but that's up to them. Since we are the odd site out, I wouldn't hold my breath on ...

View answer
Add notice to FAQ for (new) users
Accepted answer
7 votes

I really have no objection to adding an entry to the FAQ warning people that good code review is tough. I can't really see how it would hurt anything. I also must agree that good code review is ...

View answer
Should quick fixes to non-working code go into comments only?
Accepted answer
7 votes

Firstly, we moderaters can migrate questions. However, we've been asked only to moderate good questions. What this means is that when someone dumps two pages of code and says "what's wrong with this?" ...

View answer
Getting feedback on functionality and not code
Accepted answer
7 votes

No. I'm pretty sure that's outside the scope of what could be construed as on-topic here.

View answer
Why not codereview.stackoverflow.com?
Accepted answer
7 votes

We are a sibling site of stackoverflow not a daughter site. All of these sites are under the umbrella of stackexchange. Since code review isn't part of stackoverflow, it makes no sense for us to be ...

View answer
Python - Common Improvements
6 votes

Loops In Python you should rarely use while loops or for x in range(n) loops. Python has a wide variety of tools like zip, enumerate, itertools.* to iterate over pretty much anything with a for loop ...

View answer
Would code review be a good place to ask for a review of a presentation?
Accepted answer
6 votes

No. We review code. We don't review anything else.

View answer
At what point is someone asking us to review how they did algorithm X a duplicate of another review?
Accepted answer
6 votes

Firstly, do the same issues with the code exist between the various quick-sort implementations? There are a few issues which do show up repeatedly, for example: Not refactoring the swap logic into a ...

View answer
What can I do if someone is downvoting my answers without explanation?
Accepted answer
5 votes

I've investigated the downvotes and discussed the problem with mods from other sites. The downvote activity was deemed suspicious, but not quite actionable. If you continue to have like problems, use ...

View answer
What if OP has doubts about the code being working?
Accepted answer
5 votes

I think the question is essentially the same idea as this one: Calculate SHA1 hash from binary and verify with a provided hash I think the appropriate review would have been to point out the flaws ...

View answer
My question was closed without any explanation
Accepted answer
5 votes

The FAQ requires that you are posting real code. But yours does not appear to be real code from your project. If we look at your code: Code is given without a class or function GoodClass goodClass =...

View answer