h.j.k.
  • Member for 8 years, 9 months
  • Last seen more than a month ago
Is code ever clean enough? - Can there be too many follow-up questions?
12 votes

Thought I'll chime in here as the other answerer in the downvoted revision 5 question... To be frank, I was hesitant about answering that revision initially, as I do not know if another answer is ...

View answer
Does Code Review systematically prefer the least important code, and what can we do about it?
9 votes

Maybe we need other kinds of incentives... Joke aside, this is one question where Mat's Mug's answer is quite apt. It's not that complex code are systematically ignored, they simply take more time ...

View answer
Burn the [beginner]s
9 votes

Go easy on me. Also, that complicated but unquestionably better approach you were going to suggest? Don't suggest that. Despite being objectively the only right approach, it's too complicated for me, ...

View answer
Justify your review!
7 votes

My take on this is that there's generally three different kinds of advice we can give: The general, language-agnostic logic fixes Like the if (condition) return true; else return false example ...

View answer
What should our elevator pitch be?
6 votes

Reducing technical debt, one review at a time.

View answer
What you do when valuable info is spread equally in more than one answer?
6 votes

Here are two related Meta links: How does accepting an answer work? Which answer should I choose? The bottom line is that you should accept the answer that you found to be the most helpful ...

View answer
Performance checking tools
6 votes

Java jmh JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks written in Java and other languages targetting the JVM. MicroBench Simpler microbenchmarks ...

View answer
Do you have to speak the language to answer the question?
5 votes

Short answer: No. Long answer: While it's true that all aspects of the code are up for review, not understanding the language in question tend to give rise to short, brief answers which may not be ...

View answer
How does SE Code Review differ from a real life code review?
4 votes

Approaching this from another perspective, this also depends on the code review format of choice in real-life (cough): Side-by-side in front of the computer, i.e. an extra pair of eyes Refactor on-...

View answer
Best of Code Review 2014 - Best Title category
4 votes

Who's in the fellowship? When are Frodo, and the rest of the gang, together Original Poster: rolfl In the Spirit of The Hobbit: BoFA... (also, when I saw this on the Hot Questions list, I ...

View answer
What's a Zombie? And what are the many other memes of Code Review?
3 votes

Meme: Floating Point Police™ Originator: JS1 Cultural Height: ??? Background: As a proud member of the Floating Point Police™, I'm issuing you citation for unnecessary use of floating point here....

View answer
Should the "broken code" close reason be reworded?
3 votes

code not written - how come this doesn't fall under the pseudo/hypothetical/stub code reason or the "include code to be reviewed" reason? I certainly wasn't around when these are put up (:p), so I'...

View answer
What is the difference between golfing and reducing code size?
2 votes

Therefore, I am going to have to take certain measures to reduce the size of my code... Correction: you need to minimize the compiled output, i.e. the output that your OS/machine understands, not us ...

View answer
Versioning code and visualizing diffs in code review
2 votes

Just a thought: Assuming if we solve the 'question' side of identifying multiple iterations of a code review, how should answers be referenced back to the particular iteration then? By an anchor link ...

View answer
New answers on old questions using new language features
2 votes

I'll have to go with @rolfl's answer instead of @200_success's. While saying 'initial code authorship is only part of the software lifecycle' is a very nice idealism*, code refactoring by current code ...

View answer
Best of Code Review 2015 - Night and Day category
0 votes

Question: Writing a program to read a maximum of 99 elements in an iteration from a list Relatively simple problem, but the code had major problems with comments and hard-coding. (My) answer started ...

View answer
Best of Code Review 2015 - Night and Day category
0 votes

Question: Sonar remarks make SQL unreadable? This started off as a question about concatenating literal strings and how that can be improved to 'pass' Sonar. (My) answer introduced a builder-like ...

View answer
Best of Code Review 2015 - Night and Day category
0 votes

Question: A little integer parser vs clean code Not hopeless per-se, just a verbose solution to a simple problem from a beginner (we all have to start somewhere, don't we?). (My) answer attempts to ...

View answer
"Always keep the original code intact" - even with no answers?
0 votes

I'll be even more strict and say it's fine to refine the question as long as no answers and comments are provided. Sometimes, people do point out potential bugs as a question-comment, probably ...

View answer