mdfst13
  • Member for 6 years, 8 months
  • Last seen this week
Why are alternative solutions not welcome?
16 votes

Why are alternative solutions not welcome? They are. Note the text: You have presented an alternative solution, but haven't reviewed the code. The problem is not that it shows an alternative ...

View answer
Why was my edit to fix an answer rejected, even though it was approved by the author?
15 votes

When you do a suggested edit, the only information besides the edit that is shown to reviewers is the edit reason. Yours was Fixed the answer in regards to the question. This does not indicate ...

View answer
How much research effort is expected when posting a Code Review question?
13 votes

I don't think that there is a minimum level of code quality that people should have to meet. Other than working of course. Bad code can make for good reviews. And I don't think that the primary ...

View answer
Regarding editing questions
9 votes

The edit with approval system requires three people to participate. There was a decision made in the beginning that three people should not get bogged down in small edits that could be easily ...

View answer
Are questions with undiscovered bugs allowed?
9 votes

I just voted to Reopen. My reasoning: As far as the poster knew at the time of posting, the code worked. The code works for most situations. Two people answered, so the poster can't fix the code ...

View answer
Code Review is getting boring
7 votes

In other words: what can we do about under-supporting/promoting good questions and over-promoting the not so good, attractive or simply bad ones? We could be more aggressive about tagging questions ...

View answer
Help a new user avoid being off-topic
7 votes

In a comment, you wrote: this relatively simplified-looking code is actually a full real function in my program. If you look around the site, you will notice that very few of the questions are ...

View answer
Handling things that seemingly *every* new writer of a language gets wrong
6 votes

Here is a concrete example of how I review a similar problem in C++. Twelve ways that I respond to using namespace std; (twelve as of my writing this, I may write more that will show up in that ...

View answer
Is it allowed to edit code if there is no answer?
5 votes

I tend to agree that you can edit the original question if there are no answers to invalidate. However, you risk the possibility that someone is answering right at that moment. That person would be ...

View answer
Unmodified question looks modified
5 votes

This is what the timeline looks like to me (10k+, not a moderator). The deleted answer shows. Whether <10k users should be able to see this in the timeline so as to explain why the post is ...

View answer
What are the conditions for asking a Wolfram Mathematica question here?
5 votes

The Mathematica site is for helping you when you have questions about how Mathematica works. So if you have a question that can be summarized in a simple sentence like "How do I ..." or "Why does ... ...

View answer
Best of Code Review 2016 - Best Newcomer (answer) category
5 votes

Answer on "Event scheduler in C" by @Herickson. First answer posted March of 2016. Of the most upvoted answers, this is the first one that reviewed multiple aspects of the code rather than making ...

View answer
Can you show me how to apply a specific strategy to my working code to improve it
4 votes

Off-topic Q: "This game works except for when i=0 C: Off-topic sorry I would disagree that this is always off-topic. This is on-topic if the code is only expected to work for positive ...

View answer
Respond to an answer?
4 votes

Should I attempt to answer the questions of the answer (which could lead to an even better answer) To me, the point of the question/answer format is to ask a question and then get an answer. If the ...

View answer
Must the code be "clean"?
4 votes

I generally agree with the first answer, but depending on the comments, people may point out something like "comments that do this indicate that the code is not ready for review." For example, if you ...

View answer
Found a serious bug in my question after posting it
3 votes

As others have already said, the correct answer is to delete it or edit it if there are no answers. (Or delete it, write up the edit, undelete it, and then edit it if the edit would take a long time.)...

View answer
Is it okay for OP to edit to include Benchmarking results?
3 votes

The chief problem is that the code was changed at the same time as the benchmarks. See this revision, which is the one that was rolled back. If the asker wants to post code revisions, the places ...

View answer
Good format to post code for review
2 votes

To answer this specifically Is it acceptable if I post a link to an external repo for cloning Yes, if you do so only as an additional way for people to get the code. Any code that you expect to ...

View answer
Should I award bounties if an answer would receive half anyway?
2 votes

Is it fair not to award the full bounty if an answer is deemed by the community (through voting) to be worthy of receiving it? Two upvotes is not exactly the whole community deeming it worthy of ...

View answer
"Who Wrote This?" and What Do We Actually Consider Authorship?
2 votes

There isn't enough information to say. The requirement is that the poster needs to be the person who can license the code under the cc by-sa 3.0 with attribution required license. Can this person do ...

View answer
Inline review format
2 votes

You should not do this, as screen readers treat code blocks differently from text. Even for people not using screen readers, this leads to a rather odd grammar. Rather than writing out full ...

View answer
Can I have a question "series" for a major project?
2 votes

Yes This has certainly been discussed previously. Not really a duplicate but similar. I'm pretty sure this has been discussed under some other topic. Here it is My code is too long. How do I ...

View answer
Removing leading white space in question code blocks
2 votes

The general rule is that people should make code look like it does in their IDE. It is common in an IDE for code to appear something like namespace FOO { class BAR { BAR() { ...

View answer
If SO had a standard off-topic reason for code review requests, how should it be worded?
2 votes

While I would normally like the idea of reusing existing components, I'm not sure it's appropriate here. Code Review is different from Stack Overflow and our questions are constructed differently. ...

View answer
A moderator edited my question. I don't like the way it looks now
1 votes

Is it correct? Is it actually as type safe as I think? "Is it correct" should never be used in a title here. Titles here should state what the code does. If someone feels that it is not correct, ...

View answer
Can we add a "Meta User" button next to the "Network Profile" button like SO did?
1 votes

Meta is also available under the ? button (help and other resources). My profile on Code Review has a Meta User button. If yours did not, perhaps it was because your account had not posted to Meta?...

View answer
September 2016 Community Challenge
1 votes

This question is about entering in the colors of a Rubik's cube with four squares (2x2) per side. It uses a text interface. I was thinking that we could have a challenge to create a graphical ...

View answer
Reviewing Inexperience vs Reviewing Style
1 votes

public static int AsClamped(int index, int start, int end) { return index < start ? start : index > end ? end : index; } This isn't what appeared in your question. ...

View answer
Do I edit my question based on answers?
1 votes

I do see mention of 'iterative' code reviews, which I assume refers to "post, receive answer(s), edit, answers updated" type questions. An iterative review is multiple questions on the same problem. ...

View answer
A friendly challenge!
-1 votes

To even things up, another possibility would be a two stage deathmatch. The PPCG stage would be normal. Everyone would contribute their bots. It plays to the PPCG strengths of individualized ...

View answer