-
Member for 6 years, 5 months
-
Last seen more than a month ago
-
London, United Kingdom
No code in the question Very easy to test for. If there is not a single formatted full line of code in a question: Code Review questions must include the code to be reviewed in the body of the ...
How does a score card actually help the OP? Telling them their code sucks, without explaining how to improve it, is no benefit to anybody. Telling them how to improve it, by definition, involves ...
Speaking as somebody who joined CR very recently and didn't do a great job finding out all the rules beforehand, I've found the community to be very welcoming. We have relatively few rules, and as a ...
No IMO, the only useful criteria for answers is Is it a net improvement? (however small). That answer is useful, not by a huge amount, but still an improvement. The moment you start saying "...
I feel like anybody posting their code in good faith should be treated respectfully. If somebody appears not to incorporate suggestions into subsequent posts, ask them why. If they aren't being ...
I need to actually take photos (my bad), but thank you to my secret Santa, for the game and the dragons!
EDIT: Thank you for taking the feedback on board. A couple of further recommendations: Just drop the word "challenge" entirely. It doesn't set the right tone. I think you're getting a bit too ...
You wrote the code, you own the code, the code works (so far as you know) so it would be a perfectly On-Topic CR question. Whether you *should* when you've been asked not to is a question of Ethics, ...
What @200_success said. For the particular post in question, I just started at the top, started critiquing the Naming and, well, never even got past the first Sub before I'd already filled a whole ...
As a general rule, we prefer to see: Your full code, unedited, exactly as it appears in your IDE. Code Review has an extended 65,535 character limit. Unless you're getting close to exceeding that, ...
Mat's Mug Surprise! I did actually consider getting you a new keyboard, but figured something that personal should really be left to individual choice. Enjoy the books!
IMO. As long as it's a "good" answer, I won't ding it for being short. I might be less inclined to upvote, but I don't think it's something to be discouraged. That being said, there's (usually) ...
It sounds like a tag that some people might reasonably want to search/filter for, so I think it should be created.
I have long-argued that downvoting Off-Topic questions (as opposed to just voting to close) where the OP appears to simply not know the rules is not the kind of first impression we want to make. ...
IMO, no. If the user has a constraint that, for this particular code, they need to use Stylecop then that's a legitimate reason not to use your advice, but that doesn't make your review any less ...
status-bydesign Logo has been updated to slightly different version. First off, I think it looks great. I do feel strongly that the breaks in the magnifying glass could be more obviously a "c" and ...
IMO, the answer is not a good one because it doesn't actually reference the OP's code at all. If, for the points it made, it highlighted part of the OP's code that did/did not follow them with a ...
The Off-topic version of a Code-Only answer is just that, a Code-Only answer. As long as your answer provides useful review of the OP's code, if you want to illustrate your points by writing your ...
NO Whilst the information they contain has been entirely superseded, they are a part of our site history and I think they should be kept as a matter of record. What problem are they causing that ...
Just a personal opinion, but I wouldn't mind having it post one of each every hour (or maybe 2 hours). One of each because if it's going to interrupt chat, it may as well do it all at once. Every 1/...
Personally, I have always seen the purpose of Code Review as "helping people to write better code". This encompasses a wide range of advice, from specific optimisation questions to broad stylistic ...
To quote the established guide: Simply ask yourself the following questions. To be on-topic the answer must be "yes" to all questions: Is code included directly in my question? (See Make ...