Skip to main content
Code Review

Return to Question

Tweeted twitter.com/StackCodeReview/status/680784638470680576
deleted 2 characters in body; edited tags; edited title
Source Link
Jamal Mod
Jamal Mod
  • 34.9k
  • 2
  • 53
  • 106

I would like some advice before May I post my code for reviewthis Huffman tree program with several files?

I have been working on implementing a huffmanHuffman tree encoding program in c++C++ for a hobby for a while now. I just finished up with the code and, since this is a learning project, I would love to put my code on here for tips and review. However, I want to make sure I'm within what the community here is ok with, especially since I have not used this site before. So I have a couple question before I post my code.

  1. My full code is split across 9 different files. 8 of these are little classes that make the rest of my code easier to work with, and they are each 30-70 lines long. If I give a short explanation of what these classes do, can I leave these out and just post my main.cpp?

  2. My main.cpp file is 386 lines long. Is this too long? About 100 of these lines are just opening files, and error handling, while passing on the actual nitty-grittys on to other lower level functions. Should I exclude them from the post to make it shorter and easier to read, or should I include them to make the call hierarchy more clear?

I would like some advice before I post my code for review

I have been working on implementing a huffman tree encoding program in c++ for a hobby for a while now. I just finished up with the code and, since this is a learning project, I would love to put my code on here for tips and review. However, I want to make sure I'm within what the community here is ok with, especially since I have not used this site before. So I have a couple question before I post my code.

  1. My full code is split across 9 different files. 8 of these are little classes that make the rest of my code easier to work with, and they are each 30-70 lines long. If I give a short explanation of what these classes do, can I leave these out and just post my main.cpp?

  2. My main.cpp file is 386 lines long. Is this too long? About 100 of these lines are just opening files, and error handling, while passing on the actual nitty-grittys on to other lower level functions. Should I exclude them from the post to make it shorter and easier to read, or should I include them to make the call hierarchy more clear?

May I post this Huffman tree program with several files?

I have been working on implementing a Huffman tree encoding program in C++ for a hobby for a while now. I just finished up with the code and, since this is a learning project, I would love to put my code on here for tips and review. However, I want to make sure I'm within what the community here is ok with, especially since I have not used this site before. So I have a couple question before I post my code.

  1. My full code is split across 9 different files. 8 of these are little classes that make the rest of my code easier to work with, and they are each 30-70 lines long. If I give a short explanation of what these classes do, can I leave these out and just post my main.cpp?

  2. My main.cpp file is 386 lines long. Is this too long? About 100 of these lines are just opening files, and error handling, while passing on the actual nitty-grittys on to other lower level functions. Should I exclude them from the post to make it shorter and easier to read, or should I include them to make the call hierarchy more clear?

Source Link
DJMcMayhem
DJMcMayhem
  • 354
  • 1
  • 5

I would like some advice before I post my code for review

I have been working on implementing a huffman tree encoding program in c++ for a hobby for a while now. I just finished up with the code and, since this is a learning project, I would love to put my code on here for tips and review. However, I want to make sure I'm within what the community here is ok with, especially since I have not used this site before. So I have a couple question before I post my code.

  1. My full code is split across 9 different files. 8 of these are little classes that make the rest of my code easier to work with, and they are each 30-70 lines long. If I give a short explanation of what these classes do, can I leave these out and just post my main.cpp?

  2. My main.cpp file is 386 lines long. Is this too long? About 100 of these lines are just opening files, and error handling, while passing on the actual nitty-grittys on to other lower level functions. Should I exclude them from the post to make it shorter and easier to read, or should I include them to make the call hierarchy more clear?