Skip to main content
Code Review

Return to Question

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link
Community Bot
Community Bot
  • 5

I recently asked a questionquestion on CR, and got an interesting suggestion that I'd like to look into. However, due to the class that the method is part of, and me still being green, I'm having a hard time trying to make this work for my whole class. There are 1.2k+ lines in my class. I'd read other meta questions where it was deemed some responses was to "break up the code" for multiple reviews. However, as is in my case, sometimes that won't be helpful. So, would it be appropriate to post an entire class, even if it's more than 1k lines? 2k? At what point do we define excess?

I recently asked a question on CR, and got an interesting suggestion that I'd like to look into. However, due to the class that the method is part of, and me still being green, I'm having a hard time trying to make this work for my whole class. There are 1.2k+ lines in my class. I'd read other meta questions where it was deemed some responses was to "break up the code" for multiple reviews. However, as is in my case, sometimes that won't be helpful. So, would it be appropriate to post an entire class, even if it's more than 1k lines? 2k? At what point do we define excess?

I recently asked a question on CR, and got an interesting suggestion that I'd like to look into. However, due to the class that the method is part of, and me still being green, I'm having a hard time trying to make this work for my whole class. There are 1.2k+ lines in my class. I'd read other meta questions where it was deemed some responses was to "break up the code" for multiple reviews. However, as is in my case, sometimes that won't be helpful. So, would it be appropriate to post an entire class, even if it's more than 1k lines? 2k? At what point do we define excess?

Source Link
PiousVenom
PiousVenom
  • 313
  • 1
  • 5

Is it appropriate to post 1k+ lines of code?

I recently asked a question on CR, and got an interesting suggestion that I'd like to look into. However, due to the class that the method is part of, and me still being green, I'm having a hard time trying to make this work for my whole class. There are 1.2k+ lines in my class. I'd read other meta questions where it was deemed some responses was to "break up the code" for multiple reviews. However, as is in my case, sometimes that won't be helpful. So, would it be appropriate to post an entire class, even if it's more than 1k lines? 2k? At what point do we define excess?