3
\$\begingroup\$

Today we have this close reason:

Code not implemented or not working as intended: Code Review is a community where programmers peer-review your working code to address issues such as security, maintainability, performance, and scalability. We require that the code be working correctly, to the best of the author's knowledge, before proceeding with a review.

I suggest that it gets changed to

Code not implemented or not working as intended: Code Review is a community where programmers peer-review your working code to address issues such as security, maintainability, readability, performance, and scalability. We require that the code be working correctly, to the best of the author's knowledge, before proceeding with a review.

From what I have seen so far here, that is a very common thing to do, and it is also a very important thing to get feedback on.

\$\endgroup\$
7
  • 1
    \$\begingroup\$ Who will see this? What will it improve? Is there a problem you're trying to solve? \$\endgroup\$
    – Peilonrayz Mod
    Commented May 2, 2019 at 7:54
  • 1
    \$\begingroup\$ @Peilonrayz It's not a huge problem. It's just a minor improvement. \$\endgroup\$
    – klutt
    Commented May 2, 2019 at 7:55
  • \$\begingroup\$ Process note: It's not technically possible to edit the custom close reason text. If anything, this would mean adding a new close reason with the new text and removing the old one. \$\endgroup\$
    – Vogel612 Mod
    Commented May 2, 2019 at 14:23
  • 1
    \$\begingroup\$ @Vogel612 How would the difference influence the process? \$\endgroup\$
    – Mast Mod
    Commented May 2, 2019 at 19:44
  • 2
    \$\begingroup\$ One could claim that "readability" is already covered by "maintainability" as code that is hard to read can be tough to maintain. \$\endgroup\$
    – 1201ProgramAlarm
    Commented May 3, 2019 at 1:09
  • \$\begingroup\$ @1201ProgramAlarm all maintainable code is readable but not all readable code is maintainable ;-] I think the suggestion of adding one more word to the list is a good one. \$\endgroup\$
    – t3chb0t
    Commented May 7, 2019 at 7:38
  • \$\begingroup\$ As far as I can tell, one of the things we should be commenting on is readability when we perform a review. Also keep in mind that a lot of the people that come here for reviews are beginners and don't know any better. \$\endgroup\$
    – pacmaninbw Mod
    Commented May 9, 2019 at 12:59

0

Reset to default

You must log in to answer this question.

Browse other questions tagged .