22
votes
Accepted
Asking about code in a pull request to my code base
Thank you for your transparency.
If you had written the PR (or merged it), it would be on-topic.
You already know you'll be rejecting the PR - putting it up for review here would boil down to ...
- 75.1k
20
votes
Accepted
Small portion of reviewable code isn't mine, but credited
Not a problem
If it would be a problem, you wouldn't be allowed to use someone else's libraries either.
That rule is there to prevent people from dumping code that they don't understand and/or 80% ...
MastMod
- 13.5k
17
votes
Accepted
"Who Wrote This?" and What Do We Actually Consider Authorship?
I think the close vote is inappropriate.
The close reason says "author or maintainer".
In this case I think it makes sense to assume that the poster is the maintainer of the cloned code,
especially ...
- 112k
11
votes
Accepted
Is it okay to ask for feedback on code you modified extensively but aren't the original author of?
We don't allow users to post other peoples code for three main reasons: (Described here)
Moral / Polite
Would you take the criticism upon yourself, and not blame the original authors? It's plain rude ...
PeilonrayzMod
- 43.5k
9
votes
Why was my post closed? Was I too critical of the original author or looking for confirmation bias?
You should be more careful who you take advice from. On your Stack Overflow post a user with 156 rep, on Code Review, told you to post here. Then a moderator with 25k rep told you your post would not ...
PeilonrayzMod
- 43.5k
8
votes
Accepted
Review a piece of code bought from someone else
All we know is that the OP bought a script: we know nothing of the license it came with (if any), and we don't know whether the terms of that license allow the OP to modify it, let alone putting the ...
- 75.1k
6
votes
Asking about code in a pull request to my code base
As Mat's Mug has explained, the proposed question is not within the scope of Code Review.
However, you say you already know what's wrong with the code. So why don't you fix it up first and ask for a ...
MastMod
- 13.5k
5
votes
Can I post a question about my own answer to another question that has been criticized?
Yes, if you have suggested code in an answer, it's often worthwhile having it reviewed too. I've done that myself a few times.
Note that when posting the question it should be self-contained (include ...
- 81.7k
3
votes
Is it inappropriate to ask for code reviews on github pull requests?
Code review requests must be self-contained, so merely pointing at the off-site material would be off-topic (as I'm sure you're already aware).
Assuming that you're the maintainer and/or author and ...
- 81.7k
2
votes
"Who Wrote This?" and What Do We Actually Consider Authorship?
There isn't enough information to say. The requirement is that the poster needs to be the person who can license the code under the cc by-sa 3.0 with attribution required license. Can this person do ...
- 21.7k
1
vote
Review a piece of code bought from someone else
Well, the script came with no exact license. In the "terms" file it only states:
Licensing system rules:
A license belongs to a domain / subdomain and not to a person
Each license is ...
- 101
1
vote
"Who Wrote This?" and What Do We Actually Consider Authorship?
I think it should be closed for that reason.
Authorship of code: Since Code Review is a community where programmers improve their skills through peer review, we require that the code be posted by ...
PeilonrayzMod
- 43.5k
Only top scored, non community-wiki answers of a minimum length are eligible