28
votes
Accepted
Code that handles n% of test cases but not all
If the code produces wrong answers for some test cases, then the author is aware that the code is not working correctly as intended, and the question is thus prima facie off-topic for Code Review.
...
- 144k
22
votes
Is asking for a review of boiler plate for a minimal repro okay?
The line between real and hypothetical code is sometimes blurry, but I would consider this code sample to be on the wrong side of the line for Code Review. Code that contains ...
- 144k
20
votes
Accepted
Reviewing Programming Challenge requirements and givens
Is it on-topic to review a challenge's requirements? To the extent that the requirements force bad code, Yes.
The core of every question at Code Review is "How can I make this code better?" It is not ...
- 1,026
19
votes
Accepted
Can I ask for review for something specific without posting too much context?
Strictly speaking, Code Review requires you to post real code from a project that you are working on.
In practical terms, though, any plausible realistic code is acceptable too. If your real project ...
- 144k
18
votes
Accepted
Should I post about my design and architectural concerns on Code Review or Software Engineering?
Short answer: Will you be posting your actual existing, working code? If yes, then I believe Code Review is better.
Our help center does state:
However, if your question is not about a particular ...
- 59.4k
17
votes
Accepted
"Who Wrote This?" and What Do We Actually Consider Authorship?
I think the close vote is inappropriate.
The close reason says "author or maintainer".
In this case I think it makes sense to assume that the poster is the maintainer of the cloned code,
especially ...
- 112k
16
votes
Accepted
Are you allowed to post incomplete programs that you still want reviewed?
The help center helps out:
I'm confused! What questions are on-topic for this site?
Simply ask yourself the following questions. To be on-topic the answer must be "yes" to all questions:
...
MastMod
- 13.5k
16
votes
Are vectorization requests on-topic?
I'm going to come off a bit harsh with this, but wow does that tag need help.
I think that, in the case of vectorization, the tag itself has a lot of problems.
First off, the tag-usage wiki doesn't ...
- 20.1k
14
votes
Accepted
What are the conditions for asking a Wolfram Mathematica question here?
There are a couple of things Code Review wants from a question.
There must be code. (We're not a code writing service)
The code must be in the question. (Not on a third party site)
The code must work ...
PeilonrayzMod
- 43.5k
14
votes
Are questions with undiscovered bugs allowed?
For this particular case, it's a common beginner error, that wouldn't show up during runtime unless the out-of-bounds reads lead to a win because it happened to look like 4 in a row. I've had plenty ...
- 6,237
14
votes
Accepted
Acceptability of questions about checking for race conditions
If you know that your code has a race condition then it is broken. Take it home and fix it then bring it back. If it might have a race condition but you just aren't certain then it certainly falls ...
- 2,330
14
votes
Is a changeset reviewable?
I'm not asking to review the code
This alone dismisses the idea of a meta-review as invalid, for me. We only review code. The OP could easily just post the new code and receive valuable feedback ...
- 65.3k
13
votes
Accepted
I think my code might have a bug, but I am not sure if it actually does, is it broken code?
If that message isn't the intended behavior, and you're looking for a solution to that specific issue, the right thing to do is to post a MCVE that reproduces the problem on Stack Overflow.
If that ...
- 75.1k
13
votes
Are questions with undiscovered bugs allowed?
If you ask yourself:
Can you play a game of connect four with their code?
And your answer is:
Yes, except in some special case - which someone may be unlikely to test.
Then no the question ...
PeilonrayzMod
- 43.5k
12
votes
Accepted
Can I ask to review my ebuild or rpmspec file?
Sure, questions like that would be on-topic. I would consider them similar to makefile and dockerfile questions. We encourage you to post your scripts for review.
- 144k
12
votes
Accepted
Can I include a short story of implementation?
There is an existing mechanism to deal with "I had this specific problem X and fixed it using Y" in the context of the Stackexchange network:
A self-answered question. Since you're describing ...
- 25.3k
12
votes
When are Machine Learning questions on-topic?
I'll replace the "Machine Learning" parts of your question with "code" to keep it simple. After all, that's what it is.
"My code is learning too slow"
But it works, right? If that's the only issue,...
MastMod
- 13.5k
12
votes
Are vectorization requests on-topic?
Specific question
Since I hammer-closed the question, and I added the comment, let me explain the reasoning I had, starting with a hypothetical case:
Hypothetically, someone asks a question: "this ...
- 97.5k
12
votes
Accepted
Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3)
Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3)
Yes, we currently tag questions with python if it runs in a version or both versions of ...
PeilonrayzMod
- 43.5k
12
votes
Accepted
Requesting a comparative review of own code with third-party code
Code Review only allows for reviews of code that is written/maintained by the author. We have that requirement for multiple reasons, including legal (copyright) and moral (to avoid code-shaming).
...
- 144k
11
votes
Is asking for a review of boiler plate for a minimal repro okay?
I've been thinking about this question and I contend that it is indeed on topic.
Now, in general, the second we see a name like FooBar, we hit the close button ...
- 30.8k
11
votes
Accepted
Is it okay to ask for feedback on code you modified extensively but aren't the original author of?
We don't allow users to post other peoples code for three main reasons: (Described here)
Moral / Polite
Would you take the criticism upon yourself, and not blame the original authors? It's plain rude ...
PeilonrayzMod
- 43.5k
11
votes
Accepted
Why is "Building a good C++11 template library - compile-time checked enum array" on-topic?
I have long been uneasy about this opinion that interfaces are reviewable. In my opinion, it conflicts with the current site standard, which is that stub code is off-topic.
I suppose that it might be ...
- 144k
11
votes
Accepted
Are questions mostly unrelated to the presented code on-topic?
Existing rules
These are covered in multiple questions
Question body:
Should a post with no specific question(s) imply a general review?
Should [programming-challenge] questions require a summary of ...
PeilonrayzMod
- 43.5k
11
votes
Accepted
Are responses to specific interview questions on-topic?
My opinion on this issue is that there are many ways for people to get through interviews ahead of other qualified people, it normally comes down to being better prepared for the interview, or being a ...
- 97.5k
10
votes
Accepted
SQL Query Review
A good place to find out about the rules you're asking for is by looking at the sql tag.
The brief description says:
Structured Query Language is a language for interacting with relational ...
- 112k
10
votes
Confusing phrasing of the "off-topic" close reason
Unfortunately I agree with the close reasons. To the best of your knowledge, your code fails the google test cases, therefore it does not work. Just because you don't know what the problem is, does ...
- 97.5k
10
votes
When are Machine Learning questions on-topic?
I think that the nature of the question itself lends to several options. Here are my thoughts based on Simon's examples.
"My Machine Learning is learning too slow"
These would seem to fall into ...
- 20.4k
10
votes
Accepted
Technology review without code
No, such a question would not be suitable here if no working code is included. See What topics can I ask about? for reference.
In fact, I don't think there is a site on the Stack Exchange network ...
- 20.4k
10
votes
Question about "Polymorphic implementation of == with CRTP" on hold as off topic
So, do you think my original post it theoretical? or maybe pseudo-code or hypothetical? do you think it is off topic?
Yes, and unclear, since it was lacking a description. In my opinion, it has been ...
MastMod
- 13.5k
Only top scored, non community-wiki answers of a minimum length are eligible