Skip to main content
28 votes
Accepted

Code that handles n% of test cases but not all

If the code produces wrong answers for some test cases, then the author is aware that the code is not working correctly as intended, and the question is thus prima facie off-topic for Code Review. ...
200_success's user avatar
22 votes

Is asking for a review of boiler plate for a minimal repro okay?

The line between real and hypothetical code is sometimes blurry, but I would consider this code sample to be on the wrong side of the line for Code Review. Code that contains ...
200_success's user avatar
21 votes
Accepted

Is asking about open source code OK?

In a code review, the person doing the code review is the one who should be asking the questions, like: "Why did you put that line of code in there? What does it do?" It's back to front to ask: "Hey, ...
rolfl's user avatar
  • 97.4k
20 votes
Accepted

Reviewing Programming Challenge requirements and givens

Is it on-topic to review a challenge's requirements? To the extent that the requirements force bad code, Yes. The core of every question at Code Review is "How can I make this code better?" It is not ...
benj2240's user avatar
  • 1,026
19 votes
Accepted

Can I ask for review for something specific without posting too much context?

Strictly speaking, Code Review requires you to post real code from a project that you are working on. In practical terms, though, any plausible realistic code is acceptable too. If your real project ...
200_success's user avatar
18 votes
Accepted

Should I post about my design and architectural concerns on Code Review or Software Engineering?

Short answer: Will you be posting your actual existing, working code? If yes, then I believe Code Review is better. Our help center does state: However, if your question is not about a particular ...
Simon Forsberg's user avatar
17 votes
Accepted

"Who Wrote This?" and What Do We Actually Consider Authorship?

I think the close vote is inappropriate. The close reason says "author or maintainer". In this case I think it makes sense to assume that the poster is the maintainer of the cloned code, especially ...
janos's user avatar
  • 111k
16 votes
Accepted

Are you allowed to post incomplete programs that you still want reviewed?

The help center helps out: I'm confused! What questions are on-topic for this site? Simply ask yourself the following questions. To be on-topic the answer must be "yes" to all questions: ...
Mast's user avatar
  • 13.4k
16 votes

Are vectorization requests on-topic?

I'm going to come off a bit harsh with this, but wow does that tag need help. I think that, in the case of vectorization, the tag itself has a lot of problems. First off, the tag-usage wiki doesn't ...
Der Kommissar's user avatar
15 votes
Accepted

Rehash “How secure is my X” cryptography questions

With so many Stack Exchange sites, there is bound to be some overlap of scopes. And that's OK. The important principle to note is that a question being a better fit elsewhere is not a sufficient ...
200_success's user avatar
15 votes
Accepted

They asked me to write awkward code – how did I do?

Should I refrain from answering such questions in the future? You should refrain from answering off-topic questions. This was not an off-topic question. All on-topic questions should be answered. ...
Mast's user avatar
  • 13.4k
14 votes
Accepted

What are the conditions for asking a Wolfram Mathematica question here?

There are a couple of things Code Review wants from a question. There must be code. (We're not a code writing service) The code must be in the question. (Not on a third party site) The code must work ...
Peilonrayz's user avatar
  • 43.4k
14 votes

Are questions with undiscovered bugs allowed?

For this particular case, it's a common beginner error, that wouldn't show up during runtime unless the out-of-bounds reads lead to a win because it happened to look like 4 in a row. I've had plenty ...
Cris Luengo's user avatar
  • 5,688
14 votes
Accepted

Acceptability of questions about checking for race conditions

If you know that your code has a race condition then it is broken. Take it home and fix it then bring it back. If it might have a race condition but you just aren't certain then it certainly falls ...
Summer's user avatar
  • 2,334
14 votes

Is a changeset reviewable?

I'm not asking to review the code This alone dismisses the idea of a meta-review as invalid, for me. We only review code. The OP could easily just post the new code and receive valuable feedback ...
Reinderien's user avatar
  • 62.1k
13 votes
Accepted

I think my code might have a bug, but I am not sure if it actually does, is it broken code?

If that message isn't the intended behavior, and you're looking for a solution to that specific issue, the right thing to do is to post a MCVE that reproduces the problem on Stack Overflow. If that ...
Mathieu Guindon's user avatar
13 votes

Are questions with undiscovered bugs allowed?

If you ask yourself: Can you play a game of connect four with their code? And your answer is: Yes, except in some special case - which someone may be unlikely to test. Then no the question ...
Peilonrayz's user avatar
  • 43.4k
12 votes

Does a single shell command constitute reviewable code?

Short answer: Yes. Longer Answer: As long as it works and all requirements for a request are met I see no reason why not; code length has never been an explicit requirement of any review request. ...
Legato's user avatar
  • 9,829
12 votes
Accepted

Can I include a short story of implementation?

There is an existing mechanism to deal with "I had this specific problem X and fixed it using Y" in the context of the Stackexchange network: A self-answered question. Since you're describing ...
Vogel612's user avatar
  • 25.2k
12 votes
Accepted

Can I ask to review my ebuild or rpmspec file?

Sure, questions like that would be on-topic. I would consider them similar to makefile and dockerfile questions. We encourage you to post your scripts for review.
200_success's user avatar
12 votes

When are Machine Learning questions on-topic?

I'll replace the "Machine Learning" parts of your question with "code" to keep it simple. After all, that's what it is. "My code is learning too slow" But it works, right? If that's the only issue,...
Mast's user avatar
  • 13.4k
12 votes

Are vectorization requests on-topic?

Specific question Since I hammer-closed the question, and I added the comment, let me explain the reasoning I had, starting with a hypothetical case: Hypothetically, someone asks a question: "this ...
rolfl's user avatar
  • 97.4k
12 votes
Accepted

Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3)

Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3) Yes, we currently tag questions with python if it runs in a version or both versions of ...
Peilonrayz's user avatar
  • 43.4k
12 votes
Accepted

Requesting a comparative review of own code with third-party code

Code Review only allows for reviews of code that is written/maintained by the author. We have that requirement for multiple reasons, including legal (copyright) and moral (to avoid code-shaming). ...
200_success's user avatar
11 votes

Is stack overflow on-topic for Code Review?

To an extent, yes. In this particular case, no. I don't see a problem with allowing questions that have Stack Overflow Exceptions, provided the code works acceptably on a smaller input set. If we ...
Der Kommissar's user avatar
11 votes

Is asking for a review of boiler plate for a minimal repro okay?

I've been thinking about this question and I contend that it is indeed on topic. Now, in general, the second we see a name like FooBar, we hit the close button ...
RubberDuck's user avatar
  • 30.8k
11 votes
Accepted

Is it okay to ask for feedback on code you modified extensively but aren't the original author of?

We don't allow users to post other peoples code for three main reasons: (Described here) Moral / Polite Would you take the criticism upon yourself, and not blame the original authors? It's plain rude ...
Peilonrayz's user avatar
  • 43.4k
11 votes
Accepted

Why is "Building a good C++11 template library - compile-time checked enum array" on-topic?

I have long been uneasy about this opinion that interfaces are reviewable. In my opinion, it conflicts with the current site standard, which is that stub code is off-topic. I suppose that it might be ...
200_success's user avatar
11 votes
Accepted

Are questions mostly unrelated to the presented code on-topic?

Existing rules These are covered in multiple questions Question body: Should a post with no specific question(s) imply a general review? Should [programming-challenge] questions require a summary of ...
Peilonrayz's user avatar
  • 43.4k
11 votes
Accepted

Are responses to specific interview questions on-topic?

My opinion on this issue is that there are many ways for people to get through interviews ahead of other qualified people, it normally comes down to being better prepared for the interview, or being a ...
rolfl's user avatar
  • 97.4k

Only top scored, non community-wiki answers of a minimum length are eligible