37
votes
Accepted
Why are alternative solutions not welcome?
The site's name is Code Review for a reason. We review the code in question by pointing out mistakes, bugs, edge cases, etc. with an explanation. Just dumping some alternative implementation without ...
- 50.4k
29
votes
On the huge amount of work needed for a CR answer
IMO the answering scheme on SO is where the problem is. People answer quickies and get their upvotes, and walk away thinking they've made the Internet a better place.
Allow me to make a slight ...
- 75.1k
28
votes
Accepted
On the huge amount of work needed for a CR answer
I think it's unfair to Code Review to view reputation/vote as the metric for success of an answer or the real impact of your answer. The vote/reputation is a metric for Stack Exchange, but I feel here ...
- 6,711
26
votes
Accepted
Is simply telling someone to use an API an appropriate code review?
I believe it is a valid code review .... sometimes perhaps even the best code review is: Why are you doing all this hard work, just use that ...
In specific cases where the user is intentionally ...
- 97.5k
20
votes
Accepted
Reviewing Programming Challenge requirements and givens
Is it on-topic to review a challenge's requirements? To the extent that the requirements force bad code, Yes.
The core of every question at Code Review is "How can I make this code better?" It is not ...
- 1,026
17
votes
Why are alternative solutions not welcome?
Why are alternative solutions not welcome?
They are. Note the text:
You have presented an alternative solution, but haven't reviewed the code.
The problem is not that it shows an alternative ...
- 21.7k
17
votes
Accepted
Is there a limit to the number of answers a user can post to one single question?
<moderator-hat>
The first thing that comes to mind is "this user is trying to somehow
abuse the system to farm upvotes, badges, and reputation score."
...
- 75.1k
16
votes
On the huge amount of work needed for a CR answer
I think you'd be interested in Mat's Mug's answer to "What is the motivation to spend time doing a code review?":
I monitor and answer Stack Overflow questions in the vba tag - a tiny little tag in ...
PeilonrayzMod
- 43.5k
16
votes
Making great content more visible
You can do this using bounties.
Get an answer you want to reward. Take this one (this is the question I got the images below on).
Select the 'start a bounty' option.
Select the size of the bounty ...
PeilonrayzMod
- 43.5k
16
votes
Accepted
15
votes
Accepted
Advice without knowledge of specific language
I personally have a bit of a history with writing reviews for languages I don't know squat about. Some of these reviews got comments like yours, where people pointed out syntax errors to me (and ...
- 25.3k
15
votes
Alternate solution - what counts as an insightful observation?
The problem starts with the question, which is barely on topic and would be a better fit on Stack Overflow.
That said, a comparison between your original answer and Reinderien's seems to illustrate ...
- 24.2k
13
votes
Advice without knowledge of specific language
Our How do I write a good answer? guidelines state that
Every answer must make at least one insightful observation about the code in the question.
but also that
We don't expect every answer to ...
- 23.5k
12
votes
On the huge amount of work needed for a CR answer
I think the real question is whether there actually is a problem.
The answers are generally longer here, but I suspect the relative amount of high-quality posts is also higher. One-liner answers you ...
MastMod
- 13.5k
12
votes
Inline review format
My opinion is that I find this much harder to read:
The review comments are visually similar to comments in the original code.
One has to scroll through the tiny code window (my usual browser window ...
- 81.7k
12
votes
Accepted
Should answers refrain from referring to other answers on the same question?
I regularly reference other people's answers when I answer questions. I typically also include a link to that answer. I feel it is important to show where the answers are different, disagree, or ...
- 97.5k
12
votes
Why should I be able to answer my own question in the question's editor on Code Review?
I cannot conceive of a reason to have the answer-immediate option on a question post. Sure, we do have good reasons to answer our own questions, but there's no good reason to answer it at the same ...
- 97.5k
12
votes
Accepted
Is an answer that doesn't provide any code review, only how to unit test on-topic?
The "on-topicness" for answers is not nearly as clear-cut as for questions (and even that has plenty of grey areas). The very first sentence, on its own, is enough to make it a valid code review: "...
- 97.5k
12
votes
Accepted
Reviewing non-working code when author thinks it's working?
If we take a look at https://codereview.stackexchange.com/help/on-topic we see
To the best of my knowledge, does the code work as intended? if the OP answered this for him/her-self with yes, then the ...
- 50.4k
11
votes
Indentation in answers
There's no unwritten rule for that, no.
People (me included) edit answers to improve formatting all the time, here or anywhere else on SE - there's even incentives (imaginary Internet points!) for ...
- 75.1k
11
votes
Accepting without upvoting
Technical limitations:
Upvotes require 15 rep. Accepts do not.
Self-Answers can not be upvoted.
Every user is limited to 40 votes per day. Accepts are not subject to that limitation
Non-Technical ...
- 25.3k
10
votes
Accepted
Peer review a code review?
As in any academic pursuit, the most interesting answers are ones that lead to more questions! Some of my Code Review answers have also been reposted as questions:
Reddit mirror encryption challenge
...
- 144k
10
votes
Why has my suggested edit to rename some variables in an answer been rejected?
I didn't reject your edit, but I would have rejected it too.
Naming is hard, but the variable name shows the intent for the variable. Simply put, changing the variable name changes the real meaning ...
PeilonrayzMod
- 43.5k
10
votes
What about questions which demands expert opinion and design feedback
First, let me specifically answer your three points and why I think they are helpful answers on Code Review:
Many programming languages have agreed-upon styles. Where this is the case you should use ...
- 41.1k
10
votes
Accepted
What about questions which demands expert opinion and design feedback
First of all, two related meta-questions:
Can we ask reviewers to *not* focus on something?
Reviewing "design"
My experience is that Code Review answers are personalized to what the ...
- 59.4k
9
votes
Accepted
How should we handle answers on non-code questions?
Off topic questions shouldn't get answers. If we're just too slow in closing off-topic questions, they still shouldn't get any answers.
Drop the poster of the answer a comment, indicating that the ...
- 25.3k
9
votes
Is there a limit to the number of answers a user can post to one single question?
Is 'flooding' allowed?
I vote for NO, let's not allow this.
At what point does answering become 'flooding'?
When two answers (of the same user) don't conflict.
That is, two answers conflict when ...
- 112k
9
votes
Accepted
Text minimum in questions
Questions and answers that consist of code and no supplementary explanation are colloquially known as "code dumps", and are generally not appreciated on this site. The minimum text requirement is an ...
- 144k
9
votes
Accepted
How has an on-hold question been answered?
There's a window of 4 hours (often referred to as "grace period") after a question being closed in which answers can still be posted.
The "Post Your Answer" button and the box in which to type your ...
MastMod
- 13.5k
9
votes
Making great content more visible
If I get this question correctly then it's not (primarily) about voting more for answers that are of good quality but to make them somehow visible so more people can learn from them.
Well, I think ...
- 44.3k
Only top scored, non community-wiki answers of a minimum length are eligible