Hot answers tagged

37 votes
Accepted

Why are alternative solutions not welcome?

The site's name is Code Review for a reason. We review the code in question by pointing out mistakes, bugs, edge cases, etc. with an explanation. Just dumping some alternative implementation without ...
Heslacher's user avatar
  • 50.4k
34 votes
Accepted

Should pedantry be discouraged?

The answer that you are referring to has been voted up quite a bit. I'd like to point out that we cannot really predict or influence how the votes go. People tend to upvote stuff that they find ...
200_success's user avatar
29 votes

On the huge amount of work needed for a CR answer

IMO the answering scheme on SO is where the problem is. People answer quickies and get their upvotes, and walk away thinking they've made the Internet a better place. Allow me to make a slight ...
Mathieu Guindon's user avatar
28 votes
Accepted

On the huge amount of work needed for a CR answer

I think it's unfair to Code Review to view reputation/vote as the metric for success of an answer or the real impact of your answer. The vote/reputation is a metric for Stack Exchange, but I feel here ...
Marc-Andre's user avatar
  • 6,701
26 votes
Accepted

Is simply telling someone to use an API an appropriate code review?

I believe it is a valid code review .... sometimes perhaps even the best code review is: Why are you doing all this hard work, just use that ... In specific cases where the user is intentionally ...
rolfl's user avatar
  • 97.3k
21 votes
Accepted

Is it acceptable for an answer to contain fully rewritten code?

Is it acceptable to provide fully rewritten code in the answer of a CodeReview question? Yes. Actually I done this the other day. Do you have to? No. Is it encouraged? No. Is it discouraged? If it ...
Peilonrayz's user avatar
  • 43k
20 votes

Should pedantry be discouraged?

That answer is .... a little special For what it's worth, pedantry is explicitly encouraged on Code Review. It helps find problems in code and makes it easier to maintain. To enjoy writing answers ...
Vogel612's user avatar
  • 25.2k
20 votes
Accepted

Reviewing Programming Challenge requirements and givens

Is it on-topic to review a challenge's requirements? To the extent that the requirements force bad code, Yes. The core of every question at Code Review is "How can I make this code better?" It is not ...
benj2240's user avatar
  • 1,016
19 votes
Accepted

Code Score Cards

How does a score card actually help the OP? Telling them their code sucks, without explaining how to improve it, is no benefit to anybody. Telling them how to improve it, by definition, involves ...
Kaz's user avatar
  • 8,790
17 votes

Why are alternative solutions not welcome?

Why are alternative solutions not welcome? They are. Note the text: You have presented an alternative solution, but haven't reviewed the code. The problem is not that it shows an alternative ...
mdfst13's user avatar
  • 21.5k
17 votes
Accepted

Is there a limit to the number of answers a user can post to one single question?

<moderator-hat> The first thing that comes to mind is "this user is trying to somehow abuse the system to farm upvotes, badges, and reputation score." ...
Mathieu Guindon's user avatar
16 votes

Should pedantry be discouraged?

No IMO, the only useful criteria for answers is Is it a net improvement? (however small). That answer is useful, not by a huge amount, but still an improvement. The moment you start saying "...
Kaz's user avatar
  • 8,790
16 votes

On the huge amount of work needed for a CR answer

I think you'd be interested in Mat's Mug's answer to "What is the motivation to spend time doing a code review?": I monitor and answer Stack Overflow questions in the vba tag - a tiny little tag in ...
Peilonrayz's user avatar
  • 43k
16 votes

Making great content more visible

You can do this using bounties. Get an answer you want to reward. Take this one (this is the question I got the images below on). Select the 'start a bounty' option. Select the size of the bounty ...
Peilonrayz's user avatar
  • 43k
16 votes
Accepted

Disable Anonymous Contributions

Disable anonymous users editing posts
Peilonrayz's user avatar
  • 43k
15 votes

Is it really necessary to explain trivial answers?

Your example of x = a + 1 + b - 1 is a bit disingenuous. As on the main site, we should be discussing real code rather than hypothetical examples. I see from your ...
200_success's user avatar
15 votes

Alternate solution - what counts as an insightful observation?

The problem starts with the question, which is barely on topic and would be a better fit on Stack Overflow. That said, a comparison between your original answer and Reinderien's seems to illustrate ...
Peter Taylor's user avatar
  • 24.1k
14 votes
Accepted

Advice without knowledge of specific language

I personally have a bit of a history with writing reviews for languages I don't know squat about. Some of these reviews got comments like yours, where people pointed out syntax errors to me (and ...
Vogel612's user avatar
  • 25.2k
12 votes
Accepted

If my review includes code, must it be a perfectly working solution to the OP's problem?

TL;DR; No, but you may get flak downvotes if you don't say it From my experience Code Review doesn't have any "criteria" for answers, aside from "It reviews the OP's code and justifies what it ...
Vogel612's user avatar
  • 25.2k
12 votes
Accepted

Is nitpicking worthy of a full answer?

What is left after that are details: naming conventions, style conventions, things that are not bugs that affect results, things that are not important. I beg to differ. Readability is a major point ...
Mast's user avatar
  • 13.3k
12 votes

On the huge amount of work needed for a CR answer

I think the real question is whether there actually is a problem. The answers are generally longer here, but I suspect the relative amount of high-quality posts is also higher. One-liner answers you ...
Mast's user avatar
  • 13.3k
12 votes

Inline review format

My opinion is that I find this much harder to read: The review comments are visually similar to comments in the original code. One has to scroll through the tiny code window (my usual browser window ...
Toby Speight's user avatar
  • 74.5k
12 votes
Accepted

Should answers refrain from referring to other answers on the same question?

I regularly reference other people's answers when I answer questions. I typically also include a link to that answer. I feel it is important to show where the answers are different, disagree, or ...
rolfl's user avatar
  • 97.3k
12 votes
Accepted

Is an answer that doesn't provide any code review, only how to unit test on-topic?

The "on-topicness" for answers is not nearly as clear-cut as for questions (and even that has plenty of grey areas). The very first sentence, on its own, is enough to make it a valid code review: "...
rolfl's user avatar
  • 97.3k
12 votes

Advice without knowledge of specific language

Our How do I write a good answer? guidelines state that Every answer must make at least one insightful observation about the code in the question. but also that We don't expect every answer to ...
Martin R's user avatar
  • 23.2k
11 votes

Is nitpicking worthy of a full answer?

things that are not bugs that affect results, things that are not important. If OP's code has so many bugs that affect results that all they're expecting out of a peer review is "where are my bugs?", ...
Mathieu Guindon's user avatar
11 votes

Indentation in answers

There's no unwritten rule for that, no. People (me included) edit answers to improve formatting all the time, here or anywhere else on SE - there's even incentives (imaginary Internet points!) for ...
Mathieu Guindon's user avatar
11 votes

Why should I be able to answer my own question in the question's editor on Code Review?

I cannot conceive of a reason to have the answer-immediate option on a question post. Sure, we do have good reasons to answer our own questions, but there's no good reason to answer it at the same ...
rolfl's user avatar
  • 97.3k
11 votes

Accepting without upvoting

Technical limitations: Upvotes require 15 rep. Accepts do not. Self-Answers can not be upvoted. Every user is limited to 40 votes per day. Accepts are not subject to that limitation Non-Technical ...
Vogel612's user avatar
  • 25.2k
11 votes
Accepted

Reviewing non-working code when author thinks it's working?

If we take a look at https://codereview.stackexchange.com/help/on-topic we see To the best of my knowledge, does the code work as intended? if the OP answered this for him/her-self with yes, then the ...
Heslacher's user avatar
  • 50.4k

Only top scored, non community-wiki answers of a minimum length are eligible